From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:58636)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iTlRr-0007Ej-GO
 for guix-patches@gnu.org; Sun, 10 Nov 2019 06:32:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iTlRq-0001Ba-EU
 for guix-patches@gnu.org; Sun, 10 Nov 2019 06:32:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:41898)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iTlRq-0001BT-BZ
 for guix-patches@gnu.org; Sun, 10 Nov 2019 06:32:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iTlRq-000317-4f
 for guix-patches@gnu.org; Sun, 10 Nov 2019 06:32:02 -0500
Subject: [bug#38059] [PATCH 3/3] services: Add pagekite-service-type.
Resent-Message-ID: <handler.38059.B38059.157338550211562@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <2303a2c2-9d07-4986-9444-0f371592643f@www.fastmail.com>
 <04d1c886-0279-4ca1-8005-4fa1526d834d@www.fastmail.com>
Date: Sun, 10 Nov 2019 12:31:30 +0100
In-Reply-To: <04d1c886-0279-4ca1-8005-4fa1526d834d@www.fastmail.com> (Alex
 Griffin's message of "Wed, 06 Nov 2019 18:19:43 +0000")
Message-ID: <8736ew55nx.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Alex Griffin <a@ajgrf.com>
Cc: 38059@debbugs.gnu.org

Hi,

"Alex Griffin" <a@ajgrf.com> skribis:

> From 46a5e48f5e89be4da3611bd11b55ed0e325c6538 Mon Sep 17 00:00:00 2001
> From: Alex Griffin <a@ajgrf.com>
> Date: Mon, 4 Nov 2019 19:29:24 -0600
> Subject: [PATCH 3/3] services: Add pagekite-service-type.
>
> * gnu/services/networking.scm (pagekite-service-type): New service type.
> (<pagekite-configuration>): New record type.
> (pagekite-shepherd-service): New procedure.
> * doc/guix.texi (Networking Services): Document it.

[...]

> +(define pagekite-configuration-file
> +  (match-lambda
> +    (($ <pagekite-configuration> package kitename kitesecret
> +                                 frontend kites extra-file)

[...]

> +(define (pagekite-shepherd-service config)
> +  (match config
> +    (($ <pagekite-configuration> package kitename kitesecret
> +                                 frontend kites extra-file)

I recommend using =E2=80=98match-record=E2=80=99 in these two cases since i=
t matches
fields by name and is thus less error-prone.

> +        (start #~(make-forkexec-constructor/container

Nice.  :-)

Is there some meaningful test that could be written for this service?  I
suppose it=E2=80=99d be hard to test without also running a relay.  Anyway,=
 if
you can think of a non-trivial test that could detect regressions,
you=E2=80=99re welcome to add it to (gnu tests =E2=80=A6).

Otherwise LGTM!

Thanks,
Ludo=E2=80=99.