From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:55161) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iX5uC-0005jd-5z for guix-patches@gnu.org; Tue, 19 Nov 2019 10:59:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iX5uB-0006rx-60 for guix-patches@gnu.org; Tue, 19 Nov 2019 10:59:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:39455) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iX5uB-0006rn-2x for guix-patches@gnu.org; Tue, 19 Nov 2019 10:59:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iX5uA-0007wL-FN for guix-patches@gnu.org; Tue, 19 Nov 2019 10:59:02 -0500 Subject: [bug#38268] [PATCH] Add llvm-9, clang-9 and clang-toolchain-9 Resent-Message-ID: Received: from eggs.gnu.org ([2001:470:142:3::10]:55042) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iX5tJ-0005gr-3R for guix-patches@gnu.org; Tue, 19 Nov 2019 10:58:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iX5tI-0006H5-4N for guix-patches@gnu.org; Tue, 19 Nov 2019 10:58:09 -0500 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]:38528) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iX5tH-0006GJ-Su for guix-patches@gnu.org; Tue, 19 Nov 2019 10:58:08 -0500 Received: by mail-wr1-x430.google.com with SMTP id i12so24480268wro.5 for ; Tue, 19 Nov 2019 07:58:07 -0800 (PST) References: <20191119134620.17085-1-david.truby@arm.com> From: Mathieu Othacehe In-reply-to: <20191119134620.17085-1-david.truby@arm.com> Date: Tue, 19 Nov 2019 16:58:03 +0100 Message-ID: <8736ej5050.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 38268@debbugs.gnu.org Cc: nd@arm.com, David.Truby@arm.com Hello David, This patch LGTM. However, you need to write a commit log compliant with ChangeLog format. See: https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html. Can you please send a v2 :) ? Thanks, Mathieu