From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:37754) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZV4t-0005Nj-00 for guix-patches@gnu.org; Tue, 26 Nov 2019 02:16:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZV4r-0008W4-SQ for guix-patches@gnu.org; Tue, 26 Nov 2019 02:16:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:44173) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iZV4r-0008Vy-P4 for guix-patches@gnu.org; Tue, 26 Nov 2019 02:16:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iZV4r-0001Ik-Kp for guix-patches@gnu.org; Tue, 26 Nov 2019 02:16:01 -0500 Subject: [bug#38376] [PATCH] gnu: clang: Fix search path detection with --sysroot. Resent-Message-ID: References: <20191125180144.1060289-1-contact@carldong.me> From: Mathieu Othacehe In-reply-to: <20191125180144.1060289-1-contact@carldong.me> Date: Tue, 26 Nov 2019 08:15:20 +0100 Message-ID: <8736ebt8fr.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Carl Dong Cc: 38376@debbugs.gnu.org Hello Carl, > This was fine when running clang normally, but when a user supplies > clang with --sysroot, clang _should_ do the search path detection. This > commit fixes runing clang with --sysroot. Thanks for your patch. Do you think this could be done in a way that can be upstreamed? In lib/Driver/ToolChains/Gnu.cpp, there are some Gentoo specific stuff, maybe they would agree to integrate some Guix/nix specific stuff too. WDYT? Mathieu