unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#38552] [PATCH 0/1] Dynamically-link Ruby
@ 2019-12-09 20:53 Brett Gilio
  2019-12-09 20:54 ` [bug#38552] [PATCH 1/1] gnu: ruby: Configure for dynamic linking Brett Gilio
  2019-12-09 20:55 ` [bug#38552] [PATCH 0/1] Dynamically-link Ruby Brett Gilio
  0 siblings, 2 replies; 6+ messages in thread
From: Brett Gilio @ 2019-12-09 20:53 UTC (permalink / raw)
  To: 38552

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: [PATCH 0/1] Dynamically-link Ruby --]
[-- Type: text/x-patch, Size: 447 bytes --]

From 36e56ea5d882d112f24d49050813066eece98af2 Mon Sep 17 00:00:00 2001
From: Brett Gilio <brettg@posteo.net>
Date: Mon, 9 Dec 2019 14:50:51 -0600
Subject: [PATCH 0/1] Dynamically-link Ruby
To: guix-patches@gnu.org

This patch solves #38500. The current behavior of Ruby is to compile against libruby-static.a

Brett Gilio (1):
  gnu: ruby: Configure for dynamic linking.

 gnu/packages/ruby.scm | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.24.0

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#38552] [PATCH 1/1] gnu: ruby: Configure for dynamic linking.
  2019-12-09 20:53 [bug#38552] [PATCH 0/1] Dynamically-link Ruby Brett Gilio
@ 2019-12-09 20:54 ` Brett Gilio
  2019-12-09 21:12   ` Jonathan Brielmaier
  2019-12-13  3:49   ` bug#38552: " Brett Gilio
  2019-12-09 20:55 ` [bug#38552] [PATCH 0/1] Dynamically-link Ruby Brett Gilio
  1 sibling, 2 replies; 6+ messages in thread
From: Brett Gilio @ 2019-12-09 20:54 UTC (permalink / raw)
  To: 38552

[-- Attachment #1: [PATCH 1/1] gnu: ruby: Configure for dynamic linking. --]
[-- Type: text/x-patch, Size: 1291 bytes --]

From 36e56ea5d882d112f24d49050813066eece98af2 Mon Sep 17 00:00:00 2001
From: Brett Gilio <brettg@posteo.net>
Date: Mon, 9 Dec 2019 14:46:47 -0600
Subject: [PATCH 1/1] gnu: ruby: Configure for dynamic linking.
To: guix-patches@gnu.org

* gnu/packages/ruby.scm (ruby)[arguments]: Use #:configure-flags to properly
  enable dynamic linking instead of using libruby-static.a. Solves #38500.

Reported-by: Vicente Eduardo <vic798@gmail.com>
---
 gnu/packages/ruby.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 70b59e9156..a4b9bc6968 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -19,6 +19,7 @@
 ;;; Copyright © 2019 Brian Leung <bkleung89@gmail.com>
 ;;; Copyright © 2019 Collin J. Doering <collin@rekahsoft.ca>
 ;;; Copyright © 2019 Diego N. Barbato <dnbarbato@posteo.de>
+;;; Copyright © 2019 Brett Gilio <brettg@posteo.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -95,6 +96,7 @@
     (build-system gnu-build-system)
     (arguments
      `(#:test-target "test"
+       #:configure-flags '("--enable-shared") ; dynamic linking
        #:phases
        (modify-phases %standard-phases
          (add-before 'configure 'replace-bin-sh-and-remove-libffi
-- 
2.24.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#38552] [PATCH 0/1] Dynamically-link Ruby
  2019-12-09 20:53 [bug#38552] [PATCH 0/1] Dynamically-link Ruby Brett Gilio
  2019-12-09 20:54 ` [bug#38552] [PATCH 1/1] gnu: ruby: Configure for dynamic linking Brett Gilio
@ 2019-12-09 20:55 ` Brett Gilio
  1 sibling, 0 replies; 6+ messages in thread
From: Brett Gilio @ 2019-12-09 20:55 UTC (permalink / raw)
  To: 38552

Brett Gilio <brettg@posteo.net> writes:

>>From 36e56ea5d882d112f24d49050813066eece98af2 Mon Sep 17 00:00:00 2001
> From: Brett Gilio <brettg@posteo.net>
> Date: Mon, 9 Dec 2019 14:50:51 -0600
> Subject: [PATCH 0/1] Dynamically-link Ruby
> To: guix-patches@gnu.org
>
> This patch solves #38500. The current behavior of Ruby is to compile against libruby-static.a
>
> Brett Gilio (1):
>   gnu: ruby: Configure for dynamic linking.
>
>  gnu/packages/ruby.scm | 2 ++
>  1 file changed, 2 insertions(+)

I forgot to mention that this should go in core-update since it triggers
a rebuild of 3000+ packages. I am happy to push this to core-updates if
everything looks alright.

-- 
Brett M. Gilio
https://git.sr.ht/~brettgilio/

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#38552] [PATCH 1/1] gnu: ruby: Configure for dynamic linking.
  2019-12-09 20:54 ` [bug#38552] [PATCH 1/1] gnu: ruby: Configure for dynamic linking Brett Gilio
@ 2019-12-09 21:12   ` Jonathan Brielmaier
  2019-12-09 22:13     ` Brett Gilio
  2019-12-13  3:49   ` bug#38552: " Brett Gilio
  1 sibling, 1 reply; 6+ messages in thread
From: Jonathan Brielmaier @ 2019-12-09 21:12 UTC (permalink / raw)
  To: Brett Gilio, 38552

On 09.12.19 21:54, Brett Gilio wrote:
> Subject: [PATCH 1/1] gnu: ruby: Configure for dynamic linking.
> To: guix-patches@gnu.org
>
> * gnu/packages/ruby.scm (ruby)[arguments]: Use #:configure-flags to properly
>   enable dynamic linking instead of using libruby-static.a. Solves #38500.
>
> Reported-by: Vicente Eduardo <vic798@gmail.com>

Maybe change the commit format a little:

Fixes <https://bugs.gnu.org/38500>.
Reported-by: Vicente Eduardo <vic798@gmail.com>

* gnu/packages/ruby.scm (ruby)[arguments]: Use #:configure-flags to
properly enable dynamic linking instead of using libruby-static.a.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#38552] [PATCH 1/1] gnu: ruby: Configure for dynamic linking.
  2019-12-09 21:12   ` Jonathan Brielmaier
@ 2019-12-09 22:13     ` Brett Gilio
  0 siblings, 0 replies; 6+ messages in thread
From: Brett Gilio @ 2019-12-09 22:13 UTC (permalink / raw)
  To: Jonathan Brielmaier; +Cc: 38552

Jonathan Brielmaier <jonathan.brielmaier@web.de> writes:
>
> Maybe change the commit format a little:
>
> Fixes <https://bugs.gnu.org/38500>.
> Reported-by: Vicente Eduardo <vic798@gmail.com>
>
> * gnu/packages/ruby.scm (ruby)[arguments]: Use #:configure-flags to
> properly enable dynamic linking instead of using libruby-static.a.


Sounds like a good idea. Consider it done.

I will wait for more eyes before pushing to core-updates. Thank you Jonathan.

-- 
Brett M. Gilio
https://git.sr.ht/~brettgilio/

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#38552: [PATCH 1/1] gnu: ruby: Configure for dynamic linking.
  2019-12-09 20:54 ` [bug#38552] [PATCH 1/1] gnu: ruby: Configure for dynamic linking Brett Gilio
  2019-12-09 21:12   ` Jonathan Brielmaier
@ 2019-12-13  3:49   ` Brett Gilio
  1 sibling, 0 replies; 6+ messages in thread
From: Brett Gilio @ 2019-12-13  3:49 UTC (permalink / raw)
  To: 38552-done

Pushed to core-updates with fd248cb815d571043c3a0c52a01c9b3e368a069e.

Closing.

-- 
Brett M. Gilio
Homepage -- https://scm.pw/
GNU Guix -- https://guix.gnu.org/

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-12-13  3:51 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-09 20:53 [bug#38552] [PATCH 0/1] Dynamically-link Ruby Brett Gilio
2019-12-09 20:54 ` [bug#38552] [PATCH 1/1] gnu: ruby: Configure for dynamic linking Brett Gilio
2019-12-09 21:12   ` Jonathan Brielmaier
2019-12-09 22:13     ` Brett Gilio
2019-12-13  3:49   ` bug#38552: " Brett Gilio
2019-12-09 20:55 ` [bug#38552] [PATCH 0/1] Dynamically-link Ruby Brett Gilio

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).