From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:53247) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBowl-0002rL-R2 for guix-patches@gnu.org; Tue, 10 Mar 2020 20:10:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jBowk-0001n0-RW for guix-patches@gnu.org; Tue, 10 Mar 2020 20:10:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47501) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jBowk-0001mr-PH for guix-patches@gnu.org; Tue, 10 Mar 2020 20:10:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jBowk-0000Tn-Iy for guix-patches@gnu.org; Tue, 10 Mar 2020 20:10:02 -0400 Subject: [bug#40016] [PATCH] inferior: Distinguish inferior exceptions. Resent-Message-ID: References: <20200310160305.15865-1-ludo@gnu.org> <878sk8t8vr.fsf@gnu.org> From: Christopher Baines In-reply-to: <878sk8t8vr.fsf@gnu.org> Date: Wed, 11 Mar 2020 00:09:29 +0000 Message-ID: <8736afeoqu.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 40016@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Ludovic Court=C3=A8s skribis: > >> This avoids ambiguities when looking at a backtrace where the exception >> was actually thrown by an inferior in a very different context. > > The idea was suggested at the Guix Days by someone who had had a hard > time looking at one of these weird backtraces, until you realize the > exception was actually thrown by another process. > > There are a few places in the Data Service that do things like: > > (catch 'misc-error > (lambda () > (inferior-eval =E2=80=A6)) > =E2=80=A6) > > This will have to be adjusted. Does that work for you, Chris? Yeah that sounds fine. Generally I think it's good to keep backwards compatibility with the Guix Data Service, so I'd be looking to support both ways exceptions can be raised, but that doesn't seem to difficult. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl5oLDlfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XeGDg/+M+zUb1k+1Cg+aYN2c0PPMp7QUWyNoFlK0lpGwkQK6G6TPbqRPrOfAudj +5R9aAG/rjemcknUsghN0rdbmDOkz0DxV+NHfFS5X9G3dHNqocDpSqJcYkQ8P4GB 9b0Nt+17Jht+4D0e40v7N9OTjINO/b+bqFvaSQU34kp5HcKOtFDFZpiVgcY2bHOZ 7YWvDImPJP2m0TdoTHyyA1DC4EYq7nCKSc1CudIC9uI2fcENHuK8QohK6M6M9Jd3 ExFzZEA0mZYAm4fXXKjqNd7o4Xsra2gmST/jW4I9ymUIepYa15szu5e6rRjUSc/q O19+gyenEPHV0qg7JxTEv74pDo8JubJIE+hWvstGehAFEh0V4XiQxixdCyDylH32 CiXgQHIgJ4ph//FECO6dT7yBndjgAa6WqjPAoIJtCds6740OEANPJM2dy7PISU6R PTfGbCvl+mK/Vr6yjI9KxP4KC4tuvsTuhRUE6Se7qJrc9r177soFYfolMLjlwctR QVyGNF6vZ5jl9G4TLaLUlNfMm6UGfgmgy8KI0Me4s+ekfG77FxN8nbLbrQP2y9mj 6AxcLlbwUC7EQzYU43+2OnsO38zCemB8RaQuansVRnbaIc5clUG/CGi7+NDZ+c41 8IX88CURP/q1TlZUF2+S2KMSUDNGIt59qp+Ba8qLea6Ea4JLuw8= =Mv+m -----END PGP SIGNATURE----- --=-=-=--