unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#40197] [PATCH] gnu: sord: Add pcre to inputs.
@ 2020-03-23 16:56 Alexandros Theodotou
  2020-03-23 19:54 ` Mathieu Othacehe
  0 siblings, 1 reply; 2+ messages in thread
From: Alexandros Theodotou @ 2020-03-23 16:56 UTC (permalink / raw)
  To: 40197


[-- Attachment #1.1: Type: text/plain, Size: 354 bytes --]

Hi,

Sord did not have the `sord_validate` binary (which is needed for
`lv2_validate` from the lv2 package to function properly).

I looked it up and apparently it needs pcre to build:
https://gitlab.com/drobilla/sord/-/blob/master/wscript#L211

I have verified that adding pcre as an input now produces sord_validate
in /bin.

Thanks,
Alex

[-- Attachment #1.2: 0001-gnu-sord-Add-pcre-to-inputs.patch --]
[-- Type: text/x-patch, Size: 839 bytes --]

From 3edad6b801d4328e0ebdf9a9244a00fcbd8fda70 Mon Sep 17 00:00:00 2001
From: Alexandros Theodotou <alex@zrythm.org>
Date: Mon, 23 Mar 2020 16:51:44 +0000
Subject: [PATCH] gnu: sord: Add pcre to inputs.

* gnu/packages/rdf.scm (sord): Add pcre needed for sord_validate
---
 gnu/packages/rdf.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/rdf.scm b/gnu/packages/rdf.scm
index b9abd37e40..15f8d64d43 100644
--- a/gnu/packages/rdf.scm
+++ b/gnu/packages/rdf.scm
@@ -319,6 +319,8 @@ ideal (e.g. in LV2 implementations or embedded applications).")
                     (string-append "-Wl,-rpath="
                                    (assoc-ref outputs "out") "/lib"))
             #t)))))
+    (inputs
+     `(("pcre" ,pcre)))
     (native-inputs
      `(("pkg-config" ,pkg-config)))
     (propagated-inputs
-- 
2.25.1


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [bug#40197] [PATCH] gnu: sord: Add pcre to inputs.
  2020-03-23 16:56 [bug#40197] [PATCH] gnu: sord: Add pcre to inputs Alexandros Theodotou
@ 2020-03-23 19:54 ` Mathieu Othacehe
  0 siblings, 0 replies; 2+ messages in thread
From: Mathieu Othacehe @ 2020-03-23 19:54 UTC (permalink / raw)
  To: 40197; +Cc: 40197-done


Hello,

> I looked it up and apparently it needs pcre to build:
> https://gitlab.com/drobilla/sord/-/blob/master/wscript#L211
>
> I have verified that adding pcre as an input now produces sord_validate
> in /bin.

Thanks for this patch. I added your copyright, edited a bit the commit
message and pushed.

Mathieu

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-03-23 19:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-23 16:56 [bug#40197] [PATCH] gnu: sord: Add pcre to inputs Alexandros Theodotou
2020-03-23 19:54 ` Mathieu Othacehe

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).