From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:51950) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSzI8-0005xm-Dc for guix-patches@gnu.org; Mon, 27 Apr 2020 04:39:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jSzI7-0002Wc-Ri for guix-patches@gnu.org; Mon, 27 Apr 2020 04:39:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52295) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jSzI7-0002WN-Du for guix-patches@gnu.org; Mon, 27 Apr 2020 04:39:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jSzI6-0000Qe-Bn for guix-patches@gnu.org; Mon, 27 Apr 2020 04:39:02 -0400 Subject: [bug#40753] gnu: spacefm: Add dependencies for extra functionality. Resent-Message-ID: From: Jan Nieuwenhuizen References: <20200421172812.6227b2eb.raghavgururajan@disroot.org> <20200424153558.2aa79ef0.raghavgururajan@disroot.org> <87h7x8wsr8.fsf@gnu.org> <20200425221143.1a587483.raghavgururajan@disroot.org> <87lfmis5wm.fsf@gnu.org> <20200427022956.7c7d7263.raghavgururajan@disroot.org> Date: Mon, 27 Apr 2020 10:37:52 +0200 In-Reply-To: <20200427022956.7c7d7263.raghavgururajan@disroot.org> (Raghav Gururajan's message of "Mon, 27 Apr 2020 02:29:56 -0400") Message-ID: <87368p5nof.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Raghav Gururajan Cc: 40753@debbugs.gnu.org Raghav Gururajan writes: Hello Raghav, >> Does this work; SU is not SUDO? Also, I don't see how /bin/sudo >> would work. When I run this >>=20 >> $(guix build sudo)/bin/sudo=20 >>=20 >> I get >>=20 >> sudo: /gnu/store/l320ig872ny66d1yi6v7n4zb93iz50dx-sudo-1.8.31p1/bin/= sudo >> must be owned by uid 0 and have the setuid bit set >>=20 >> Am I missing something? > > The option just has the name "su". It can be sudo too. I wouldn't worry a= bout > this terminal_su option. That's okay, I'm not really worried :-) When I read a patch, and I cannot imagine how that would work, I would like to learn more to understand it beter, or remove it. I do not like adding code that I do not understand, and also does not work. > This is just has to be set, so that spacefm doesn't throw "no valid > program found" error, now and then, because of default FHS path. > SpaceFM primarily uses graphical_su, which has been set to 'ktsuss'. Okay, that would explain something. So, TERMINAL_SU just needs to be set to "some" existing executable, but is not used? What about `(#:phases (modify-phases %standard-phases (add-after 'unpack 'patch-spacefm-conf (lambda _ ;; If terminal_su is unset, users get a popup: ;; "Please configure a valid Terminal SU command." (substitute* "etc/spacefm.conf" (("#terminal_su=3D/bin/su") "terminal_su=3D/run/current-system/profile/bin/false")) #t))) I tested this, and it hase the same, partially functional result, as using sudo and setting #graphical_su. WDYT? >> > + (substitute* "etc/spacefm.conf" >> > + (("#graphical_su=3D/usr/bin/gksu") >> > + (string-append "graphical_su=3D" >> > + (string-append (assoc-ref inputs "ktsu= ss") >> > + "/bin/ktsuss")))) >> > + #t)))=20=20 >>=20 >> Changing the default configurations does not seem to work for me. When >> I select >>=20 >> /File/Root Window >>=20 >> there is a pop-up that says: Please configure a valid Terminal SU >> command. Does it work for You? > > This is exactly the error I was talking about above. Once we apply this p= atch, > the error appearing stops and ktsuss will pop right up. Hmm. Can you double check? I tested your patch again today it (still) does not work. I get Please configure a valid Terminal SU command. Only when I manually point spacefm to it's configuration file, like so /gnu/store/y24705ci3dcjiqdig3k3x18pc6aymnzc-spacefm-1.0.6/bin/spacefm -= c /gnu/store/y24705ci3dcjiqdig3k3x18pc6aymnzc-spacefm-1.0.6/etc/spacefm/ then the popup disappears. So now I am wondering, is the problem with your setup or with mine? What do you think? By the way, the KTSUSS popup (when I see it) does not work for me. Have you tested KTSUSS? Greetings, janneke --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com