From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id iB1iIMogwF5lNQAA0tVLHw (envelope-from ) for ; Sat, 16 May 2020 17:20:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id cL1gHMogwF4yPAAAB5/wlQ (envelope-from ) for ; Sat, 16 May 2020 17:20:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0A21C94050F for ; Sat, 16 May 2020 17:20:09 +0000 (UTC) Received: from localhost ([::1]:57848 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ja0To-0000Od-No for larch@yhetil.org; Sat, 16 May 2020 13:20:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48498) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ja0Ti-0000OS-Fn for guix-patches@gnu.org; Sat, 16 May 2020 13:20:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58345) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ja0Ti-0001Uc-6H for guix-patches@gnu.org; Sat, 16 May 2020 13:20:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ja0Ti-0004uX-1K for guix-patches@gnu.org; Sat, 16 May 2020 13:20:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41327] [PATCH] gnu: Add emacs-vcsh. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 16 May 2020 17:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41327 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Michael Rohleder Cc: 41327@debbugs.gnu.org Received: via spool by 41327-submit@debbugs.gnu.org id=B41327.158964957318836 (code B ref 41327); Sat, 16 May 2020 17:20:01 +0000 Received: (at 41327) by debbugs.gnu.org; 16 May 2020 17:19:33 +0000 Received: from localhost ([127.0.0.1]:41658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ja0TE-0004tj-RC for submit@debbugs.gnu.org; Sat, 16 May 2020 13:19:33 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:58893) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ja0TC-0004tV-Gy for 41327@debbugs.gnu.org; Sat, 16 May 2020 13:19:31 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id AAB97C0006; Sat, 16 May 2020 17:19:23 +0000 (UTC) From: Nicolas Goaziou References: <87ftbz986g.fsf@rohleder.de> Date: Sat, 16 May 2020 19:19:22 +0200 In-Reply-To: <87ftbz986g.fsf@rohleder.de> (Michael Rohleder's message of "Sat, 16 May 2020 18:05:43 +0200") Message-ID: <87367zx0f9.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: yqtOkIJ2sQ9p Hello, Michael Rohleder writes: > From f18c71cbad9860ae15907c5a74367b8ac55cb122 Mon Sep 17 00:00:00 2001 > From: Michael Rohleder > Date: Sat, 16 May 2020 18:01:49 +0200 > Subject: [PATCH] gnu: Add emacs-vcsh. Thank you for the patch. Some comments follow. > +(define-public emacs-vcsh > + (package > + (name "emacs-vcsh") > + (version "0.4.4") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://gitlab.com/stepnem/vcsh-el.git") > + (commit version))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "183pffdiqb7qqmjq31wxl3fpv8qswqgg99gb716rddiyk15ysri7")))) Nitpick: could you move the string on the line above? > + (build-system emacs-build-system) > + (home-page "https://gitlab.com/stepnem/vcsh-el") > + (synopsis "Emacs vcsh integration") > + (description > + "This library only provides basic \"enter\" functionality > +(`vcsh-link', `vcsh-unlink') and a few convenience commands > +(`vcsh-new' to init a repo and add files to it, > +`vcsh-write-gitignore'). Without writing too many details, I suggest This library provides basic ``enter'' functionality and a few convenience commands to init a repository and add files to it. However, it may be useful to write somewhere what is "vcsh". As a user, do I need/want that? > +Please note that this library works by creating a regular file > +named \".git\" inside $VCSH_BASE directory (typically $HOME) and does > +not remove this file automatically, so don't be surprised if your > +shell suddenly behaves as after \"vcsh enter\" when inside that > +directory. You can use `vcsh-unlink' or simply remove the file to > +get rid of it." I don't think this part is really useful as a description, i.e., it does belong to a manual instead. As a side note, descriptions use Texinfo syntax, so `vcsh-unlink' is written @code{vcsh-unlink}, etc. Could you send an updated patch? Regards, -- Nicolas Goaziou