Hello,

Tobias Geerinckx-Rice <me@tobias.gr> writes:

> Otherwise, ‘20’'s fine, really.

Fair enough.

>> +        ;; Use system Minizip.  This is discussed updstream at
>> +        ;; <https://github.com/widelands/widelands/issues/399>.
>> +        (search-patches "widelands-system-wide_minizip.patch"))))
>
> Minor typo (‘embeeded’).  Are you the ‘I’ in the patch?  Is it pending
> upstream application?  If so, a link to the upstream bug report/commit
> would be nice.

Typo fixed. I'm not the "I" in the patch. It is shipped in "debian/"
subdir. I mentioned it in a comment.

>> +         (list "-DCMAKE_BUILD_TYPE=Release"
>
> Why not the default RelWithDebInfo?  Please note in a comment.

I don't know. It seems to build fine without it, so I removed it.

> I'd put both at the end with a single
>
>  ;; Fonts for the ‘unbundle-fonts’ phase.  Case matters in name!

OK.

> I think Debian(-derived) descriptions are OK but I prefer
> yours/upstream's anyway.

I used upstream's.

>> +    ;; Game is released as GPL2+.  Some parts, e.g., art, are
>> released under
>> +    ;; different licenses.
>
> At least Culmus and Sinhala are GPL2-only.  

Are you sure? For example, I see GPL2 for Culmus, but it doesn't mention
"only" anywhere. Also, Debian's copyright file considers it GPL2+.

> The title screen also says
> ‘GNU General Public License V2.0’.

Source code is definitely GPL2+. I think Debian has a patch to fix the
title screen.

>> +    (license (list license:gpl2+
>> +                   license:gpl3+
>
> Which parts are gpl3+?  That sounds problematic.

None. That was probably an oversight.

>> +                   license:expat
>> +                   license:zlib
>> +                   license:silofl1.1
>> +                   license:asl2.0
>> +                   license:cc-by-sa3.0))))

I also removed zlib (minizip) and asl2.0 (microhei).

Thanks for the review. V3 attached.

Regards,
-- 
Nicolas Goaziou