Alexandros Theodotou <alex@zrythm.org> writes:

> Hi,
>
> This patch adds the ADLPlug LV2 plugin.

[...]

> * gnu/packages/music.scm (adlplug): New variable.

[...]
  
> +(define-public adlplug
> +  (package
> +    (name "adlplug")
> +    (version "1.0.1")
> +    (source
> +      (origin
> +        (method git-fetch)
> +        (uri (git-reference
> +               (url "https://github.com/jpcima/ADLplug.git")
> +               (commit (string-append "v" version))
> +               (recursive? #t))) ; uses 3rd party submodules

Is it possible to package these modules separately?

One of the submodules, uses a seemingly non-free license:

  https://juce.com/juce-5-license

Interestingly, it becomes a free license (GPL3) once you exceed a
certain revenue!?

IANAL and only had a cursory look, but am not comfortable adding this
without a larger discussion.  A good first step would be to package JUCE
separately and take it from there.

The other bundled packages seem fine, but it would be comforting to have
them in Guix even if this package needs the bundled versions.  I also
think we should mention their licenses -- especially since vst3sdk is
available as either a proprietary license or GPL3, and taking the latter
implies that this package _also_ becomes GPL3.

(btw, the bundled fmt library is already available)

So, this will be a tricky one.  Do you think you can look into packaging
the bundled components separately?