From: "Ludovic Courtès" <ludo@gnu.org>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: 42849-done@debbugs.gnu.org
Subject: [bug#42849] [PATCH 3/3] installer: Run the installation inside a container.
Date: Wed, 02 Sep 2020 22:17:43 +0200 [thread overview]
Message-ID: <8736403pco.fsf@gnu.org> (raw)
In-Reply-To: <87imcwtdkd.fsf@gnu.org> (Mathieu Othacehe's message of "Wed, 02 Sep 2020 17:15:30 +0200")
Hi!
Mathieu Othacehe <othacehe@gnu.org> skribis:
>> So perhaps we can settle on the solution you sent, but let’s see if we
>> can move complexity out of sight. For example, if we can arrange to
>> have a ‘fork+exec-command/container’ procedure that can be passed the
>> PID of a namespace, such that the ‘start’ method of guix-daemon is just
>> a few more lines its current definition, I’ll be happy.
>>
>> How does that sound?
>
> Sounds fine! I added a "fork+exec-command/container" in (gnu build
> shepherd) module, that uses "container-excursion" to enter the
> namespaces of the process passed as argument.
>
> I also took your other remarks into account and pushed this
> serie. Thanks a lot for diving into this harsh stuff :).
Awesome!
> Locally, the installer tests behave fine, but I'll monitor the CI to see
> how it goes.
>
> Now, the only installation test failure I'm aware of is
> https://issues.guix.gnu.org/41948. The good news, is that I have a Guile
> patch that seem to solve it[1].
Yes, it’s still on my radar (started looking into it the other day,
without any tangible result).
Ludo’.
next prev parent reply other threads:[~2020-09-02 20:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 12:23 [bug#42849] [PATCH 0/3] installer: Run the installation inside a container Mathieu Othacehe
2020-08-13 12:34 ` [bug#42849] [PATCH 1/3] install: Factorize cow-store procedure Mathieu Othacehe
2020-08-13 12:34 ` [bug#42849] [PATCH 2/3] linux-container: Add a jail? argument Mathieu Othacehe
2020-08-30 19:53 ` Ludovic Courtès
2020-08-31 6:27 ` Mathieu Othacehe
2020-08-31 13:36 ` Ludovic Courtès
2020-09-07 22:02 ` Ludovic Courtès
2020-09-10 7:46 ` Mathieu Othacehe
2020-09-11 15:07 ` Ludovic Courtès
2020-08-13 12:34 ` [bug#42849] [PATCH 3/3] installer: Run the installation inside a container Mathieu Othacehe
2020-08-30 20:40 ` Ludovic Courtès
2020-08-31 6:44 ` Mathieu Othacehe
2020-09-01 8:48 ` Ludovic Courtès
2020-09-02 15:15 ` bug#42849: " Mathieu Othacehe
2020-09-02 20:17 ` Ludovic Courtès [this message]
2020-09-02 21:25 ` [bug#42849] " Ludovic Courtès
2020-08-30 19:51 ` [bug#42849] [PATCH 1/3] install: Factorize cow-store procedure Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736403pco.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=42849-done@debbugs.gnu.org \
--cc=othacehe@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).