unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Pierre Langlois <pierre.langlois@gmx.com>
To: Michael Rohleder <mike@rohleder.de>
Cc: 43204@debbugs.gnu.org
Subject: [bug#43204] [PATCH] gnu: taglib: Propagate zlib.
Date: Fri, 04 Sep 2020 17:12:50 +0100	[thread overview]
Message-ID: <87363xmsfx.fsf@gmx.com> (raw)
In-Reply-To: <20200904153824.27164-1-mike@rohleder.de>

Hi Michael,

Michael Rohleder writes:

> * gnu/packages/mp3.scm (taglib)[inputs]: Move zlib to [propagated-inputs].
> ---
> It seems, consumer of taglib (commit 89e1e44813) needs to be linked w/ libz
> according to the installed pkg-config.
>
> I noticed that emacs-emms-print-metadata fails to link with a missing -lz lib,
> (I guess, all revdeps of taglib that don't have zlib as an input have that problem)

Oh, indeed emacs-emms doesn't build, sorry for the breakage! :-/ I see
the pkg-config file was changed here https://github.com/taglib/taglib/commit/ef1312d62239f399c40233d76ef3328b8dadf984

Propagating zlib seems like the right thing to do (although I'm not a
maintainer), thanks for the patch!

Pierre




  reply	other threads:[~2020-09-04 16:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-04 15:38 [bug#43204] [PATCH] gnu: taglib: Propagate zlib Michael Rohleder
2020-09-04 16:12 ` Pierre Langlois [this message]
2020-09-05 11:23   ` Pierre Langlois
2020-09-07 12:15     ` Ludovic Courtès
2020-09-07 13:26       ` Michael Rohleder
2020-09-07 13:41       ` Pierre Langlois
2020-09-07 22:55         ` bug#43204: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87363xmsfx.fsf@gmx.com \
    --to=pierre.langlois@gmx.com \
    --cc=43204@debbugs.gnu.org \
    --cc=mike@rohleder.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).