From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wEgAC/+5YF8TfgAA0tVLHw (envelope-from ) for ; Tue, 15 Sep 2020 12:56:31 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id CDtOBf+5YF9cFgAA1q6Kng (envelope-from ) for ; Tue, 15 Sep 2020 12:56:31 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9F3819404C8 for ; Tue, 15 Sep 2020 12:56:30 +0000 (UTC) Received: from localhost ([::1]:53120 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIAVY-0002ks-JG for larch@yhetil.org; Tue, 15 Sep 2020 08:56:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51978) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIA7u-0005MK-Gw for guix-patches@gnu.org; Tue, 15 Sep 2020 08:32:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46081) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kIA7u-0002B2-2B for guix-patches@gnu.org; Tue, 15 Sep 2020 08:32:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kIA7t-000297-V7 for guix-patches@gnu.org; Tue, 15 Sep 2020 08:32:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43360] [PATCH 1/2] gnu: Add libgda. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 15 Sep 2020 12:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43360 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Prikler Cc: 43360@debbugs.gnu.org Received: via spool by 43360-submit@debbugs.gnu.org id=B43360.16001730738191 (code B ref 43360); Tue, 15 Sep 2020 12:32:01 +0000 Received: (at 43360) by debbugs.gnu.org; 15 Sep 2020 12:31:13 +0000 Received: from localhost ([127.0.0.1]:57627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIA77-000282-7G for submit@debbugs.gnu.org; Tue, 15 Sep 2020 08:31:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIA71-00027i-BO for 43360@debbugs.gnu.org; Tue, 15 Sep 2020 08:31:11 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43418) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIA6t-000275-7x; Tue, 15 Sep 2020 08:31:00 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=35928 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kIA6s-0001ny-93; Tue, 15 Sep 2020 08:30:58 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <6c0cdef1869e35d7e6aaf0a09256531ddb90a357.camel@student.tugraz.at> <20200912183533.5793-1-leo.prikler@student.tugraz.at> Date: Tue, 15 Sep 2020 14:30:47 +0200 In-Reply-To: <20200912183533.5793-1-leo.prikler@student.tugraz.at> (Leo Prikler's message of "Sat, 12 Sep 2020 20:35:33 +0200") Message-ID: <87363ji5mw.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: FnupfFSlDKnM Hi! Leo Prikler skribis: > * gnu/packages/gnome.scm (libgda): New variable. [...] > + (add-after 'unpack 'remove-broken-tests > + (lambda _ > + (substitute* "tests/multi-threading/Makefile.am" > + ((,(string-join > + '("mutex" "parser" "cnc_lock" "threaded_cnc" "wrapper= ") > + " check_" > + 'prefix)) Please use a literal string for the regexp. It=E2=80=99d also be nice to add a short comment explaining what=E2=80=99s = wrong with those tests. The rest LGTM, thanks! Ludo=E2=80=99.