From: "Ludovic Courtès" <ludo@gnu.org>
To: Leo Prikler <leo.prikler@student.tugraz.at>
Cc: 43360@debbugs.gnu.org
Subject: [bug#43360] [PATCH 1/2] gnu: Add libgda.
Date: Tue, 15 Sep 2020 14:30:47 +0200 [thread overview]
Message-ID: <87363ji5mw.fsf@gnu.org> (raw)
In-Reply-To: <20200912183533.5793-1-leo.prikler@student.tugraz.at> (Leo Prikler's message of "Sat, 12 Sep 2020 20:35:33 +0200")
Hi!
Leo Prikler <leo.prikler@student.tugraz.at> skribis:
> * gnu/packages/gnome.scm (libgda): New variable.
[...]
> + (add-after 'unpack 'remove-broken-tests
> + (lambda _
> + (substitute* "tests/multi-threading/Makefile.am"
> + ((,(string-join
> + '("mutex" "parser" "cnc_lock" "threaded_cnc" "wrapper")
> + " check_"
> + 'prefix))
Please use a literal string for the regexp.
It’d also be nice to add a short comment explaining what’s wrong with
those tests.
The rest LGTM, thanks!
Ludo’.
next prev parent reply other threads:[~2020-09-15 12:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-12 18:33 [bug#43360] [PATCH 0/2] Add gtranslator Leo Prikler
2020-09-12 18:35 ` [bug#43360] [PATCH 1/2] gnu: Add libgda Leo Prikler
2020-09-12 18:35 ` [bug#43360] [PATCH 2/2] gnu: Add gtranslator Leo Prikler
2020-09-15 12:30 ` Ludovic Courtès [this message]
2020-09-15 14:08 ` [bug#43360] [PATCH 1/2] gnu: Add libgda Leo Prikler
2020-09-15 18:53 ` bug#43360: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87363ji5mw.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=43360@debbugs.gnu.org \
--cc=leo.prikler@student.tugraz.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).