From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id GDKEJwodZV+AKQAA0tVLHw (envelope-from ) for ; Fri, 18 Sep 2020 20:48:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id aF5NIwodZV+NcQAAbx9fmQ (envelope-from ) for ; Fri, 18 Sep 2020 20:48:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D68919404C5 for ; Fri, 18 Sep 2020 20:48:09 +0000 (UTC) Received: from localhost ([::1]:52120 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJMxM-0005wc-Lt for larch@yhetil.org; Fri, 18 Sep 2020 16:26:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44282) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJMxG-0005wI-4l for guix-patches@gnu.org; Fri, 18 Sep 2020 16:26:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:32988) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJMxF-0003f6-QS for guix-patches@gnu.org; Fri, 18 Sep 2020 16:26:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kJMxF-0005wt-MA for guix-patches@gnu.org; Fri, 18 Sep 2020 16:26:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43494] [PATCH 3/4] services: guix: Add guix-build-coordinator-agent-service-type. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 18 Sep 2020 20:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43494 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 43494@debbugs.gnu.org Received: via spool by 43494-submit@debbugs.gnu.org id=B43494.160046071822813 (code B ref 43494); Fri, 18 Sep 2020 20:26:01 +0000 Received: (at 43494) by debbugs.gnu.org; 18 Sep 2020 20:25:18 +0000 Received: from localhost ([127.0.0.1]:44534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJMwX-0005vr-UD for submit@debbugs.gnu.org; Fri, 18 Sep 2020 16:25:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJMwW-0005vf-Lq for 43494@debbugs.gnu.org; Fri, 18 Sep 2020 16:25:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56572) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJMwR-0003Qf-9E; Fri, 18 Sep 2020 16:25:11 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=45404 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kJMwM-00081U-HI; Fri, 18 Sep 2020 16:25:07 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200918184042.22660-1-mail@cbaines.net> <20200918184042.22660-3-mail@cbaines.net> Date: Fri, 18 Sep 2020 22:25:05 +0200 In-Reply-To: <20200918184042.22660-3-mail@cbaines.net> (Christopher Baines's message of "Fri, 18 Sep 2020 19:40:41 +0100") Message-ID: <87363evnmm.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: mIjgVOm73iij Christopher Baines skribis: > * gnu/services/guix.scm (): N= ew > record type. > (guix-build-coordinator-agent-configuration, > guix-build-coordinator-agent-configuration?, > guix-build-coordinator-agent-configuration-package, > guix-build-coordinator-agent-configuration-user, > guix-build-coordinator-agent-configuration-coordinator, > guix-build-coordinator-agent-configuration-uuid), > guix-build-coordinator-agent-configuration-password, > guix-build-coordinator-agent-configuration-password-file, > guix-build-coordinator-agent-configuration-systems, > guix-build-coordinator-agent-configuration-max-parallel-builds, > guix-build-coordinator-agent-configuration-derivation-substitute-urls, > guix-build-coordinator-agent-configuration-non-derivation-substitute-urls, > guix-build-coordinator-agent-shepherd-services, > guix-build-coordinator-agent-activation, > guix-build-coordinator-agent-account): New procedures. > (guix-build-coordinator-agent-service-type): New variable. > * doc/guix.texi (Guix Services): Document it. [...] > +@defvar {Scheme Variable} guix-build-coordinator-agent-service-type > +Service type for a Guix Build Coordinator agent. Its value must be a Perhaps =E2=80=9Ccoordinator=E2=80=9D and =E2=80=9Cagent=E2=80=9D should be= defined in a few sentences above to clarify what this is about. > +@item @code{derivation-substitute-urls} (default: @code{1}) > +URLs from which to attempt to fetch substitutes for derivations, if the > +derivations aren't already available. > + > +@item @code{non-derivation-substitute-urls} (default: @code{1}) > +URLs from which to attempt to fetch substitutes for build inputs, if the > +input store items aren't already available. This is interesting, I wonder how you can distinguish between the two in code. You have to open different sessions, right? Or to call =E2=80=98set-build-options=E2=80=99 again? > + (description > + "Run an instance of the Guix Build Coordinator."))) + =E2=80=9Cagent=E2=80=9D Otherwise LGTM! Ludo=E2=80=99.