From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id QG5yEdMci1/WTQAA0tVLHw (envelope-from ) for ; Sat, 17 Oct 2020 16:33:23 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id GSEyDdMci1/MCQAAbx9fmQ (envelope-from ) for ; Sat, 17 Oct 2020 16:33:23 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 32A3F940223 for ; Sat, 17 Oct 2020 16:33:22 +0000 (UTC) Received: from localhost ([::1]:53672 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kTp8z-0005kt-1D for larch@yhetil.org; Sat, 17 Oct 2020 12:33:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58336) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kTp8g-0005iO-RW for guix-patches@gnu.org; Sat, 17 Oct 2020 12:33:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52128) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kTp8g-0003L5-HC for guix-patches@gnu.org; Sat, 17 Oct 2020 12:33:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kTp8g-0000K0-C7 for guix-patches@gnu.org; Sat, 17 Oct 2020 12:33:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#35394] [PATCH 1/1 v4] Grub i18n Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 17 Oct 2020 16:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35394 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas Cc: 35394@debbugs.gnu.org Received: via spool by 35394-submit@debbugs.gnu.org id=B35394.16029523711217 (code B ref 35394); Sat, 17 Oct 2020 16:33:02 +0000 Received: (at 35394) by debbugs.gnu.org; 17 Oct 2020 16:32:51 +0000 Received: from localhost ([127.0.0.1]:35441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTp8U-0000JZ-LB for submit@debbugs.gnu.org; Sat, 17 Oct 2020 12:32:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTp8S-0000JN-R8 for 35394@debbugs.gnu.org; Sat, 17 Oct 2020 12:32:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58095) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kTp8N-0003Ie-Hs; Sat, 17 Oct 2020 12:32:43 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=40174 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kTp8K-0008F8-No; Sat, 17 Oct 2020 12:32:42 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20190423151702.05258473@gmail.com> <87ft6k7sn2.fsf@gmail.com> Date: Sat, 17 Oct 2020 18:32:39 +0200 In-Reply-To: <87ft6k7sn2.fsf@gmail.com> ("Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas"'s message of "Sun, 11 Oct 2020 16:18:41 +0200") Message-ID: <87362c6cew.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: t/icvoXqLWdE Hi Miguel, Miguel =C3=81ngel Arruga Vivas skribis: > This is the latest version of the patch, that could be applied to > master. > > They have been reduced to one patch, and as on previous versions of this > series of patches only the grub messages are translated, not the menu > entries generated by guix (yet). Sounds good. I think the way you split patches in v3 was fine too (the added test was also a nice bonus), so I actually have a slight preference for v3. >>>From 885a7c167faafa295b0f3edaae1ee456eacf1e63 Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Miguel=3D20=3DC3=3D81ngel=3D20Arruga=3D20Vivas?=3D > > Date: Sat, 2 Nov 2019 18:18:45 +0100 > Subject: [PATCH] system: Use locale information in grub.cfg. > > * gnu/bootloader/grub.scm (define-module): Add new dependency. > (grub-configuration-file): Add locale keyword. > (grub-configuration-file)[locale-config]: New variable with generated > locale configuration when locale parameter has been provided. > [builder]: Add locale-config. > * gnu/machine/ssh.scm (roll-back-managed-host): Use locale information > from boot-parameters. > * gnu/system.scm (define-module)[export]: Add boot-parameters-locale. > ()[locale]: New field. > [boot-parameters-locale]: New accessor. > (read-boot-parameters): Read locale field. > (operating-system-boot-parameters): Provide operating-system locale to > oboot-parameters record. > (operating-system-boot-parameters-file): Likewise. > (operating-system-bootcfg): Provide locale information to the bootloader. > * guix/system/script.scm (reinstall-bootloader): Likewise. This (and v3) LGTM! We=E2=80=99ll have to do another round of testing befo= re 1.2. =C2=A1Gracias! Ludo=E2=80=99.