From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id sKJSGR2zkV8ydgAA0tVLHw (envelope-from ) for ; Thu, 22 Oct 2020 16:28:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id COutEx2zkV8FPQAAB5/wlQ (envelope-from ) for ; Thu, 22 Oct 2020 16:28:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D9FC99400EF for ; Thu, 22 Oct 2020 16:28:12 +0000 (UTC) Received: from localhost ([::1]:52428 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kVdRj-0002FK-GI for larch@yhetil.org; Thu, 22 Oct 2020 12:28:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53666) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVdRa-0002Co-T2 for guix-patches@gnu.org; Thu, 22 Oct 2020 12:28:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42146) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kVdRa-00050y-KV for guix-patches@gnu.org; Thu, 22 Oct 2020 12:28:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kVdRa-0000SI-Hf for guix-patches@gnu.org; Thu, 22 Oct 2020 12:28:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#44019] add dbus-cxx Resent-From: Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 22 Oct 2020 16:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44019 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: tiregram arthur Cc: 44019@debbugs.gnu.org Received: via spool by 44019-submit@debbugs.gnu.org id=B44019.16033840551680 (code B ref 44019); Thu, 22 Oct 2020 16:28:02 +0000 Received: (at 44019) by debbugs.gnu.org; 22 Oct 2020 16:27:35 +0000 Received: from localhost ([127.0.0.1]:53682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVdR8-0000R1-Is for submit@debbugs.gnu.org; Thu, 22 Oct 2020 12:27:34 -0400 Received: from mail-wm1-f45.google.com ([209.85.128.45]:50343) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVdR6-0000Qn-TK for 44019@debbugs.gnu.org; Thu, 22 Oct 2020 12:27:33 -0400 Received: by mail-wm1-f45.google.com with SMTP id 13so2800931wmf.0 for <44019@debbugs.gnu.org>; Thu, 22 Oct 2020 09:27:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=Ug1284+TYdDHQq6nlT56/stOk5mlVwSG6Ne+YUbxRY8=; b=ljUrcQvCaUt8y3/us2rci8c1jDW9XLMcSwKpCoryMoGLAIx2bv23l7L/Kb91jdsoYQ 4zbNhrr5TKrKFGa33GedEA7cY36Hc12c9KtQ57hzOEaGtL6okidctCYMx5TBFontyGjZ oQEt5NqOJNABWp/FnVAKy20WaVWdjodOtJh+3J7YUyVnUQLJacNeVDcI9acYlnrJpvqP SejLxnFnAilCdYfsRY8WaWUUf0oeLT4TdXE1mSaUxX403r+WmwO6oUgg7vG2usdd4o06 1z37Bsi1t9OmWR8jYhUeajOTIkCrA5XCeXPKbGijMdMB2dhC1KmAeAncoRfVBaK4wSre BlVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=Ug1284+TYdDHQq6nlT56/stOk5mlVwSG6Ne+YUbxRY8=; b=XEpMEUMchdFNHhN4wpKjUZVAvwYsN6qoSTyJI2xvizfkchWkdADJ+2WylX9x2jNC37 wSd6r+LgVsO699jiY/ONiGCl+pVtnKIKkmRsisRRS3/cNJ8C0khGGyDpDWPh8ZJ07J8t x76djyaXJDPLXyXgSdslGZ+qdPXL828XCADvHpGUbT/62xZWunbeaVPT5z1Aq0S/uFqO vOwgAdA8GLmNlgFqhgNhp8+grErWQiEqxier/1HmRb5R8stj+VbYw5zXmEpJkd46gzqP HSb7McpYy/uZoqKkkuuIJs0JHxCjeqzSJaJkMSf2at6618OL5FUgl6h+JiHtvg0CV/cH fudQ== X-Gm-Message-State: AOAM532rmnmKsD/0SgO+wJfc/dKYmBaUxxFBls/eBoNp6/2MtlIdre5v AdfDfMWXoGi/KmVlIHoLdBGMrIvVPOQrYQ== X-Google-Smtp-Source: ABdhPJwu78atCoemg1u7WiFhYH9ko81RahUx+OHfOkus9jrF4xprsvAFuvfm/5JE1KfEq0s4RBttgQ== X-Received: by 2002:a1c:7c12:: with SMTP id x18mr3411726wmc.107.1603384046720; Thu, 22 Oct 2020 09:27:26 -0700 (PDT) Received: from unfall (218.139.134.37.dynamic.jazztel.es. [37.134.139.218]) by smtp.gmail.com with ESMTPSA id m12sm4195449wmi.33.2020.10.22.09.27.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Oct 2020 09:27:25 -0700 (PDT) From: Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas References: <87h7qqnv5u.fsf@gmail.com> <87sgaam8mx.fsf@gmail.com> Date: Thu, 22 Oct 2020 18:26:27 +0200 In-Reply-To: (tiregram arthur's message of "Tue, 20 Oct 2020 16:56:31 +0000") Message-ID: <873626jkgc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 2.2 (++) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: 1.2 (+) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=ljUrcQvC; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: pUyqmUkGZDhO Hi, The list was lost at some point in this email, I add it again. I've checked the code of the library and I'm almost sure it's a fork of the (unmantained) dbus-c++ project, but I'm not sure about changing the dependency for jami and its compatibility, so I think it's worth keeping it as a separate package, at least for now. Reading and testing your patch I've found several issues about it, all of them have an easy solution. :-) tiregram arthur writes: > From 8664346cc76e728806c1a797fc59b47d66b603ef Mon Sep 17 00:00:00 2001 > From: ruhtra > Date: Tue, 20 Oct 2020 18:52:37 +0200 > Subject: [PATCH] add dbus-cxx package The commit message title should be with "gnu: Add dbus-cxx." Also, changelog information is required in the body of the commit, e.g.: * gnu/packages/glib.scm (dbux-cxx): New package. > --- > gnu/packages/glib.scm | 32 ++++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/gnu/packages/glib.scm b/gnu/packages/glib.scm > index cde95b13eb..c79060cf8b 100644 > --- a/gnu/packages/glib.scm > +++ b/gnu/packages/glib.scm > @@ -13,6 +13,7 @@ > ;;; Copyright =C2=A9 2019 Giacomo Leidi > ;;; Copyright =C2=A9 2019, 2020 Marius Bakke > ;;; Copyright =C2=A9 2020 Nicol=C3=B2 Balzarotti > +;;; Copyright =C2=A9 2020 Arthur Margerit > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -61,10 +62,12 @@ > #:use-module (gnu packages xml) > #:use-module (gnu packages xorg) > #:use-module (guix build-system gnu) > + #:use-module (guix build-system cmake) > #:use-module (guix build-system meson) > #:use-module (guix build-system perl) > #:use-module (guix build-system python) > #:use-module (guix download) > + #:use-module (guix git-download) This shouldn't be needed, there is a tarball for the release on the sourceforge page. > #:use-module ((guix licenses) #:prefix license:) > #:use-module (guix packages) > #:use-module (guix utils) > @@ -932,6 +935,35 @@ programming language. It also contains the utility > (home-page "https://sourceforge.net/projects/dbus-cplusplus/") > (license license:lgpl2.1+))) >=20=20 > + That extra line break should be removed. > +(define-public dbus-cxx > + (package > + (name "dbus-cxx") > + (version "0.12.0") > + (source (origin > + (file-name (git-file-name name version)) > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/dbus-cxx/dbus-cxx") > + (commit "ea7f8e361d11dc7d41d9ae2c4128aed2cdadd84e"))) Here it should point to the tarball from sourceforge (like the one for dbus-c++): "mirror://sourceforge/dbus-cxx/dbus-cxx/0.12.0/dbus-cxx-0.12.0.tar.gz" > + (sha256 > + (base32 > + "1sa448icfvl08rnik0lnk4scmkwhfyd3mrxh36jh8x7xndp90khp"))= )) The sha256 for the tarball would be "1acsgpkd9v7b9jdc79ijmh9dbdfrzgkwkaff518i3zpk7y6g5mzw". > + (build-system cmake-build-system) > + (arguments > + `(#:tests? #f)) We should run tests as much as possible as the software is going to be distributed. For that, -DENABLE_TESTS=3DON must be provided through #:build-arguments, and #:tests? #f removed. Also, the description doesn't match the options default options, -DENABLE_TOOLS=3DON has to be provided to generate dbus-cxx-xml2cpp and dbus-cxx-introspection. There is a third option that could be interesting, -DENABLE_GLIBMM=3DON, but I'm not sure what it really does, apart from generating extra headers and libs. > + (inputs `(("dbus-glib", dbus) ("libsigc++", libsigc++))) The comma (,) there is reader syntax, so it applies to the right side, not the left one: ,libsigc++ expands to the contents of the variable libsigc++ inside the quasiquote (`). Also, they should be one on each line, and I would change dbus-glib for dbus too. To build the tools you need expat, already available, and popt from (gnu packages popt), like this code: (inputs `(("dbus" ,dbus) ("expat" ,expat) ("libsigc++" ,libsigc++) ("popt" ,popt))) If the glibmm option worths it, it has to be added to that list too. > + (native-inputs `(("pkg-config", pkg-config) ("m4", m4))) Same indentation problems, one line per dependency, comma with the variable, not on the left. > + (synopsis "C++ wrapper for dbus") > + (description "Dbus-cxx is a C++ wrapper for dbus. > +It exposes the C API to allow direct manipulation and > +relies on sigc++ to provide an OO interface. > +Also included is dbus-cxx-xml2cpp to generate proxy and adapter > + interfaces from DBus XML introspection-like documents.") This has been directly copied from the web page. If you don't have any idea on what to write, the dbus-c++ package description has better formatting at least. :-) > + (home-page "https://dbus-cxx.github.io/") > + (license license:gpl3))) > + > + There's an extra line here too. The main two issues are the compilation options and the description. Would you mind to send a new version of the patch with these fixes? Happy hacking! Miguel