[bug#44222] emacs-lojban and emacs-lojban-mode packages

[Nicolas Goaziou <mail@nicolasgoaziou.fr>]

Hello,

Christopher Lemmer Webber <cwebber@dustycloud.org> writes:

> Well, here are some WIP patches... two of them.  Sadly they don't work
> as-is, I'm hitting an error:
>
> starting phase `build'
> Checking /gnu/store/2hgmjkw6m1id4gr9zcg7qgig9wj758mv-emacs-lojban-0.23/share/emacs/site-lisp/...
> Compiling /gnu/store/2hgmjkw6m1id4gr9zcg7qgig9wj758mv-emacs-lojban-0.23/share/emacs/site-lisp/lojban-autoloads.el...
> Compiling /gnu/store/2hgmjkw6m1id4gr9zcg7qgig9wj758mv-emacs-lojban-0.23/share/emacs/site-lisp/lojban.el...
> Symbol’s value as variable is void: lojban-c-rgx
> command
> "/gnu/store/k826y34z8zzjj57jv2nldmpw6vsdd145-emacs-minimal-27.1/bin/emacs"
> "--quick" "--batch" "--eval=(eval '(progn (setq byte-compile-debug t)
> (byte-recompile-directory (file-name-as-directory
> \"/gnu/store/2hgmjkw6m1id4gr9zcg7qgig9wj758mv-emacs-lojban-0.23/share/emacs/site-lisp\")
> 0 1)) t)" failed with status 255
> builder for `/gnu/store/lsjlw04kn85k7f38s7ni1g0ax8lbqzi4-emacs-lojban-0.23.drv' failed with exit code 1
> build of /gnu/store/lsjlw04kn85k7f38s7ni1g0ax8lbqzi4-emacs-lojban-0.23.drv failed
>
> But if I look at the downloaded lojban.el file, I see it there:
>
> $ grep lojban-c-rgx /gnu/store/2hgmjkw6m1id4gr9zcg7qgig9wj758mv-emacs-lojban-0.23/share/emacs/site-lisp/lojban.el 
> (defconst lojban-c-rgx (concat "[" lojban-c-letter-set "]")
> ...
>
> Any ideas what might be causing it?

This:

      (eval-when-compile
	(concat "\\(" lojban-c-rgx "\\)\\1"))

is the culprit. This is evaluated before compiling the file, when the
defconst is not defined yet. 

Considering `lojban-c-rgx' is a constant, I'm not sure why
`eval-when-compile' would be better than defining the result as a new
constant.

In any case, a poor man's fix could be replacing `eval-when-compile'
with `progn', or

    (concat "\\(" lojban-c-rgx "\\)\\1")

with

    "\\([bcdfgj-npr-tvxz]\\)\\1"

Also,

+    (synopsis "Emacs utilities for operating on lojban text")
+    (description
+     "lojban.el is an emacs library of functions, variables, regexps and
+interactive commands for handling lojban text.")

I would capitalize Emacs, and Lojban.

Regards,
-- 
Nicolas Goaziou