From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id cFLPCVHArl+LZAAA0tVLHw (envelope-from ) for ; Fri, 13 Nov 2020 17:20:17 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id OIp+BVHArl/9NQAAB5/wlQ (envelope-from ) for ; Fri, 13 Nov 2020 17:20:17 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B82F494011C for ; Fri, 13 Nov 2020 17:20:16 +0000 (UTC) Received: from localhost ([::1]:39974 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdckB-0008W4-OF for larch@yhetil.org; Fri, 13 Nov 2020 12:20:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60530) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdck0-0008VB-Ub for guix-patches@gnu.org; Fri, 13 Nov 2020 12:20:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37736) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kdcjy-0004R1-1y for guix-patches@gnu.org; Fri, 13 Nov 2020 12:20:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kdcjx-00073t-U0 for guix-patches@gnu.org; Fri, 13 Nov 2020 12:20:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44567] [PATCH] publish: Improve HTTP performance when not using --cache. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 13 Nov 2020 17:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44567 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 44567@debbugs.gnu.org Received: via spool by 44567-submit@debbugs.gnu.org id=B44567.160528795427061 (code B ref 44567); Fri, 13 Nov 2020 17:20:01 +0000 Received: (at 44567) by debbugs.gnu.org; 13 Nov 2020 17:19:14 +0000 Received: from localhost ([127.0.0.1]:49279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdcjC-00072P-7F for submit@debbugs.gnu.org; Fri, 13 Nov 2020 12:19:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60284) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdcjA-00072C-9g for 44567@debbugs.gnu.org; Fri, 13 Nov 2020 12:19:12 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35834) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdcj4-0004C8-Bd; Fri, 13 Nov 2020 12:19:07 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=37742 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kdcj3-0000i7-B8; Fri, 13 Nov 2020 12:19:05 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20201111035727.11184-1-maxim.cournoyer@gmail.com> Date: Fri, 13 Nov 2020 18:19:03 +0100 In-Reply-To: <20201111035727.11184-1-maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Tue, 10 Nov 2020 22:57:27 -0500") Message-ID: <87361dcgzc.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: +jJAyjSBu2mm Hi Maxim, Maxim Cournoyer skribis: > This change harmonizes the way we configure the buffer sizes and the sock= et > options, so that we don't forget to change it at one place like it happen= ed in > commit 5e3d169945935b53325e6b738a307ba286751259. Using a greater socket > buffer size reportedly improves throughput tenfold. > > The solution was found by Ludovic Court=C3=A8s. > > * guix/scripts/publish.scm (%default-buffer-size) > (%default-socket-options): New variables. > * guix/scripts/publish.scm (configure-socket): New procedure. > (compress-nar): Use %default-buffer-size for the buffer size, increased f= rom > 128 to 208 KiB. > (nar-response-port): Likewise, increased from 64 to 208 KiB. > (http-write): Use configure-socket to set socket options. > (open-server-socket): Likewise. Apologies for not noticing this before pushing 1cbda46d4aae5ba9bd89a1837f0d81a29653ed7b. What you propose here is nicer. > +(define %default-buffer-size > + (* 208 1024)) Why 208? Did you notice a difference compared to 128KiB? (I=E2=80=99m fine either way, just wondering.) Perhaps add a comment as to what buffer we=E2=80=99re talking about. > +(define %default-socket-options Maybe add: ;; List of options passed to 'setsockopt' when transmitting file= s. > + (list (list SO_SNDBUF %default-buffer-size))) > (make-gzip-output-port (response-port response) > #:level level > - #:buffer-size (* 64 1024))) > + #:buffer-size %default-buffer-size)) Does the gzip buffer size have to match the TCP buffer size? I=E2=80=99d s= ay not necessarily, so perhaps we should have a separate variable for the gzip buffer size (or keep it as is). That=E2=80=99s it, thank you! Ludo=E2=80=99.