From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id pgcYIGJqA2ALKAAA0tVLHw (envelope-from ) for ; Sat, 16 Jan 2021 22:36:18 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id KJRaG2JqA2D1BAAAbx9fmQ (envelope-from ) for ; Sat, 16 Jan 2021 22:36:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F09F2940309 for ; Sat, 16 Jan 2021 22:36:17 +0000 (UTC) Received: from localhost ([::1]:55524 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0uB6-0002DM-Sm for larch@yhetil.org; Sat, 16 Jan 2021 17:36:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57932) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0u9u-0001Jc-1c for guix-patches@gnu.org; Sat, 16 Jan 2021 17:35:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60926) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l0u9t-0006WP-PJ for guix-patches@gnu.org; Sat, 16 Jan 2021 17:35:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l0u9t-00023F-Mp for guix-patches@gnu.org; Sat, 16 Jan 2021 17:35:01 -0500 Subject: bug#45794: [PATCH 0/1] services: openntpd: Remove support for deprecated "-s" option. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Sat, 16 Jan 2021 22:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 45794 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Simon South Mail-Followup-To: 45794@debbugs.gnu.org, ludo@gnu.org, simon@simonsouth.net Received: via spool by 45794-done@debbugs.gnu.org id=D45794.16108364767849 (code D ref 45794); Sat, 16 Jan 2021 22:35:01 +0000 Received: (at 45794-done) by debbugs.gnu.org; 16 Jan 2021 22:34:36 +0000 Received: from localhost ([127.0.0.1]:44238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0u9T-00022X-Ql for submit@debbugs.gnu.org; Sat, 16 Jan 2021 17:34:36 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0u9O-00022F-SN for 45794-done@debbugs.gnu.org; Sat, 16 Jan 2021 17:34:34 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59031) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0u9J-0006CZ-IY; Sat, 16 Jan 2021 17:34:25 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=38328 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l0u9J-0003iD-3N; Sat, 16 Jan 2021 17:34:25 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Sat, 16 Jan 2021 23:34:22 +0100 In-Reply-To: (Simon South's message of "Mon, 11 Jan 2021 12:02:34 -0500") Message-ID: <8735z0wlxt.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45794-done@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.86 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: F09F2940309 X-Spam-Score: -2.86 X-Migadu-Scanner: scn1.migadu.com X-TUID: 3xL9BiWi+Fh9 Hi, Simon South skribis: > This patch removes support for OpenNTPD's deprecated "-s" command-line op= tion > and the corresponding "allow-large-adjustment?" field from Guix's > openntpd-configuration record type. > > Previously this option allowed OpenNTPD to make a single, arbitrarily lar= ge > adjustment to the clock at startup. In the current release this option has > been disabled[0] in favour of the use of authenticated constraints, and > configuring a service with "(allow-large-adjustment? #t)" now causes this > message to appear in /var/log/ntpd: > > -s option no longer works and will be removed soon. > Please reconfigure to use constraints or trusted servers. > > For systems like the ROCK64 that lack a battery-backed clock, generally t= he > solution is to replace the "allow-large-adjustment?" option with a setting > like > > (constraint-from '("www.gnu.org")) > > which will give OpenNTPD an independent estimate of the current time and = allow > it to evaluate the trustworthiness of the configured NTP servers. > > [0] https://cvsweb.openbsd.org/src/usr.sbin/ntpd/ntpd.c?rev=3D1.127&conte= nt-type=3Dtext/x-cvsweb-markup Thanks for explaining. > * gnu/services/networking.scm (openntpd-configuration): Remove > "allow-large-adjustment?" field. > (openntpd-shepherd-service): Remove use of "allow-large-adjustment?" > configuration field and "-s" daemon option. > * tests/networking.scm (%openntpd-conf-sample): Remove > "allow-large-adjustment?" field. > * doc/guix.texi (Networking Services)[openntpd-service-type]: Remove > "allow-large-adjustment?" field from sample configuration. > [openntpd-configuration]: Remove description of "allow-large-adjustment?" > field. Applied, thanks! Ludo=E2=80=99.