From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id eF/ELGu5EmD/aQAA0tVLHw (envelope-from ) for ; Thu, 28 Jan 2021 13:17:31 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id aOiVKGu5EmBvIgAAbx9fmQ (envelope-from ) for ; Thu, 28 Jan 2021 13:17:31 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3FB3994043A for ; Thu, 28 Jan 2021 13:17:31 +0000 (UTC) Received: from localhost ([::1]:36358 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l57Aw-0004zQ-7k for larch@yhetil.org; Thu, 28 Jan 2021 08:17:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51100) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l57AV-0004st-Im for guix-patches@gnu.org; Thu, 28 Jan 2021 08:17:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:35995) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l57AU-0004Fl-Ha for guix-patches@gnu.org; Thu, 28 Jan 2021 08:17:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l57AU-0006Xu-D3 for guix-patches@gnu.org; Thu, 28 Jan 2021 08:17:02 -0500 Subject: bug#46100: [PATCH 0/4] Memoize inferior package access. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Thu, 28 Jan 2021 13:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 46100 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ricardo Wurmus Mail-Followup-To: 46100@debbugs.gnu.org, ludo@gnu.org, rekado@elephly.net Received: via spool by 46100-done@debbugs.gnu.org id=D46100.161183981725144 (code D ref 46100); Thu, 28 Jan 2021 13:17:02 +0000 Received: (at 46100-done) by debbugs.gnu.org; 28 Jan 2021 13:16:57 +0000 Received: from localhost ([127.0.0.1]:47540 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l57AO-0006XU-Nl for submit@debbugs.gnu.org; Thu, 28 Jan 2021 08:16:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33134) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l57AM-0006XE-IK for 46100-done@debbugs.gnu.org; Thu, 28 Jan 2021 08:16:55 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41754) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l57AH-00049H-Ac; Thu, 28 Jan 2021 08:16:49 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=58078 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l57AG-0004ms-LJ; Thu, 28 Jan 2021 08:16:49 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210125133738.15609-1-rekado@elephly.net> <20210125133738.15609-2-rekado@elephly.net> <878s8g0yln.fsf_-_@gnu.org> <874kj40wbp.fsf_-_@gnu.org> <87y2gfj2ks.fsf@elephly.net> <87sg6mrmtr.fsf@gnu.org> <87tur1i8gn.fsf@elephly.net> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 9 =?UTF-8?Q?Pluvi=C3=B4se?= an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 28 Jan 2021 14:16:47 +0100 In-Reply-To: <87tur1i8gn.fsf@elephly.net> (Ricardo Wurmus's message of "Thu, 28 Jan 2021 12:53:12 +0100") Message-ID: <8735ylqk00.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 46100-done@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.85 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 3FB3994043A X-Spam-Score: -2.85 X-Migadu-Scanner: scn0.migadu.com X-TUID: D8KOY6lX8bxd Ricardo Wurmus skribis: > Ludovic Court=C3=A8s writes: > >> I pushed it as 0f20b3fa2050ba6e442e340a204516b9375cd231. > > Thanks! > >> I wonder if the other patches improve the situation. If you run the >> same test case with: >> >> GUIX_PROFILING=3Dmemoization >> >> what hit rates does it show for these spots? > > Memoization: 15 tables, 2 non-empty > guix/inferior.scm:438:2: 403 entries, 403 lookups, 0% hits > guix/inferior.scm:392:2: 403 entries, 403 lookups, 0% hits > > So, I guess we can drop those two patches. Looks like it. :-) Closing! Thanks, Ludo=E2=80=99.