From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: 46145@debbugs.gnu.org
Cc: eu@euandre.org
Subject: [bug#46145] [PATCH v2] gnu: jekyll: Update to 4.2.0
Date: Fri, 05 Feb 2021 21:50:19 +0100 [thread overview]
Message-ID: <8735yaxmr8.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20210127225526.302-1-eu@euandre.org> (guix-patches@gnu.org's message of "Wed, 27 Jan 2021 19:55:26 -0300")
Hello,
guix-patches--- via <guix-patches@gnu.org> writes:
> * gnu/packages/ruby.scm (ruby-sassc): Update to 2.4.0.
> * gnu/packages/ruby.scm (ruby-jekyll-sass-converter): Update to 2.1.0.
> * gnu/packages/ruby.scm (ruby-mercenary): Update to 0.4.0.
> * gnu/packages/ruby.scm (ruby-terminal-table): New variable.
> * gnu/packages/ruby.scm (ruby-rouge-2): Remove variable.
> * gnu/packages/ruby.scm (jekyll): Update to 4.2.0.
> [propagated-inputs]: Use newer version or ruby-rouge, add ruby-sassc
> and ruby-terminal-table.
> ---
> I forgot to add the copyright line. This new patch only differs in this
> aspect, all the rest is the same.
Thank you.
Could you split it into independent patches that I can apply sequentially?
> +(define-public ruby-terminal-table
> + (package
> + (name "ruby-terminal-table")
> + (version "2.0.0")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (rubygems-uri "terminal-table" version))
> + (sha256
> + (base32
> + "18rbrh464ysqbdv53iwj0r8frshn65566kyj044cp3x9c2754jwh"))))
> + (arguments
> + '(#:phases
> + (modify-phases %standard-phases
> + (add-before 'check 'remove-gemfile-lock
> + (lambda _
> + (delete-file "Gemfile.lock")))
> + (add-before 'check 'remove-unnecessary-dependencies
> + (lambda _
> + (substitute* "terminal-table.gemspec"
> + (("s.add_runtime_dependency.*") "\n")
> + (("s.add_development_dependency.*") "\n"))
> + (substitute* "Gemfile"
> + ((".*tins.*") "\n"))))
> + (replace 'check
> + (lambda* (#:key tests? #:allow-other-keys)
> + (when tests?
> + (invoke "rspec")))))))
> + (build-system ruby-build-system)
> + (propagated-inputs
> + `(("ruby-unicode-display-width" ,ruby-unicode-display-width)))
> + (native-inputs
> + `(("ruby-rspec" ,ruby-rspec)))
> + (synopsis
> + "Simple, feature rich ASCII table generation library")
Nitpick: This string could be moved on the same line as `synopsis'.
> + (description
> + "Terminal Table is a fast and simple, yet feature rich
> +table generator written in Ruby. It supports ASCII and
> +Unicode formatted tables.")
You need to add two spaces after a full stop.
> + (home-page
> + "https://github.com/tj/terminal-table")
Nitpick: This could be moved above synopsis.
Otherwise, LGTM!
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2021-02-05 20:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <46144@debbugs.gnu.org>
2021-01-27 22:55 ` [bug#46145] [PATCH v2] gnu: jekyll: Update to 4.2.0 guix-patches--- via
[not found] ` <handler.46145.B.161178817330884.ack@debbugs.gnu.org>
2021-01-27 23:04 ` [bug#46145] Acknowledgement ([PATCH v2] gnu: jekyll: Update to 4.2.0) guix-patches--- via
2021-01-27 23:36 ` guix-patches--- via
2021-01-27 23:38 ` guix-patches--- via
2021-02-05 20:50 ` Nicolas Goaziou [this message]
2021-02-05 22:36 ` [bug#46145] [PATCH v2] gnu: jekyll: Update to 4.2.0 EuAndreh via Guix-patches via
2021-02-06 8:13 ` Nicolas Goaziou
2021-02-08 17:26 ` [bug#46145] [PATCH 1/5] gnu: ruby-sassc: Update to 2.4.0 EuAndreh via Guix-patches via
2021-02-08 17:26 ` [bug#46145] [PATCH 2/5] gnu: ruby-jekyll-sass-converter: Update to 2.1.0 EuAndreh via Guix-patches via
2021-02-08 17:26 ` [bug#46145] [PATCH 3/5] gnu: ruby-mercenary: Update to 0.4.0 EuAndreh via Guix-patches via
2021-02-08 17:26 ` [bug#46145] [PATCH 4/5] gnu: Add ruby-terminal-table EuAndreh via Guix-patches via
2021-02-08 17:26 ` [bug#46145] [PATCH 5/5] gnu: jekyll: Update to 4.2.0 EuAndreh via Guix-patches via
2021-02-08 17:29 ` EuAndreh via Guix-patches via
2021-02-08 17:37 ` EuAndreh via Guix-patches via
2021-02-08 19:26 ` Nicolas Goaziou
2021-02-08 22:13 ` EuAndreh via Guix-patches via
2021-02-09 10:13 ` bug#46145: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735yaxmr8.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=46145@debbugs.gnu.org \
--cc=eu@euandre.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).