From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id +BCvKf8uUWD4JgAA0tVLHw (envelope-from ) for ; Tue, 16 Mar 2021 22:19:43 +0000 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id WNt5Jf8uUWChIgAA1q6Kng (envelope-from ) for ; Tue, 16 Mar 2021 22:19:43 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 61FB41496A for ; Tue, 16 Mar 2021 23:19:43 +0100 (CET) Received: from localhost ([::1]:48948 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMI2P-0004YC-V4 for larch@yhetil.org; Tue, 16 Mar 2021 18:19:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44002) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMI1m-0003Y8-JY for guix-patches@gnu.org; Tue, 16 Mar 2021 18:19:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58089) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lMI1m-00082k-Bx for guix-patches@gnu.org; Tue, 16 Mar 2021 18:19:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lMI1m-0005RE-7d for guix-patches@gnu.org; Tue, 16 Mar 2021 18:19:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47013] [PATCH] gnu: Harden filesystem links. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 16 Mar 2021 22:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47013 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: 47013@debbugs.gnu.org Received: via spool by 47013-submit@debbugs.gnu.org id=B47013.161593311220865 (code B ref 47013); Tue, 16 Mar 2021 22:19:02 +0000 Received: (at 47013) by debbugs.gnu.org; 16 Mar 2021 22:18:32 +0000 Received: from localhost ([127.0.0.1]:41402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMI1I-0005QT-7L for submit@debbugs.gnu.org; Tue, 16 Mar 2021 18:18:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMI1D-0005QD-Db for 47013@debbugs.gnu.org; Tue, 16 Mar 2021 18:18:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49507) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMI18-0007m2-3l; Tue, 16 Mar 2021 18:18:22 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=44510 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lMI16-0002d0-OT; Tue, 16 Mar 2021 18:18:21 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Tue, 16 Mar 2021 23:18:18 +0100 In-Reply-To: (Leo Famulari's message of "Fri, 12 Mar 2021 17:51:21 -0500") Message-ID: <8735wu7nf9.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1615933183; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=qUst6QoO2NQ4cnUwZl5Hfd8OlX+0zEVmqtQLnUfIukI=; b=B8LVnNM+TPOGFKwcZGKVB9JIrsA+aeMoSnoFq0WS2DVAb04VrHWZd23AamcdJ85Qmfy5ns dyKd2s71FkTqKZnhs4MnYIHv7QKYBlVw26hVXLht3Yxnw5IAZ//T+uWRsnHNXmcb4cfpQV OsaxLw5HFr8BojGW7iE5xYnig2+5lg/Bwgk0MVWES/OwSkfjXqENMXoIrc98eA7ENtVPVE 8MMv8hiQ5/g7bqLhdek7cat7ADOk9fNLoFbUkwugpXCGyPDwup1l1j5ozXSfbL2dQHwhYn Ur/TLxZSy4Is61QloPpju97mbYoph4IS0/Y2IZj7JmHPmjifyi897v5/oXxBiw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1615933183; a=rsa-sha256; cv=none; b=WyRx6uiXtFQCjn0KuLEpI0gpCwKivrMZItOH+EnHtCfONyTBvPfKlMuT5FLPvjDNN9+C7E de6GXn22mi5fM4ENYbnRFHpMpyXWPMhbjwSxzen3gRuR3vM9DZLdSQzh6/8dQlVcZjI1Gg c1r8Tbi+/GRXSwZ1uANBQldG7MSavKwLV7nVCK71+NlK0GAnHTGLeVpjS1DHSZBFm4QmaP EU2o6e9iLKNj3Ub80A/CIJR6JesCrsKfsPcsq2unH2NKkUqfup3IERhh7p4vMVkAHLSC0L +KT2DY6/B8Dw3lnI2T48mfI5QSEJukiCEcidXSgvOa9FQBTGF8dcmGpaFzhsWw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.90 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 61FB41496A X-Spam-Score: -2.90 X-Migadu-Scanner: scn0.migadu.com X-TUID: LfgUh3zgrxoH Hi! Leo Famulari skribis: > On Fri, Mar 12, 2021 at 05:05:51PM -0500, Leo Famulari wrote: >> Here is an updated patch that can be composed with other >> sysctl-service-types that the user may have added to config.scm. > > The only issue that I see with this revised patch is that it's not clear > how users could disable these default settings if they wanted to. With your first patch, to change the default settings, one has to write: (modify-services %base-services (sysctl-service-type config =3D> =E2=80=A6)) With your first patch, someone who already had a =E2=80=98sysctl-service-ty= pe=E2=80=99 instance as part of their services would now get an error at reconfigure time. Your second patch nicely addresses that; the downside is that it actually makes it slightly harder to change the defaults because you wouldn=E2=80=99t know what to pass in your =E2=80=98modify-services=E2=80= =99 form. All in all, I have a slight preference for the first patch. It could be accompanied with a news.scm entry to explain the incompatible change, maybe. Thoughts? Thanks, Ludo=E2=80=99.