From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id MKYwCO+CeGDxAwAAgWs5BA (envelope-from ) for ; Thu, 15 Apr 2021 20:16:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id SND5Ae+CeGB2EQAAB5/wlQ (envelope-from ) for ; Thu, 15 Apr 2021 18:16:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BEB2112731 for ; Thu, 15 Apr 2021 20:16:14 +0200 (CEST) Received: from localhost ([::1]:42954 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lX6XF-0006N6-Hy for larch@yhetil.org; Thu, 15 Apr 2021 14:16:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47474) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lX6X4-0006LB-R2 for guix-patches@gnu.org; Thu, 15 Apr 2021 14:16:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55850) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lX6X4-0005Rd-IK for guix-patches@gnu.org; Thu, 15 Apr 2021 14:16:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lX6X4-0008Ul-EN for guix-patches@gnu.org; Thu, 15 Apr 2021 14:16:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47804] [PATCH] lint: Warn about underscores in package names. Resent-From: Xinglu Chen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 15 Apr 2021 18:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47804 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos , 47804@debbugs.gnu.org Received: via spool by 47804-submit@debbugs.gnu.org id=B47804.161851051232585 (code B ref 47804); Thu, 15 Apr 2021 18:16:02 +0000 Received: (at 47804) by debbugs.gnu.org; 15 Apr 2021 18:15:12 +0000 Received: from localhost ([127.0.0.1]:39163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lX6WF-0008TV-Sz for submit@debbugs.gnu.org; Thu, 15 Apr 2021 14:15:12 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:55356 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lX6WD-0008Sm-3r for 47804@debbugs.gnu.org; Thu, 15 Apr 2021 14:15:10 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1618510501; bh=T11bgPTjNismhrl98pFU//7hhRTF3l8gRdp1WDz574s=; h=From:To:Subject:In-Reply-To:References:Date; b=WE9RDgZITX8YOElKBXXkwJ9y5fIot8oVWLgcVl1e8FbfcRhqnzXPj3ei0dbBAZ/vD Ps1U8CcUljNhHP0Bl0uKOdCzYmuLBfohJEHQ1hA2/0Fc33FPu5zdKgPxzumv7wsOkh GBRlJzjQdef8KFTgGThDfNJBvLsjI7kooCShV36E= In-Reply-To: References: Date: Thu, 15 Apr 2021 20:15:01 +0200 Message-ID: <8735vrh0t6.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618510574; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=VGMriy7wjh0FmgTudP2z3tOSWOuQHX2xsTiM5f+CwR0=; b=nvtK8u9YFT9f7yPEdvczLtztGje60m7a9QQ0k3eodRmGa/As7xGgxwrjNKhvcrcYiIpWdu 2eLA6wdeAYX+pY6yiJFoNTN1LeAoXz0Uj5OlCANf0nn69x3K+v1XIK7OKi01YjDm9Eh90p v+t4wNGP8VGo1Jdo4T5MwrOCmJXaoSJ73bDwM4vM/UjRbJnkacJdo+aM7WV43hMEV7DnYE 4JiGtJv8yrFO3GUCzf0Eh9i25wO6qhbaxFNxxIns6YR0FNFhzCnpbC4j+TFhX2OB+hVzUi Tm1EQ2r3r0z1PG+Dr7/SRaCq+Zh5Le2ypB1YNi8d59dUzy30MxpFlfcgvNxYzg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1618510574; a=rsa-sha256; cv=none; b=HfUzRW4tegUI9IacKETUwljeUdcyO+sFHxKx4Nt64GTgsySOfFy8PPQ4+6Soh3BxUVuBZl FdiJcyD/ccLQ80bCmiEnY1VC4cPQFQJ0Ave0D2v7fFfuIRYuUqIqsWrPPZq9chQvKL1XnK goBOscDNL+rHKfxe48TIRKsCQx2huK8uFosBMM+GESc/Skx/ulCaaQTyD9d98Wb8tiI+PL qe+GZy2IZG2KpNMeXMdZV6CzmRMDgnAS5oRclmOf+lyPOQrWRynbR8qBE1DCRddGuMdkCJ G3vOh66B1Lp4BthDBmccdRlgKTRpzx83aO6mIMIkqEdefwl2AoZMfqWI99oRHw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=WE9RDgZI; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.34 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=WE9RDgZI; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: BEB2112731 X-Spam-Score: -1.34 X-Migadu-Scanner: scn0.migadu.com X-TUID: fc+QUrE1e8NN On Thu, Apr 15 2021, Maxime Devos wrote: >> There was some discussion about this on guix-devel[1], but no >> consensus was reached. Should we whitelist certain names like >> =E2=80=9C86_64=E2=80=9D or something? > > I dunno. Perhaps for now, we can accept that the 'check-name' linter > is sometimes overly strict, and punt the exceptions for later? Ok, that sounds like a good idea. > I didn't test this, but that seems about right. Ideally, you should > add a corresponding test in tests/lint.scm (IIRC, maybe the linter > tests are elsewhere). Will do. > However, Guix is currently in the "string freeze", so this cannot yet > be merged, IIUC. I thought the =E2=80=9Cstring freeze=E2=80=9D was for the manual, or did I = miss something? Thanks for the review!