From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id WAuVNHyszWBmdgAAgWs5BA (envelope-from ) for ; Sat, 19 Jun 2021 10:36:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id iKhTMHyszWANfwAAB5/wlQ (envelope-from ) for ; Sat, 19 Jun 2021 08:36:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 875EA1D681 for ; Sat, 19 Jun 2021 10:36:12 +0200 (CEST) Received: from localhost ([::1]:54376 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1luWSZ-0007CT-JD for larch@yhetil.org; Sat, 19 Jun 2021 04:36:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33092) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luWSU-0007C2-FC for guix-patches@gnu.org; Sat, 19 Jun 2021 04:36:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46965) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1luWSP-0007u3-VO for guix-patches@gnu.org; Sat, 19 Jun 2021 04:36:06 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1luWSP-0006xU-Tg for guix-patches@gnu.org; Sat, 19 Jun 2021 04:36:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49101] [PATCH 0/4] Add ocaml-mparser & friends Resent-From: Xinglu Chen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 19 Jun 2021 08:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49101 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Julien Lepiller Cc: 49101@debbugs.gnu.org Received: via spool by 49101-submit@debbugs.gnu.org id=B49101.162409173626704 (code B ref 49101); Sat, 19 Jun 2021 08:36:01 +0000 Received: (at 49101) by debbugs.gnu.org; 19 Jun 2021 08:35:36 +0000 Received: from localhost ([127.0.0.1]:58511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luWRz-0006wd-MZ for submit@debbugs.gnu.org; Sat, 19 Jun 2021 04:35:35 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:39960 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luWRy-0006wO-8f for 49101@debbugs.gnu.org; Sat, 19 Jun 2021 04:35:35 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1624091726; bh=l4jQwWbO0miEidJVQxpGc7ErEItCBR88MFTWYm6PM2g=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=QyU2ON4tfufNTF9aTsGABcI46qL6O7oOISb2Pg/kt3CxV4SGXrYeUiyNpyuhbIIHX 7NqahTR5XVpMjVZmLzVUkFxTeZgTnXzv/Eqot/pS2i1ppgtgEwzHUOCaHZbIdQXd2+ arQ3+9sjOVqcPHSSMo+3HROHklrzPWUX9pbjdTfQ= In-Reply-To: <20210619002851.732e3f59@tachikoma.lepiller.eu> References: <20210619002851.732e3f59@tachikoma.lepiller.eu> Date: Sat, 19 Jun 2021 10:35:25 +0200 Message-ID: <8735te45gy.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1624091772; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Ke9MrltDOIcFBS1gGcHFybHjM8S9J5wHlKjhxT8qXwg=; b=tSkav9fAPm4t9owHsw+f4rkargAN7XsAAOc7DqhQlW2qSzkmCY/D8VZUqoA9OaIP4epI/f mGs+luNNitPYM32vUA/U91I8dj99a2elPmY1/sGCeTLD6YzXo8ZVekI5OXOdbP4ShQ7sf6 1dSRCk2/SG1PJwXrIF9fMpU+Q2qgnuMUqcuAORtS2IMzZvAiXRkcStk+5Jil1yk6BubWb+ Yjgb1mcCdvKIWYX6npxmGKaCxS9bc9UXCo0C/wUvT1alJopGcIN/UqaaOWziKy2FvaF/gZ G/ASxqBP9VOKP5OQedWJoCDt/5aZ8sdgV0erOGpUXWVzaKqk0MBD7m66rqGZtQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1624091772; a=rsa-sha256; cv=none; b=lrw2rXZb+quAm46bDSw1quvGpDQK5xka9zJ60mfu+BY01JB8hW0lD49+hf9QiA47D51afN FygM3vsdQ38hbRR1mg0H3zvCuBGfQtVRpn398lnq1kpVzMdprdxtDyfNB5R0uq8sJqO+EL epEAVADQImRHEnFAa1GiK64tS/vEjdzT8w2bLFyZ3gQS2rvhUnfBEBRD0177KncdJCSB5y JwFfiZugRXuNgglspd3YQUS4pH5k8vdQOCmG+t9eQQQ9RJ3WP58f5Sb+j6PRv6emlHQyEO 9SV56AOp802ahne5w9tmLtkBLR+UpNVFq+em1xNKnAQATnnHjsN5LilhVrE++A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=QyU2ON4t; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.42 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=QyU2ON4t; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 875EA1D681 X-Spam-Score: -3.42 X-Migadu-Scanner: scn1.migadu.com X-TUID: PRf+cMhaJPQs --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sat, Jun 19 2021, Julien Lepiller wrote: > Le Fri, 18 Jun 2021 21:00:51 +0200, > Xinglu Chen a =C3=A9crit : > >> This series adds =E2=80=98ocaml-mparser=E2=80=99, a monad parser combina= tor library, >> plus two extensions for it --- =E2=80=98ocaml-mparser-re=E2=80=99 and >> =E2=80=98ocaml-mparser-pcre=E2=80=99. >>=20 >> I noticed that there already exists an =E2=80=98ocaml4.07-pcre=E2=80=99 = package, what >> is the policy regarding =E2=80=98ocaml4.07-*=E2=80=99 and =E2=80=98ocaml= -*=E2=80=99 packages? >>=20 >> Xinglu Chen (4): >> gnu: Add ocaml-mparser. >> gnu: Add ocaml-mparser-re. >> gnu: Add ocaml-mparser-pcre. >> gnu: Add ocaml-pcre. >>=20 >> gnu/packages/ocaml.scm | 88 >> ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 88 >> insertions(+) >>=20 >>=20 >> base-commit: caf4a7a2770ef4d05a6e18f40d602e51da749ddc > > Hi Xinglu, > > thank you for the patches! First, you should reorder your patches: we > try to make sure every revision of guix is correct, but after the third > patch, ocaml-pcre is missing. I would simply put pcre first :). Yeah, I think I messed something up when sending them. > To answer your question, we try to avoid having both the ocaml and > ocaml4.07 around if possible. It seems that ocaml4.07-pcre is only > required for ocaml4.07-expect. Could you check if it is possible to > build expect with our latest ocaml package? > > If so, please have a patch that builds pcre and expect with the latest > ocaml, then another patch for updating pcre to the latest version, then > your three patches to add mparser. > > If not, then we have to keep ocaml4.07-pcre around, so here is how we > do it, in a single patch: > > Replace ocaml4.07-pcre with ocaml-pcre (remove the arguments that use > ocaml-4.07) and create a new ocaml4.07-pcre that inherits from it. It > would look like this: > > (define-public ocaml-pcre > (package > (name "ocaml-pcre") > ... > (properties `((ocaml4.07-variant ,(delay ocaml4.07-pcre)))) > ...)) > > (define-public ocaml4.07-pcre > (package-with-ocaml4.07 > (package > (inherit ocaml-pcre) > ... > (properties '())))) > > If the latest version of pcre cannot be built with ocaml 4.07, you can > specify a different source, like we do for ocaml4.07-parsexp for > instance. Thanks for the detailed answer! I think it would be great to have something like this in the manual :) > I'm looking forward to v2 of this series :) Should be coming soon :) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmDNrE0VHHB1YmxpY0B5 b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x5XsUQAK8R727QjF82noETwxz3LDW9OkBt MiYBmrJIDt67/PEwIZ64rMOTOUTFFOW/vgHGzodn19pmAJlpGfsUq53/lOCmOG3K 2AL5u1grkheybgTTe8gtffpdiR64gEmr2Qodhb5rxP8obNb28cnpXUUhIl6lEdXq 8Dv5LyJ9PYqi6T2t0SVmBR/h4RoyvOHYDIIJ3JQi47DDF1GOYQNmGXomfUoWTrOI Dzducxdx1xQhPkzJ/cU9oVbYeJ4wFN8S7f/w2GGa+XM/YBnRDouj07EOCpa4Nz7d UoLH2b9okClqk8RLJqx4jqHQWSvPxCViGtJixzdlokjGCEUxDimhXSxPhWRmI11g /NDrgoq6tNngRFs5ckfQGLn1GOZ/I3/Ek/2g4hWFZ7+YMDfiJByxHWuTMiKMXu4T XRXnwyEZBL5AKNb4YUq4myZ0AJ9jjP9nRS7EKNNMcG350WUNz1yO2S+QSebMI09O Cqoxintsl9ICty5YXBxkgs5s/r/VFBH15bCLfeiwBSr+0dtobuxcOUn2Z84XrtqX NXNgEmNTM7u193w84KIcYazGaEdAHgKnadUSgKdypqXzRugGEddFhjMniuUGHRH6 f6VItCO4DQmRaw13LL8iAZX1JatpjzcLjEH7LQ9a0xJ2Z5s6uqU90YaV50NtZye7 nvdcLtoiTHEDe0Ng =2Cj1 -----END PGP SIGNATURE----- --=-=-=--