unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Xinglu Chen <public@yoctocell.xyz>
To: Adu O'Hara <adu.ohara@posteo.net>
Cc: 49203@debbugs.gnu.org
Subject: [bug#49203] [PATCH 1/2] gnu: Add ocaml-uri-sexp.
Date: Fri, 25 Jun 2021 12:58:06 +0200	[thread overview]
Message-ID: <8735t6jjnl.fsf@yoctocell.xyz> (raw)
In-Reply-To: <86fsx6xmwx.fsf@posteo.net>

[-- Attachment #1: Type: text/plain, Size: 1415 bytes --]

On Fri, Jun 25 2021, Adu O'Hara wrote:

> Xinglu Chen <public@yoctocell.xyz> writes:
>
>>> True, what I was suggesting would add another patch to the 
>>> series 
>>> and mix up intentions of the series.
>>
>> Sorry, I don’t get what you are trying to say here.
>>
>>> Still, I'd suggest for ocaml-uri-sexp to inherit from
>>> ocaml-uri. Otherwise we have them at two different versions.
>>
>> I think it makes more sense to do that in a separate series 
>> since
>> updating ‘ocaml-uri’ isn’t really related to adding 
>> ‘ocaml-cohttp’.
>
> Sorry for being unclear. Here's what I mean:
>
> (define-public ocaml-uri-sexp
>   (package
>     (inherit ocaml-uri)
>     (name "ocaml-uri-sexp")
>     (arguments
>      `(#:package "uri-sexp"
>        #:test-target "."))
>     (propagated-inputs
>       `(("ocaml-uri" ,ocaml-uri)
>         ("ocaml-ppx-sexp-conv" ,ocaml-ppx-sexp-conv)
>         ("ocaml-sexplib0" ,ocaml-sexplib0)))
>     (native-inputs `(("ocaml-ounit" ,ocaml-ounit)))))
>
> Then when `ocaml-uri` eventually gets updated `ocaml-uri` and 
> `ocaml-uri-sexp` will be at same version.

But ‘ocaml-uri’ would first have to be updated to the latest version,
which I think is out of scope of this series.

Once this series gets merged, I think it would be great to update
‘ocaml-uri’, and then make ‘ocaml-uri-sexp’ inherit from it.

WDYT?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

  reply	other threads:[~2021-06-25 10:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-24  9:54 [bug#49203] [PATCH 0/2] Add ocaml-cohttp and dependencies Xinglu Chen
2021-06-24  9:57 ` [bug#49203] [PATCH 1/2] gnu: Add ocaml-uri-sexp Xinglu Chen
2021-06-24 12:42   ` Adu O'Hara
2021-06-24 18:39     ` Xinglu Chen
2021-06-24 19:32       ` Adu O'Hara
2021-06-25  9:18         ` Xinglu Chen
2021-06-25 10:04           ` Adu O'Hara
2021-06-25 10:58             ` Xinglu Chen [this message]
2021-06-25 11:06               ` Julien Lepiller
2021-06-25 12:39                 ` Xinglu Chen
2021-06-24  9:57 ` [bug#49203] [PATCH 2/2] gnu: Add ocaml-cohttp Xinglu Chen
2021-06-25 13:07 ` [bug#49203] [PATCH v2 0/2] Add ocaml-cohttp and dependencies Xinglu Chen
2021-06-25 13:07   ` [bug#49203] [PATCH v2 1/2] gnu: Add ocaml-uri-sexp Xinglu Chen
2021-06-25 13:07   ` [bug#49203] [PATCH v2 2/2] gnu: Add ocaml-cohttp Xinglu Chen
2021-06-27 13:17   ` bug#49203: [PATCH v2 0/2] Add ocaml-cohttp and dependencies Julien Lepiller
2021-06-27 13:38     ` [bug#49203] " Xinglu Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735t6jjnl.fsf@yoctocell.xyz \
    --to=public@yoctocell.xyz \
    --cc=49203@debbugs.gnu.org \
    --cc=adu.ohara@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).