From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id CLXMORG93GCFNQEAgWs5BA (envelope-from ) for ; Wed, 30 Jun 2021 20:50:57 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 4H5/NRG93GBXWQAA1q6Kng (envelope-from ) for ; Wed, 30 Jun 2021 18:50:57 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 621D91A8A2 for ; Wed, 30 Jun 2021 20:50:57 +0200 (CEST) Received: from localhost ([::1]:53076 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lyfIW-0001i3-AW for larch@yhetil.org; Wed, 30 Jun 2021 14:50:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46504) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyf54-0003hb-KW for guix-patches@gnu.org; Wed, 30 Jun 2021 14:37:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47179) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lyf54-0004RL-BC for guix-patches@gnu.org; Wed, 30 Jun 2021 14:37:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lyf54-0001i5-5E for guix-patches@gnu.org; Wed, 30 Jun 2021 14:37:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49149] [PATCH 0/7] Add deb format for guix pack. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 30 Jun 2021 18:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49149 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 49149@debbugs.gnu.org Received: via spool by 49149-submit@debbugs.gnu.org id=B49149.16250782156560 (code B ref 49149); Wed, 30 Jun 2021 18:37:02 +0000 Received: (at 49149) by debbugs.gnu.org; 30 Jun 2021 18:36:55 +0000 Received: from localhost ([127.0.0.1]:58725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyf4x-0001hk-DT for submit@debbugs.gnu.org; Wed, 30 Jun 2021 14:36:55 -0400 Received: from mail-qv1-f54.google.com ([209.85.219.54]:40861) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyf4w-0001hZ-J9 for 49149@debbugs.gnu.org; Wed, 30 Jun 2021 14:36:55 -0400 Received: by mail-qv1-f54.google.com with SMTP id g14so1617688qvo.7 for <49149@debbugs.gnu.org>; Wed, 30 Jun 2021 11:36:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=/uvDiTnLvvFob3mYPVOYpntkJhAmL6JvIYlVdVztJnU=; b=RrMrOKzW4LKwbBx46iEijZYoNzvQi8oW1hWqU4+mU8pzvPEyqxT+HCfzoNKOe+06Cy 2/19pX9lnXrO2uH1MzBCt/ucJ/xtk3iyRrcSXf4HcDX+4VJ8hhYgjamlhj/jmGmoadtz my2mdCavBKVoQ09W3QhXQfyFii2ypFh7b4KcS95yQ1r6gEYX9clyOD2+29wplmJLEHvF 7EFv38uu0qQxY3bkLm/xyRTNsRw/i4rvgiG6nsjb/2756VHZSTy3jiXqtCxzNQcvtE6g GEjvlXQh2mY5QaWF9I9CN2WY2GTnHJmfHbpNXZHG8oL6LNywCDVkzC5zjO6uMOCf5hWa ycQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=/uvDiTnLvvFob3mYPVOYpntkJhAmL6JvIYlVdVztJnU=; b=Wcueq98Q7zB9Je+fK8yihIy7ibKoaeeAti1F+pbYZfE5TjybyBGznxz/iQqMY2cUkk QD7X8wcMo5jVbya2/HJTt3HGH29fUkgHD/Tl3hsOY0kiEPymFaL/LiQ20mTmavE9U54x XtVR2gqoQ1trdgtuikNYFeqOD/OMQgyAb2uTYJysqGhuGOQMPT2vyehCeapxq77WtQdB VtEIVTLFVW+u9j13UqgRC02q4+sq03P7WKIB4YzVazy4gKhWuqGVf+X/MNQh0hfjT0hC mZDcdPQbBHxwHlUa89BOk6BihaCXo1at/hxcb8DzJgCNeDG9CfeDoX40ydVjhsjGIvaP gTUw== X-Gm-Message-State: AOAM533IaqYQBjiggfyF2LSjPEqfO+eKhB5LP+JxIOILbKjvCuIieZ5C PUBEDWcZlOqv64Ni8zrAxUFikyHEgyM8Tw== X-Google-Smtp-Source: ABdhPJyre5KmtDmVXNaLZ7Vo17Z2Uk4eV6gp41QgaKZvWrQli8EJvacXfWWyqZHvQb1enXLy6XxhJw== X-Received: by 2002:a0c:ef8b:: with SMTP id w11mr38396448qvr.37.1625078208980; Wed, 30 Jun 2021 11:36:48 -0700 (PDT) Received: from hurd (dsl-150-149.b2b2c.ca. [66.158.150.149]) by smtp.gmail.com with ESMTPSA id l14sm415793qtp.5.2021.06.30.11.36.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Jun 2021 11:36:48 -0700 (PDT) From: Maxim Cournoyer References: <20210624044049.17906-1-maxim.cournoyer@gmail.com> <20210624044049.17906-4-maxim.cournoyer@gmail.com> <87lf6roe32.fsf_-_@gnu.org> Date: Wed, 30 Jun 2021 14:36:47 -0400 In-Reply-To: <87lf6roe32.fsf_-_@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Wed, 30 Jun 2021 12:13:05 +0200") Message-ID: <8735sz42tc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1625079057; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=/uvDiTnLvvFob3mYPVOYpntkJhAmL6JvIYlVdVztJnU=; b=fS0CttM5rosJr3kRqpPUOVZO/azOO9VMHbne5lAKg5fHnOup9E0AQT/3Q7hBvv7CU8Oeyv GgKSeP7DQx096DF1JSLG0yMT2qt5rr9weaq5b1YGf/Pl2zegS+24eGpfkH0WAaqpedn9IR 5LPIn9Q5NFaw3i7UTSJX6695YBOi53ijR/DHq8CkFrfCrAcPpCQN4GixWImQmnSOcfU0SR 6fKDq0JHhPBhOCaKHI6FEvjlJOOTRlFpd25Ej6cPiuScW52mIoh6kaHtby+tCLj9alRTGW b/tpFeccmNZemz/tJtQXbGqs5HnkNygLaZp7oNnTpCLN//t3LwEfyWiNZFItIw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1625079057; a=rsa-sha256; cv=none; b=HcAux+HGMPsn+Z0G15YhwHCdPVp9MMDnskT1NrwhDhj316L5FIFT3+uNcNdGdnFA1S9ipM sxSEFudpxJJFEA6MrjqJP4PZX+q9qtmogDYvV4IsawLeCRzkb+i8L7YInN12jry9eZtPQV 3yoc2bbhS6GTs0s6KVuQticcv7fZii7rRmK0qJW7xK4JE3jjlA1T4ki97XELg42jvdS009 0ey3nRDq99MHAdHwJgvyclcCD+6zK8tah5p/QQWxPTDWpFOinpoY/S150ZM5ngjINU/bpK 5GZ0YJWfTUmITC8K8YQAxdM7MtF7QyrbJ/cl0jDmpocxJU0Qq3vFw8VYnD8oJA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=RrMrOKzW; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=RrMrOKzW; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 621D91A8A2 X-Spam-Score: -1.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: MdI031v41VVB Hello, Ludovic Court=C3=A8s writes: > Maxim Cournoyer skribis: > >> Instead of just naming them by their pack type, add information from the >> package(s) they contain to make it easier to differentiate them. >> >> * guix/scripts/pack.scm (define-with-source): New macro. >> (manifest->friendly-name): Extract procedure from ... >> (docker-image): ... here, now defined via the above macro. Adjust REPOS= ITORY >> argument value accordingly. >> (guix-pack): Derive NAME using MANIFEST->FRIENDLY-NAME. > > [...] > >> - (define tag >> - ;; Compute a meaningful "repository" name, which will sho= w up in >> - ;; the output of "docker images". >> - (let ((manifest (profile-manifest #$profile))) >> - (let loop ((names (map manifest-entry-name >> - (manifest-entries manifest)))) >> - (define str (string-join names "-")) >> - (if (< (string-length str) 40) >> - str >> - (match names >> - ((_) str) >> - ((names ... _) (loop names))))))) ;drop one ent= ry > > I think this should not be factorized because the requirements are very > Docker-dependent. Once factorized, it becomes easy to overlook this. Hmm, I'm not a docker format expert, but my quick reading about it turned no restrictions about what a docker image label should look like? So perhaps it is not specially Docker-dependent. If there's something truly Docker-dependent about it I'd suggest adding a #:docker-compatible? boolean option to the procedure. Maxim