From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cIcRASCw5WBDGAEAgWs5BA (envelope-from ) for ; Wed, 07 Jul 2021 15:46:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id eBpJOB+w5WB1DgAAbx9fmQ (envelope-from ) for ; Wed, 07 Jul 2021 13:46:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BECEB20FA6 for ; Wed, 7 Jul 2021 15:46:07 +0200 (CEST) Received: from localhost ([::1]:39684 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m17sM-0004Kz-Ms for larch@yhetil.org; Wed, 07 Jul 2021 09:46:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45488) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m17sI-0004Km-IO for guix-patches@gnu.org; Wed, 07 Jul 2021 09:46:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39741) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m17sI-0006LJ-Ad for guix-patches@gnu.org; Wed, 07 Jul 2021 09:46:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m17sI-0007Jb-7i for guix-patches@gnu.org; Wed, 07 Jul 2021 09:46:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48729] [PATCHES v9 ALL/25]: Bitmask Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 07 Jul 2021 13:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48729 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Raghav Gururajan Cc: jgart@dismail.de, 48729@debbugs.gnu.org Received: via spool by 48729-submit@debbugs.gnu.org id=B48729.162566550428043 (code B ref 48729); Wed, 07 Jul 2021 13:46:02 +0000 Received: (at 48729) by debbugs.gnu.org; 7 Jul 2021 13:45:04 +0000 Received: from localhost ([127.0.0.1]:51287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m17rM-0007IF-IE for submit@debbugs.gnu.org; Wed, 07 Jul 2021 09:45:04 -0400 Received: from tobias.gr ([80.241.217.52]:49936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m17rH-0007HU-IX for 48729@debbugs.gnu.org; Wed, 07 Jul 2021 09:45:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=8Oqlx41IhVEES jLXPqFGbsyCRQkvCORYf6Uq2IrRDU8=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=FJX4MW/cZuXud0FSadWb0TIsKrNX0eOJkqWWbL UZlEjaFQdy2TiBIKfOXelZbejHD0vOlQCcuF2n80wLxQy5/4j8bGwxCwduIOk6YA+hySfI 6cc2v40dWsVqm1AuCIvyzqCP/rSHR4J0jh4YfeU8cBtL9V57DmcjeHANEBUXcCeGnbUtpu iSkG+/NAWSKp1E9T1uHhow48bn8dOjm4CzB0UTRAWgiJzK8N8YDw+tfeyvq9Fptvn1T9S5 xdNTQ2l8ODU9JcAxX0rxLf6xSjFVYhuJJHhOHPg4CQI0qB2VTjXouc+pNqnYu0xuy+0/IZ 62iEMzSeuPQFa+BDsEeFKk4w== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 6cc2856c (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Wed, 7 Jul 2021 13:44:54 +0000 (UTC) References: <2875e11d-3fe3-2f22-e2c4-6b21f4339353@raghavgururajan.name> Date: Wed, 07 Jul 2021 14:51:42 +0200 In-reply-to: <2875e11d-3fe3-2f22-e2c4-6b21f4339353@raghavgururajan.name> BIMI-Selector: v=BIMI1; s=default; Message-ID: <8735sqi6fb.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice X-ACL-Warn: , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; none X-Migadu-Queue-Id: BECEB20FA6 X-Spam-Score: -4.00 X-Migadu-Scanner: scn1.migadu.com X-TUID: 5bN0qBU4afPl --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Raghav, I spent an embarrasingly long time trying to get this to work=20 under Sway (I'm sure it works fine under a GNOME VM, that's not=20 the point :-p) but had to give up. It's not a blocker. And with that, I think only have two more remarks! You don't need=20 to send a new revision to review. > @subsubheading Bitmask > + > +@defvr {Scheme Variable} bitmask-service-type > +A service type for the @uref{https://bitmask.net, Bitmask} VPN=20 > application. > +It makes the application ready for use. > +@end defvr Thanks for adding some docs! Unfortunately I learnt nothing :-) Documentation should teach something new, for example: =E2=80=9CThis service type makes the @uref{https://bitmask.net, Bitmask}= =20 VPN client available to all users as a system package, and installs=20 the global system Polkit permission rules currently required for=20 users to run it. It will @emph{not} start a Polkit agent for you, as most=20 desktop environments provide their own. Users who don't use such a=20 desktop environment must run their own agent in order to use Bitmask.=E2=80=9D > + (default-value bitmask) That's OK if there's no way this service will need to be extended=20 in future, which IIRC was the case, since eventually it should=20 even be removed. *Otherwise* I'd recommend wrapping this in an extensible=20 (bitmask-configuration (bitmask PACKAGE)) record. Thanks, again, to you both for all your effort. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYOWv+A0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW154swA+wb3HpSVmD41zzh6IhVxyPTpckpFjuKG5ygOZkyx F2keAQDVLIoUqf9SQpn8uLTeoFTCtlyrK6sPIlEM6FgSElyxCA== =IE/0 -----END PGP SIGNATURE----- --=-=-=--