From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id CL0yDe516mDwKwEAgWs5BA (envelope-from ) for ; Sun, 11 Jul 2021 06:39:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id IPPtCO516mCcEAAAB5/wlQ (envelope-from ) for ; Sun, 11 Jul 2021 04:39:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DE44D243CE for ; Sun, 11 Jul 2021 06:39:09 +0200 (CEST) Received: from localhost ([::1]:53266 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m2RFF-0007JY-0r for larch@yhetil.org; Sun, 11 Jul 2021 00:39:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38284) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2RF8-0007J3-24 for guix-patches@gnu.org; Sun, 11 Jul 2021 00:39:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50419) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m2RF7-0002sn-QN for guix-patches@gnu.org; Sun, 11 Jul 2021 00:39:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m2RF7-00021X-ME for guix-patches@gnu.org; Sun, 11 Jul 2021 00:39:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49329] [PATCH 00/??] Improve Ren'py package Resent-From: Chris Marusich Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 11 Jul 2021 04:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49329 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Prikler Cc: 49329@debbugs.gnu.org Received: via spool by 49329-submit@debbugs.gnu.org id=B49329.16259782847713 (code B ref 49329); Sun, 11 Jul 2021 04:39:01 +0000 Received: (at 49329) by debbugs.gnu.org; 11 Jul 2021 04:38:04 +0000 Received: from localhost ([127.0.0.1]:33732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2REC-00020L-D9 for submit@debbugs.gnu.org; Sun, 11 Jul 2021 00:38:04 -0400 Received: from mail-pg1-f172.google.com ([209.85.215.172]:35760) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2REA-0001zr-HL for 49329@debbugs.gnu.org; Sun, 11 Jul 2021 00:38:03 -0400 Received: by mail-pg1-f172.google.com with SMTP id v7so14498072pgl.2 for <49329@debbugs.gnu.org>; Sat, 10 Jul 2021 21:38:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=p8N/tRmxRRGXLDSGqjyJN+JBpAYRtT2aTyMw/EEQJaY=; b=cdpKxcOGtAPqxFoDM5syVbJeRIZj13A6NKnJOi2MUIyUYEfBvVKDrYcjUJurk8+huT 0j6sJPiLgsZS0TpQY3I+QSIDA3FcguXNo/KFojVb0UgEAYDFPR9uqzFSV6mSytecHDnJ Z+w3piLV72QRVfyXn8sxUZ7AKhVsfT2pg2tyESj1x7dar0S2q+3GdDAxH4n+RgPYLRne xUpMwSkwk9GhF68fxq6/TrhBArVysmSMEzDVHXOqQtG7E+2yctCqYDDJpVIFcMzuJPNG zg+JDk8cEp4thOgOIbSpyuC7hoY6JTov3vhyCMhRFCLU0dBE/un62SRwdPnW0OdwM2Jc dM/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=p8N/tRmxRRGXLDSGqjyJN+JBpAYRtT2aTyMw/EEQJaY=; b=Su+2XQdEMyWVC4rB1MV1KzNz0ZeCHAOg2MH5bpzGGYjcQzROsqdrIXP6SJE3acaEja SYRDI7SZekw3A4NSHPmOlSpHwfuctAEslvRI/+PrivYpjkAtvdKDV/ZYcWpNa5cvOn3x 39Dk8AZwGrS+Mrzd/aZlYiLkP99iMzt36gFgV2sZ3mrMYUMvMjcw7F69NLa+e5NqDBpv QPkLoayT8BSwBSQqHHI6wIv3VbOyeV86W7cP/oZaVG1wgvhYkWqEtg3qDP49LDWcsM+p 72KNJaI2XH/C/so+N88rWhQ66yeNfAkGVoWU4spI2k3P6DXstW0f1meKwMZb4VCipYwQ BctA== X-Gm-Message-State: AOAM531+Sb/MNOKRFzi95CZXY3sVZUi3Vx5SbCZFS/L8W/ExShFgVMhs 0QvVTItEh6Trm4EoCaRzYBQnAVNIWRHCuw== X-Google-Smtp-Source: ABdhPJz8/fj4nOEJAaHmoPo/kA8Pqs2RAzDSaW3bTQlQ9susAj24zt5bqcIiUSXERiVhSNAGJhbkxw== X-Received: by 2002:aa7:8112:0:b029:328:70bc:3307 with SMTP id b18-20020aa781120000b029032870bc3307mr14277540pfi.67.1625978276226; Sat, 10 Jul 2021 21:37:56 -0700 (PDT) Received: from garuda-lan ([2601:601:9d01:3f90::a1ab]) by smtp.gmail.com with ESMTPSA id 1sm10784493pfm.123.2021.07.10.21.37.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Jul 2021 21:37:55 -0700 (PDT) From: Chris Marusich References: <20210703092842.32189-1-leo.prikler@student.tugraz.at> <20210703092842.32189-4-leo.prikler@student.tugraz.at> Date: Sat, 10 Jul 2021 21:37:51 -0700 In-Reply-To: <20210703092842.32189-4-leo.prikler@student.tugraz.at> (Leo Prikler's message of "Sat, 3 Jul 2021 11:28:42 +0200") Message-ID: <8735sl5uu8.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1625978350; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=p8N/tRmxRRGXLDSGqjyJN+JBpAYRtT2aTyMw/EEQJaY=; b=sOhmygew9eIyZd5IPN9DoKg9WFtGNgHuhfeKbVrsH17Jm6LiEDcf3siqRPX74SJVTN8m2t VAnQOvJgPcXIbiMJBySbS923oUZIBOdhE1JABRlmnP4pV8EA6hfBUqO5GjidMlujNUhU2G fu8ZG0aoLH0H4DV5OyHxXuvZNZfddHkD9IfCvG5JdejfokbdphBWDxUmE8Pm40FksVctV9 r/LfR7eZBbXglJrG6O0v8Cvy+tU06xj6Yy8I/RhL9jHpnALr+ez54Nt/kkb4skCCwKzTw/ kMj/kx4NABDNSUZl2OiGDiBNzB9pyD4K7T3lkF7gaiZIz6kovpS0wa9nIYZ1wA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1625978350; a=rsa-sha256; cv=none; b=ik9k3oqLcszffJ8zjW5c9Lx36/JKLB51XYX4YJN7Tsmd7el1dttipFUgE7GdOLj7Tj8HTa Qz26cHi5YVVOdf+faOCL8dlOgzLejWR4rISWca387UTnuGtPIgrmHceAx10AHb0FkoaCMW Yg1xpOKTMj1Riiflfvm2fSCURguLuf6PuH8tIiHRS+60ncW+g0vtlC0jXUO0EHphhf2dvb yj3bpWMRYWMOTzzhQEllC9yvui21MpWyKwGi+JbHfeenV1Gk0Z6Q1NKaz2YhnAsZ7CN+i5 0ILdR6uXhGzzR/yZYlefezOSzxfAT+1KOGyJ638lZgOVOilolQXdzYVsaVZK9w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=cdpKxcOG; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.59 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=cdpKxcOG; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: DE44D243CE X-Spam-Score: 0.59 X-Migadu-Scanner: scn0.migadu.com X-TUID: OifF63tV6ASr --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Leo Prikler writes: > diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-develo= pment.scm > [...] > #t)) > (replace 'wrap > (lambda* (#:key inputs outputs #:allow-other-keys) > - (wrap-program (string-append (assoc-ref outputs "out") > - "/bin/renpy") > - `("PYTHONPATH" =3D (,(getenv "PYTHONPATH")))) > - #t))))) > + (let ((out (assoc-ref outputs "out")) > + (site (string-append "/lib/python" > + (python-version > + (assoc-ref inputs "python")) > + "/site-packages"))) > + (wrap-program (string-append out "/bin/renpy") > + `("PYTHONPATH" =3D > + (,@(delete-duplicates > + (map > + (lambda (store-path) > + (string-append store-path site)) > + (cons (assoc-ref outputs "out") > + (map cdr > + (filter > + (lambda (input) > + (string-prefix? "python2" (car inp= ut))) > + inputs)))))))) > + #t)))))) What's the motivation for doing this? It seems like the new version deletes duplicates, but has the downside of being a little more complicated and relying on the package names to determine what goes into the PYTHONPATH. Duplicate entries in the PYTHONPATH should not be a problem for correctness or performance, right? I feel like this section was perhaps better the way it was originally. Am I missing something? =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAmDqdZ8VHGNtbWFydXNp Y2hAZ21haWwuY29tAAoJEN1AmhXYIkadt48QANHE5O25M4VFKZBCFRiNqyJe0AJh ccusZ23P4wPvg97hLKZT6c9GKCjiPLWZGHRIh5a9Fmh4MH6XN6KXRg5zA4V5GzjF WriXfbpzT8kRGHvaLLiM8F1U+xQWfYnry0Cz1tp13NZU9U7LNpnVF1mMTnc/IDX2 Bo5G1r+uq3g+Q5DPQjbKiJyko/Up8bL53360h2W+dYX+ZN6tZ+pExKVl+E97a2Wz 5D38S5W3j5Epn1UxzlbVp5eY8H3SvCU5DNN+LFiWVKLWH4M6vBVi7Flagi3GTLRW kDWtJk1usrZHR8rS9M3tG56JQ9FeGSxsQ0EXSnaD3tKQLhwHaqYwMDA+HhM8B4r7 YY7xglQ6dCPj5WZdulVaiS6SQWHS+WvuArrgm07Ef+Oxg8h4aiQm/h1NMdYflJ67 rzuDFlrZtUanL33K+yZnIwbOBg03+6STCkSzRPNMzcv9txB6KGva5B6zdvtUgLX8 vIMJq4DgymEMlD8BarfPy+euXt9QhnvWnWA0zIoUvJmt41+CsVIUzVBUjF5yfjb9 5GT1WZjZhQtNtdhGEh4LS+q8K/4jVdGi+YFNEt/tX39kphb1qcqM7t4ORm5dSaOS GB7rBHDwFXT847+hAluItvV9z9x09aOziiK5O/TeVhRXxBDqIl7RPuE7+PtczPd+ NSqPJAGVgWsjgJp8 =hvkH -----END PGP SIGNATURE----- --=-=-=--