From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id SktDJ/5VNmHc1wAAgWs5BA (envelope-from ) for ; Mon, 06 Sep 2021 19:55:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id YMY0Iv5VNmEFegAAbx9fmQ (envelope-from ) for ; Mon, 06 Sep 2021 17:55:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0EB53159B2 for ; Mon, 6 Sep 2021 19:52:27 +0200 (CEST) Received: from localhost ([::1]:58562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNInC-0001Pc-62 for larch@yhetil.org; Mon, 06 Sep 2021 13:52:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57238) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNImo-0001O6-VC for guix-patches@gnu.org; Mon, 06 Sep 2021 13:52:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42861) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mNImo-0001vC-Mk for guix-patches@gnu.org; Mon, 06 Sep 2021 13:52:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mNImo-0002AG-C4 for guix-patches@gnu.org; Mon, 06 Sep 2021 13:52:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48237] [PATCH] gnu: emacs-consult: Add =?UTF-8?Q?=E2=80=98emacs-ve?= Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 06 Sep 2021 17:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48237 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Xinglu Chen Cc: Arun Isaac , Leo Prikler , 48237@debbugs.gnu.org Received: via spool by 48237-submit@debbugs.gnu.org id=B48237.16309506938283 (code B ref 48237); Mon, 06 Sep 2021 17:52:02 +0000 Received: (at 48237) by debbugs.gnu.org; 6 Sep 2021 17:51:33 +0000 Received: from localhost ([127.0.0.1]:54407 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNImL-00029X-GG for submit@debbugs.gnu.org; Mon, 06 Sep 2021 13:51:33 -0400 Received: from mail-qk1-f171.google.com ([209.85.222.171]:45691) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNImK-00029H-Fp for 48237@debbugs.gnu.org; Mon, 06 Sep 2021 13:51:32 -0400 Received: by mail-qk1-f171.google.com with SMTP id a10so7550548qka.12 for <48237@debbugs.gnu.org>; Mon, 06 Sep 2021 10:51:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=S9I2G2u4/Vu3JZydy2l3TC5zjFpqDgyelLr55i6qr7M=; b=b+VOax+zubsJs6ZfFLCNex4hM0AYHTRa1h8q7mMuecJttOBeReIV4WlkVPkmpQ7YLZ SK/u62HtYpHEFgNNoOT6ZdQO0yrhRaPlR1+QKl0XZjVYRR5peoutcSJmffEagIgnh4Sj K0/kf7Qh4Bzsf7jdGGgFOFJsQ8RK3TtlRhQkHo7Dfk5ACNL8+3KefVqJB9JqNOVKH8ck 5+kXABifhqHhjiNN3+TAanO5p5a5D94BU8q1yGiwed4/xGVccjz9T13Vb0I5xf0oK03u oVCcUFxyRSQlhUxJUNP82P1/Zz5UQKXpx4OmvfiEpbfu7bTeVE3mSl1QtVLXmT8gM7BZ OEzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=S9I2G2u4/Vu3JZydy2l3TC5zjFpqDgyelLr55i6qr7M=; b=nXuVsCXneZ78C4Lq2WenOWV5dkM6s2qD0wE4yqlGUgaRf9WS//xISOT1vyfPYa2aZA CwvqOBT92xl5ouXtRHIglL2+Sl6yImXCPxsT7Ehpnp4Q2Sz9sl0zBQDFD3H7RD+VaMx8 DmOVD4kpD1QZd1iJulyPA9l16yQrme6QT3QO10E2VN5NS1PrlTPoNdTZhI2bAqefHBjO kCqhTHxmkhidgYXgekL7eb9i79KR7JU9SOZJu2lnaJa95hndGtIvu/V63dePoFiS4MyZ 2q721oG6WsO0/nc/mBbXKly0x8QRry0HyWFRazql71i0vs8oRLSWmUYF1kRNciTEaxrH eJkw== X-Gm-Message-State: AOAM530XQKvgFSOrhYZRDewUV36mIkBgZ+Xfdi7f5Ko4YMdZGoWk6x0N Bc+cTU/3vlyq7PpV5nAwFnGJTQfe2Rc= X-Google-Smtp-Source: ABdhPJzkqnwgDSFHYlh11LCMfY8eVSmeapfVvG2+Jxe+ruJVhZn4SLipQb3vmsk8IUoIYxhcKxE6uA== X-Received: by 2002:a05:620a:1388:: with SMTP id k8mr11659706qki.152.1630950686595; Mon, 06 Sep 2021 10:51:26 -0700 (PDT) Received: from hurd (dsl-10-132-185.b2b2c.ca. [72.10.132.185]) by smtp.gmail.com with ESMTPSA id t26sm6630207qkm.0.2021.09.06.10.51.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Sep 2021 10:51:26 -0700 (PDT) From: Maxim Cournoyer References: <87k0oa4o7h.fsf@yoctocell.xyz> <871r9kl1tr.fsf@yoctocell.xyz> <87pmukuhsf.fsf@systemreboot.net> <87v93d24tx.fsf@yoctocell.xyz> Date: Mon, 06 Sep 2021 13:51:24 -0400 In-Reply-To: <87v93d24tx.fsf@yoctocell.xyz> (Xinglu Chen's message of "Mon, 06 Sep 2021 15:47:54 +0200") Message-ID: <8735qhbnj7.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630950747; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=S9I2G2u4/Vu3JZydy2l3TC5zjFpqDgyelLr55i6qr7M=; b=lRzHJNCnvJROEH5KeDsovHZEvklSF6Ccfg0pz21mSfO9ay+hh6QGKr9LHW9GE93EQGaSuA o/aCCbD7QdrbVkDrJ54/HfUWCKxzwDIgcjWllzkm/WgauRZKuY8tXvuCmt+XBLmrHzpMSA lGBsMZWk7BOXaejgxVxdJ6eNUNsSUk+6o3Xv4lfgyZ843Q+UJ2uGh7M+QBFIVHXtt6+UDZ SPTufPfkW9gB1aYwX+yJrdlz2Uf7Q0DVqklXiCzB3KviPoY6R/Xl1pxBmTW38IldSwpPVt /fNXDRKfUl//vcGAWbbOnTHBuUHQuu1LiPbe4NObAGQXiBLN54S5RJgw2kAQ7w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630950747; a=rsa-sha256; cv=none; b=RAAuFSTMUbuXXFU/pcd6Z32M0ZJ97Oo67HVM5Int8Epa1SFRNAxKmaMtAc72Hh0FDUrWui aNcOJ3+5V9lUQJyQihuAUJKOjTfG/kqFft50EdyzvxxEVukgQIaNEdaYaS/Y0Inu9NZfeT Tt5ywEjLAFej8b6+/wOUQjRmpW9WIqzrRv/3dLaZnDVO33CsNfAfR4F/LdFKlABN0XNeih 2zcVm0HcHBykC0Sgu2skZWSU+D9TVwhvWxDqUQvRq8COrjayIUj2lFv6eBbym3NW+p3tny Wb0hLLpYOLdPcHawzMJJeAB1zCI+VFevXbKyUwttkHp5pp/pad+GFn4pUKWk7Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=b+VOax+z; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=b+VOax+z; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 0EB53159B2 X-Spam-Score: -1.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: 4nxkJnc2DTzY Hello Arun, Xinglu Chen writes: > On Wed, Aug 11 2021, Arun Isaac wrote: > >> Hi all, >> >> I actually think we should not add emacs-vertico to the >> propagated-inputs, and remove emacs-flycheck and emacs-selectrum as >> well. All these are optional dependencies, and we should leave it to the >> user to install the ones they want. At least in this specific case, the >> three packages (flycheck, selectrum and vertico) are the kind the user >> would want to explicitly install. They aren't backend libraries that >> ought to remain invisible to the user. >> >> In fact, this is the version of emacs-consult I have installed in my >> profile. Guix packages typically come as featureful as possible unless there are good reasons not too (to minimize the closure size, for example). In this case, the added optional dependencies seem to have negligible effect on the closure size, according to `guix size`; I'd be in favor to keep the optional dependencies specified for that reason, unless there are other considerations that I'm missing. > Another option would be to define package variants of =E2=80=98emacs-cons= ult=E2=80=99, > that way we would have four packages: > > * emacs-consult; > * emacs-consult-flycheck; > * emacs-consult-vertico; and > * emacs-consult. I would prefer not go that route (variants multiplication), especially when the user already has a way to customize. My 2 cents, Maxim