From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id aJMNBmt4P2EcfQAAgWs5BA (envelope-from ) for ; Mon, 13 Sep 2021 18:12:27 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id GOmOAWt4P2FYXgAAbx9fmQ (envelope-from ) for ; Mon, 13 Sep 2021 16:12:27 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BEBB62B8D for ; Mon, 13 Sep 2021 18:12:26 +0200 (CEST) Received: from localhost ([::1]:55792 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mPoZF-0001Z3-SL for larch@yhetil.org; Mon, 13 Sep 2021 12:12:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59636) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPoV1-0003eV-6M for guix-patches@gnu.org; Mon, 13 Sep 2021 12:08:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35152) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mPoV0-0005Ss-VR for guix-patches@gnu.org; Mon, 13 Sep 2021 12:08:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mPoV0-0002nF-R5 for guix-patches@gnu.org; Mon, 13 Sep 2021 12:08:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49606] [PATCH wip-haskell v2] gnu: Add ghc-8.10. Resent-From: Xinglu Chen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 13 Sep 2021 16:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49606 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Lars-Dominik Braun Cc: 49606@debbugs.gnu.org, Ricardo Wurmus , Sarah Morgensen , John Kehayias Received: via spool by 49606-submit@debbugs.gnu.org id=B49606.163154927810720 (code B ref 49606); Mon, 13 Sep 2021 16:08:02 +0000 Received: (at 49606) by debbugs.gnu.org; 13 Sep 2021 16:07:58 +0000 Received: from localhost ([127.0.0.1]:46698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mPoUs-0002mn-IR for submit@debbugs.gnu.org; Mon, 13 Sep 2021 12:07:58 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:52310 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mPoUh-0002mM-Rb for 49606@debbugs.gnu.org; Mon, 13 Sep 2021 12:07:53 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1631549253; bh=L7TtHkrB2lzOMnspvXPTY16NT0rC0IziFVETzLzmbQo=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=blF3U3ymq+WMuNtaLGtelgrnfJjqYZTZbQZUJdpvB+mQhE7PBcN31hN8AIbHjRbWL R/bB4Y5BTHVb80SNkp7zIaHfPGqDjk2l/ue/ekNeVpc0Zo8bLEyOUOEl7AsdbwW4rk RBN9yhy2dR1dWqGwEDy1gD8YNfksKnclhE6EpZFs= In-Reply-To: References: <039023c844a5fa57c050bab868677dabd08b1bb0.1626535972.git.public@yoctocell.xyz> <50732186fb1a7b17d2d44d172957ba145607debf.1627682631.git.public@yoctocell.xyz> <875ywbhspt.fsf@yoctocell.xyz> Date: Mon, 13 Sep 2021 18:07:26 +0200 Message-ID: <8735q8v4qp.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1631549546; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=oIeDZF5ndv4rz38ch3YXKJNJXDqFz0meBqsYlSfgBo8=; b=pUZv2n7gtwIUjmQfQCV7LKWCv29imVwNgR70ksghmgmpyJe+xS5AEwOGsm+b6xBndE0o2c qZQwY2qWeMO9d7NjJu6Esx3X1S4M4TGe95wcEIL1m1iGhhIzt4xDRnDancevKV337igMmZ 7vfX34wYWf7B8p7fWCBRxOVPD3lfbznM3r3NvSrYOYjvfriJWlLD9HyDI0pshWEIZGuzo+ EXs/G3qMCHVHK0kakJOJG6L32wGj5JGz7BDqodCbs/633R/w8/3qNJ1L9DcZtw6YiIBkfW 1KjCcmsU9AGU1TgiAIApdjRsu0OxvwL1kR1+GC/soU8pfg1tZL++7OJVe1iREQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1631549546; a=rsa-sha256; cv=none; b=TkpBXJ+Om7XV2YpgoI4qxtTpxn06qxQZQ7hIGxQkIWolIaiCUWbjOHoeV+h1IYeLve3tJr ji78LLezzcFaoPkYl3in4JfBEvzhkaNfR8BPdtMw/4F0+gWWWg79/FSMnOJqbwZ4vj1qyu 5NTYcCmguSE5/up8KZtCJx4t0yoB+91IhEsRYumMPHJKsOg7uWZ8/oIwoOB37/G2xc6o4I a8wYaEERL/AxYwGxIG8fFFZIIAbyNPa+S+ez7UVSEOKb+qDW/MIzcmUzDlcEq6Z7CukT9e SG1WsQ3ef6YxddFrTqPdNzvWQJ3Ry7cXSXszoScsbW3Oe4qQVh81zVezI7+ang== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=blF3U3ym; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 1.40 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=blF3U3ym; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: BEBB62B8D X-Spam-Score: 1.40 X-Migadu-Scanner: scn0.migadu.com X-TUID: WYeSBkgmsMqu --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Mon, Sep 13 2021, Lars-Dominik Braun wrote: > Hi, > >> Any comments/thoughts on this, anyone? > I looked at the patch and would like to propose minor modifications. In > particular I > > - removed the 'fix-cc-name phase, which is inherited from ghc-8.8 anyway Aye, the patch has bitrotted a bit. > - converted the failing test (which I can=E2=80=99t get to pass either) i= nto > an expected failure instead of nulling it out and Either way works for me. :-) > - renamed the package to ghc-next, which should avoid > https://issues.guix.gnu.org/47335 =E2=80=93 if we also rename GHC 8.8 i= n a > different patch. AFAIK, =E2=80=98-next=E2=80=99 packages are usually unstable versions of th= e regular version, e.g., =E2=80=98emacs-next=E2=80=99 and =E2=80=98guile-next=E2=80= =99. =E2=80=98ghc-8.10=E2=80=99 is a stable release, so I am not sure if the =E2=80=98-next=E2=80=99 prefix is appropri= ate. Also, I would imagine that other language ecosystems also have to problem of the default compiler not being the latest version, e.g., the =E2=80=98rust=E2=80=99 package points to rust-1.45, but rust-1.52 is the la= test available version. > I think we can merge this patch to master, since it only adds a new GHC > version and has no further implications. Thoughts? Originally, the plan was to apply this patch to the =E2=80=98wip-haskell=E2= =80=99 branch, which contained a patch that results in rebuilding all Haskell pacakges, and then update our Stackage LTS version (which hasn=E2=80=99t be= en updated for ~2 years)[1]. But seeing as there isn=E2=80=99t much interest = in a Haskell update, applying to =E2=80=98master=E2=80=99 seems like a better id= ea. [1]: > diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm > index 3d10bdc946..ca0498e6d9 100644 > --- a/gnu/packages/haskell.scm > +++ b/gnu/packages/haskell.scm > @@ -21,6 +21,7 @@ > ;;; Copyright =C2=A9 2019 Jacob MacDonald > ;;; Copyright =C2=A9 2020 Marius Bakke > ;;; Copyright =C2=A9 2021 Matthew James Kraai > +;;; Copyright =C2=A9 2021 Xinglu Chen > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -663,6 +664,60 @@ interactive environment for the functional language = Haskell.") > (file-pattern ".*\\.conf\\.d$") > (file-type 'directory)))))) >=20=20 > +(define-public ghc-8.10 > + (package > + (inherit ghc-8.8) > + (name "ghc-next") > + (version "8.10.7") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://www.haskell.org/ghc/dist/" > + version "/ghc-" version "-src.tar.xz")) > + (sha256 > + (base32 "179ws2q0dinl1a39wm9j37xzwm84zfz3c5543vz8v479khigdvp3"))= )) > + (native-inputs > + `(("ghc-bootstrap" ,ghc-8.8) > + ("ghc-testsuite" > + ,(origin > + (method url-fetch) > + (uri (string-append > + "https://www.haskell.org/ghc/dist/" > + version "/ghc-" version "-testsuite.tar.xz")) > + (patches (search-patches "ghc-testsuite-dlopen-pie.patch")) > + (sha256 > + (base32 > + "1zl25gg6bpx5601k8h3cqnns1xfc0nqgwnh8jvn2s65ra3f2g1nz")))) > + ("git" ,git-minimal) ; invoked during tests > + ,@(filter (match-lambda > + (("ghc-bootstrap" . _) #f) > + (("ghc-testsuite" . _) #f) > + (_ #t)) > + (package-native-inputs ghc-8.8)))) > + (arguments > + (substitute-keyword-arguments (package-arguments ghc-8.8) > + ((#:phases phases '%standard-phases) > + `(modify-phases ,phases > + (add-after 'unpack-testsuite 'patch-more-shebangs > + (lambda* (#:key inputs #:allow-other-keys) > + (let ((bash (assoc-ref inputs "bash"))) > + (substitute* '("testsuite/tests/driver/T8602/T8602.scri= pt") > + (("/bin/sh") > + (string-append bash "/bin/sh")))))) > + ;; Mark failing tests as broken. Reason for failure is unknow= n. > + (add-after 'skip-more-tests 'skip-even-more-tests > + (lambda _ > + (substitute* '("testsuite/tests/driver/T16521/all.T") > + (("extra_files" all) (string-append "[" all)) > + (("\\]\\), " all) > + (string-append all "expect_broken(0)], "))))))))) > + (native-search-paths (list (search-path-specification > + (variable "GHC_PACKAGE_PATH") > + (files (list > + (string-append "lib/ghc-" versio= n))) > + (file-pattern ".*\\.conf\\.d$") > + (file-type 'directory)))))) > + The updated patch LGTM, and great that you updated it to 8.10.7! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmE/dz4VHHB1YmxpY0B5 b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x57wsP/jZEH9nnDOvC5nOU/rtQiLS0OTdh UpIlFyELfrZaKr3kKyuTIgu8tEbKOG8iSqBiDIMKadyqMP82EtAVE2UFX9GlJUsJ PmnkfwWFa2jJrw5FWwGk6lcVpXMfFcLDsVNL3v3f5yDuErOMasK2upco7O2FxukF 1z3G2fDnQCtbFHJp8n/vesHq1itL4SDWg1so1clUI0X74EH6fAYqzWcM8BClYJR1 ePGKrLETcoVduqtlnCGFp84o6C3CVIhnSOUkdFnoyJye2cn9qWO5BTpZAL3lCA4F Yxlx4E3V+hWK2KMehcKfUpcCq+FYMfrzzxSea01e1H3+hDCdOIP1+onJXrT7WXa4 x3eZcXhOoHUZ9ziYg+FdTU/wG1Xqtb0HAvNuWifMKuHyxwbqiD3Ia4ER9RlCB3LR +DoIXybUmfad9tNhWPXEgOW4kjhBVoznzLPNR1DsTj94W8nKRtTW92mRIHZ4iZnc tdzYpw7DkuUQP1TkRY9OlBgnc+qsmuufC/Iu37Rc94Y9he4SyhgG2uw3mslWNwPg mj5+kPoY6vxF2ljncDdKNyvUgufec2x0WcOx787M/9NbiX1lX3d4pGpiMfECPFMs nJ7mkMWojbWYVnuq4z2R3zoGSAZqlHD97ZyGareENVTE0P3ar+N5f7tkioUgemOQ /TZW69/BsrxwU12x =hU7w -----END PGP SIGNATURE----- --=-=-=--