unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxime Devos <maximedevos@telenet.be>
Cc: vivien kraus <vivien@planete-kraus.eu>, 50451-done@debbugs.gnu.org
Subject: bug#50451: [PATCH] Fix two issues in the minetest importer
Date: Sat, 18 Sep 2021 19:42:34 +0200	[thread overview]
Message-ID: <8735q1u6et.fsf@gnu.org> (raw)
In-Reply-To: <bde55702705876ac90d8646d3945cc498de730af.camel@telenet.be> (Maxime Devos's message of "Tue, 07 Sep 2021 13:36:36 +0200")

Hi,

Maxime Devos <maximedevos@telenet.be> skribis:

> From 2c376bc8fcdc690a8d3b71e818085fa25f547d59 Mon Sep 17 00:00:00 2001
> From: Maxime Devos <maximedevos@telenet.be>
> Date: Tue, 7 Sep 2021 13:03:12 +0200
> Subject: [PATCH 1/3] tests/minetest: Fix 'test-package*' indenting.
>
> * tests/minetest.scm (Local Variables)[test-package*]: Set
>   scheme-indent-function property to 1.

[...]

> From 2855ab8880b9200ec0eb18a9dfb802a516828312 Mon Sep 17 00:00:00 2001
> From: Maxime Devos <maximedevos@telenet.be>
> Date: Tue, 7 Sep 2021 13:05:56 +0200
> Subject: [PATCH 2/3] import/minetest: Delete duplicate dependencies.
>
> This fixes one of the issues noted in <https://issues.guix.gnu.org/50425#4>.
>
> * guix/import/minetest.scm
>   (import-dependencies): Call 'delete-duplicates' on the resulting list.
> * tests/minetest.scm
>   ("minetest->guix-package, multiple dependencies implemented by one mod"):
>   New test.

[...]

> From 91cbb7e68f3df8601fd91a2247ca971f7e011406 Mon Sep 17 00:00:00 2001
> From: Maxime Devos <maximedevos@telenet.be>
> Date: Tue, 7 Sep 2021 13:24:24 +0200
> Subject: [PATCH 3/3] import/minetest: Strip "v" prefixes from the version
>  number.
>
> This fixes one of the issues noted at <https://issues.guix.gnu.org/50425#4>.
>
> * guix/import/minetest.scm
>   (release-version): New procedure.
>   (%minetest->guix-package): Call new procedure instead of release-title.
> * tests/minetest.scm
>   (make-package-sexp): Allow overriding the version number.
>   (make-releases-json): Allow overriding the release title.
>   ("conventional version number")
>   ("v-prefixed version number")
>   ("dates as version number"): New tests.

Applied, thanks!

Ludo’.




      reply	other threads:[~2021-09-18 17:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-07 11:36 [bug#50451] [PATCH] Fix two issues in the minetest importer Maxime Devos
2021-09-18 17:42 ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735q1u6et.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=50451-done@debbugs.gnu.org \
    --cc=maximedevos@telenet.be \
    --cc=vivien@planete-kraus.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).