From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id aAD5AvnOfWF+ogAAgWs5BA (envelope-from ) for ; Sun, 31 Oct 2021 01:02:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id cNlOOvjOfWH2NAAA1q6Kng (envelope-from ) for ; Sat, 30 Oct 2021 23:02:16 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5EAA12197C for ; Sun, 31 Oct 2021 01:02:16 +0200 (CEST) Received: from localhost ([::1]:52444 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mgxMd-0004OS-HO for larch@yhetil.org; Sat, 30 Oct 2021 19:02:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55804) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgxMQ-0004O7-JL for guix-patches@gnu.org; Sat, 30 Oct 2021 19:02:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47045) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mgxMP-000155-Pc for guix-patches@gnu.org; Sat, 30 Oct 2021 19:02:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mgxMP-0005CU-Jr for guix-patches@gnu.org; Sat, 30 Oct 2021 19:02:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50873] [PATCH 0/5] Fixes to =?UTF-8?Q?=E2=80=98guix?= home =?UTF-8?Q?import=E2=80=99?= Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 30 Oct 2021 23:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50873 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Xinglu Chen Cc: Oleg Pykhalov , 50873@debbugs.gnu.org, Andrew Tropin Received: via spool by 50873-submit@debbugs.gnu.org id=B50873.163563490219947 (code B ref 50873); Sat, 30 Oct 2021 23:02:01 +0000 Received: (at 50873) by debbugs.gnu.org; 30 Oct 2021 23:01:42 +0000 Received: from localhost ([127.0.0.1]:58587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgxM5-0005Bf-JO for submit@debbugs.gnu.org; Sat, 30 Oct 2021 19:01:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgxM4-0005BS-3K for 50873@debbugs.gnu.org; Sat, 30 Oct 2021 19:01:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35580) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgxLx-0000z1-Ti; Sat, 30 Oct 2021 19:01:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=YlmlfY5zMivbgjEQoQlvmIM+4725nWKDZ/uuYPWLR8c=; b=AO8bLYvOzeHJZSr33rN6 J7h8cVUK0OjcSofyei6Kva+yS3WBitaxy1pPlBLOjcjkPYRTiv8u9Cqa0GSkyLQqK+3nC4rzAdgMm 6j24kdgP8qSwVz6WzxtXJ7IndnmFhVZPokNzhgz74lZqXMHVGvTGAu+/W/ms1RCnyCcJyvx2TAUcf v1KtUShz3Z1F8C9pFvAYpmDvNvQM3pQ+RIW2lY1YkYo4MUsIzzDmoSG1TLLnEs7ZuurXaRf9SXxdC zlAW2mQYlOvsUk5FhagpVkk9z8Tb3DDOG2RpHgXMDhMWtWgjD9vr6o6Vdd7xYriLxwYALuLTp7hlM ULUjP5RD1Y8WZw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:55500 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgxLx-0001qN-Hj; Sat, 30 Oct 2021 19:01:33 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Sun, 31 Oct 2021 01:01:30 +0200 In-Reply-To: (Xinglu Chen's message of "Sat, 30 Oct 2021 12:42:21 +0200") Message-ID: <8735oirub9.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1635634936; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=YlmlfY5zMivbgjEQoQlvmIM+4725nWKDZ/uuYPWLR8c=; b=BvFQ+zEIHd+x/lPKR26yeX2863WJP0Tw2Lmk4MvhtoCES6xL9MGZQcsmkyeN3Ob9xBiaz1 uMZYkmse7AfL/2sM+3wVDvwZVraZkB+qnqANjFZHUYg4LRGcdAdeXo5bnaW0ZlHgEelQcS mn1sHb3up1SrUMl0s6YXQF2U5u82iE4/VreghLAuV0hgcql+6Q22e/Fq0fnZb9cLxvCPhC dNG18ODty/CsmYIph8ozxSzXEsOl7rG2Hwfm8ywM4z2MM6bcOi5C8Cvyy28I1cd6mBiRXS dCP1h88/VNmTYRGOivW46f5dsC0FIsWWb0rP0ZHEXFwd7eLrV9WgtUWihu1PAw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1635634936; a=rsa-sha256; cv=none; b=c3HPR+HFuZWIUGP0wXAgWR3plzKPm1g+wW+vjRaAhorh9Py+Xh50fUEGz2nplLCrDWm8DK MWqGgGSeMz7GlS5x17Qgm2+LXMV04YAIMTFBxx1ZGcqwFQZBkg6V8fFD3ZM4TgYp5W/2/k KkBz8oPKugQiQcKc5Of/vKuRVDyagXq6ajlpkkvf8KwozfOO4dNddD8HeB/JUGEJuY7I8n E1G/MbaW8Wen/lnpNVAyAjiRQbs67/nauQrqh4musaDDJ3dazLzQvlCLnX7d7pZHPbP0mh AXDK76CkSjX6LMxRSL/GifgQexuZJZ8XJAHHTpPyRl7fy5LRA/2pvDwYsCvvKA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=AO8bLYvO; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.42 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=AO8bLYvO; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 5EAA12197C X-Spam-Score: -1.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: ASrZFjN2BpBw Hi! Xinglu Chen skribis: > guix home: import: Make the user to specify a destination directory. > guix home: import: Allow multiple modules to be imported for each > service. > guix home: import: Fix module name for Bash service. > guix home: import: Don=E2=80=99t use 'slurp-file-gexp'. > guix home: import: Delete duplicate modules when importing. > doc: Document the =E2=80=98guix home import=E2=80=99 subcommand. > Add tests for =E2=80=98guix home import=E2=80=99. > guix home: import: Call =E2=80=98local-file=E2=80=99 with =E2=80=98name= =E2=80=99 argument. That=E2=80=99s a nice improvement. In the interest of moving forward, I ap= plied the whole series and followed up with a few changes: c4ac8cf4f6 doc: Mention 'guix home reconfigure' upfront. 971a69d8e3 doc: Avoid misuse of @ref. 7711a6c3f4 doc: Mention "guix home import" upfront. 6f4ca78761 home: import: Avoid duplication of 'manifest->code'. 96728c54df home: import: Factorize triplicated 'version-spec' procedure. f3933ae40d home: import: Clarify "destination directory". 341fba217f home: import: Compare procedures with 'eq?'. Part of it is about removing duplicated code, in particular =E2=80=98manifest->code=E2=80=99. It=E2=80=99s important to factorize non-= trivial code like this. The last commits improve documentation so users learn about =E2=80=98guix h= ome import=E2=80=99 when they get started. It=E2=80=99s really nice to have this tool! I find it perhaps a bit confus= ing to have to specify a target directory to =E2=80=98guix home import=E2=80=99= ; simply trying to document it shows that it=E2=80=99s non-obvious. I wonder if the argument should be optional (in which case the files wouldn=E2=80=99t be copied). But then people are likely to run into the problems this addresses. Or perhaps it would be more consistent to have: guix home import ~/foo create ~/foo/config.scm, instead of printing it to stdout? The documentation would be clearer: =E2=80=9Cpopulate ~/foo with all the configuration files of your home environment.=E2=80=9D Thoughts? Ludo=E2=80=99.