From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8B8fJiRMhmES8gAAgWs5BA (envelope-from ) for ; Sat, 06 Nov 2021 10:34:28 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id MJ6/ISRMhmEbZQAAbx9fmQ (envelope-from ) for ; Sat, 06 Nov 2021 09:34:28 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 58CDE271FE for ; Sat, 6 Nov 2021 10:34:28 +0100 (CET) Received: from localhost ([::1]:60046 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mjI5j-00005Z-8h for larch@yhetil.org; Sat, 06 Nov 2021 05:34:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43976) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjI5K-00005G-P3 for guix-patches@gnu.org; Sat, 06 Nov 2021 05:34:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36875) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mjI5K-0003rM-GJ for guix-patches@gnu.org; Sat, 06 Nov 2021 05:34:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mjI5K-0004bw-76 for guix-patches@gnu.org; Sat, 06 Nov 2021 05:34:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#45130] [PATCH] gnu: Add mtm. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 06 Nov 2021 09:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45130 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 45130@debbugs.gnu.org Cc: phodina@protonmail.com X-Debbugs-Original-To: phodina via Guix-patches via X-Debbugs-Original-Cc: "45130@debbugs.gnu.org" <45130@debbugs.gnu.org>, phodina Received: via spool by submit@debbugs.gnu.org id=B.163619121817693 (code B ref -1); Sat, 06 Nov 2021 09:34:02 +0000 Received: (at submit) by debbugs.gnu.org; 6 Nov 2021 09:33:38 +0000 Received: from localhost ([127.0.0.1]:48421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjI4w-0004bI-Do for submit@debbugs.gnu.org; Sat, 06 Nov 2021 05:33:38 -0400 Received: from lists.gnu.org ([209.51.188.17]:33472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjI4r-0004b7-MK for submit@debbugs.gnu.org; Sat, 06 Nov 2021 05:33:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43730) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjI4r-0008WL-HJ for guix-patches@gnu.org; Sat, 06 Nov 2021 05:33:33 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:37401) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjI4p-0002eg-DE for guix-patches@gnu.org; Sat, 06 Nov 2021 05:33:33 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id C2957C0002; Sat, 6 Nov 2021 09:33:24 +0000 (UTC) From: Nicolas Goaziou References: Date: Sat, 06 Nov 2021 10:33:17 +0100 In-Reply-To: (phodina via Guix-patches via's message of "Wed, 03 Nov 2021 14:53:00 +0000") Message-ID: <8735o9r5lu.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.198; envelope-from=mail@nicolasgoaziou.fr; helo=relay6-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1636191268; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=0BrefXW+n1guLFjtf8wkBuet16qKUr1pinAz44Fb/Xw=; b=dQwaiEUoEmWnw+FCr1xOWA+ScPEhqCY1zjjqVpM/jiwA6G7NZznM0LfQ5krUFd6v6wf83N ZzXkVCVi+OEEnV4ifEzKoBPTSmiIQ3Emx7A6uVJWzBm+QpKFjOhL6xY/bWPin910LV+D71 KFnyJftEDwy/7WWm2+8EZg32XD8lljsEIkzk4PzZvw9QIUoenM7FZXFQmViLQGUCNbJCq4 O0I/NgmLr7/cqiTxEyGWNLcPhwrbRNzrCQmCpMLo6Ze0HCT+MWgorZzrlgTvQGQQGw92vd hybpdpVMD6OBfHQ3Ftb/STjTQWm0a1q3ZEOM9NKqCTVIO+fgIcYgXbeeWzBU0g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1636191268; a=rsa-sha256; cv=none; b=Vlx1KID+J3podrCTGd3jvvwJo9aCagYtqi7iiX2O0iu5J1ry4KX58KVL4852G9c7fa3t3K jj8MUEpG84aUTBr9GUK3SUQbx7u5rdoAGUWFUhRzcXgHBSk91J+nRaYWqohgrGUf4v0d6V gSzZvYNLrWsvpT7XPwbh14S7Gz2zmyqxo/A0xbi9jW+uanC8Or/DAB2FaBR2xUgMA0eW/v A6mpRSYmfr2ks+Vf7Zm/nchVIBQXX5Av0o2UZzC31nHmJkNuQcdCNrr909ksAQhLjjb6+J d09g6hF4IgeX9kQmBj0m64H4FHQdFuFmPC+oxip8SosWZDYojeFZrWlADLzCpg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.42 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 58CDE271FE X-Spam-Score: -2.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: lIhNbYbHdSqP Hello, phodina via Guix-patches via writes: > here's updated version of the patch where the version uses newest tag > instead of commit. Otherwise LGTM. Is there any reason to put the variable in suckless.scm? > + (replace 'install > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out"))) > + ;; install binary > + (mkdir-p (string-append out "bin/")) > + (install-file "mtm" (string-append out "/bin")) > + ;; install manpage > + (mkdir-p (string-append out "share/man/man1")) > + (install-file "mtm.1" (string-append out "/share/man/man1")) > + ;; install terminfo > + (mkdir-p (string-append out "share/terminfo")) > + (invoke (string-append (assoc-ref inputs "ncurses") "/bin/tic") > + "-x" "-s" "-o" > + (string-append > + out "/share/terminfo") > + "mtm.ti")) > + #t)) We can remove the trailing #t. > + (delete 'configure)))) There's probably a missing comment "no configure script" > + ;; FIXME: This should only be located in 'ncurses'. Nonetheless it is > + ;; provided for usability reasons. See . > + (native-search-paths > + (list (search-path-specification > + (variable "TERMINFO_DIRS") > + (files '("share/terminfo"))))) > + (synopsis "Micro Terminal Multiplexer") > + (description > + "This package provides multiplexer for the terminal focused on simplicity, > +compatibility, size and stability.") > + (license license:gpl3+) > + (home-page "https://github.com/deadpixi/mtm"))) Nitpick: the home-page field is usually above the synopsis. Regards, -- Nicolas Goaziou