From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id GLGjBhqTmmG08AAAgWs5BA (envelope-from ) for ; Sun, 21 Nov 2021 19:42:34 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id WLdXAhqTmmGkNgAAB5/wlQ (envelope-from ) for ; Sun, 21 Nov 2021 18:42:34 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D4ACD30CE5 for ; Sun, 21 Nov 2021 19:42:33 +0100 (CET) Received: from localhost ([::1]:49714 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mornM-0000t1-74 for larch@yhetil.org; Sun, 21 Nov 2021 13:42:32 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46168) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1morms-0000rH-Rj for guix-patches@gnu.org; Sun, 21 Nov 2021 13:42:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34477) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1morms-0004ns-Ic for guix-patches@gnu.org; Sun, 21 Nov 2021 13:42:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1morms-0003Pj-G4 for guix-patches@gnu.org; Sun, 21 Nov 2021 13:42:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51755] [PATCH 1/1] gnu: proof-general: Adjust autoloads for Emacs. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 21 Nov 2021 18:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51755 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun Cc: 51755@debbugs.gnu.org Received: via spool by 51755-submit@debbugs.gnu.org id=B51755.163752007013011 (code B ref 51755); Sun, 21 Nov 2021 18:42:02 +0000 Received: (at 51755) by debbugs.gnu.org; 21 Nov 2021 18:41:10 +0000 Received: from localhost ([127.0.0.1]:46006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1morm2-0003Nl-0P for submit@debbugs.gnu.org; Sun, 21 Nov 2021 13:41:10 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:51919) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1morlw-0003N5-9y for 51755@debbugs.gnu.org; Sun, 21 Nov 2021 13:41:08 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 8C8ABE0003; Sun, 21 Nov 2021 18:40:57 +0000 (UTC) From: Nicolas Goaziou References: <20211110192622.368232-1-zimon.toutoune@gmail.com> <20211110193748.368696-1-zimon.toutoune@gmail.com> Date: Sun, 21 Nov 2021 19:40:56 +0100 In-Reply-To: <20211110193748.368696-1-zimon.toutoune@gmail.com> (zimoun's message of "Wed, 10 Nov 2021 20:37:48 +0100") Message-ID: <8735npwdvr.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637520153; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=+10FvtM/tr1rM4mWa+DfUy4bH+8gYIfG/e8cPxxcPM4=; b=G81cO5jWQs0IdytFuVzLxNGLqYJf+XFgFKh/101V4aUN9XmIkqHolMsLuiTZoUqit89Ahl hjVHgjwLYKe+xy6tTx5DeBqbUb8JqymsNEh/Fv7DVvd3UbBwaohDMZhmVv+3nMvYYTEanA Ur6kOfYsIbsAkVV3fUMfn2AAp3q1qwei3GzAbKUp44h+Q7rsLX+M9bbmukWRXjH7YtsN3n b46e/spLri7w2BEAjNPgy54iD92JXCWrgclaCJElQ3m0lDixGSj9Obfb0KsdB7kpkLdpBb JnPCxirZqyBztQMBF3IGAacxSGplyBYq7hfBfsOlzSrdGEG7X9OhZtgRLslo3Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637520153; a=rsa-sha256; cv=none; b=mhkxbRmldAiDjeX26EYauDoUuX+qc0YCBG5Q9C+OZEEKqWBOWgy9fDHFkZcbX9BbiziRiG evgmjirLcBCLZl6qQo2ww45RqW7TNBKQm91DRmEPlQHuW6t/D2a4t1FfaaqPHEeypdXlRL UfISihyHKeVY7P+St0akxgjf5IhCD8XLI2O0jzA368FsePPkxSAYYQUXQ+0K8LldY2aMez fhwj0Ghlf2INBbFFeTjFygsuz0L9ZS3pouYamwhgTYpxuBU7JKddvYgqCyHsh4w0QbrR08 uPLKpPxI73UfvsmaHISNIWVjcAvp4S4iFXkU2ubE3kmd2MzDR/SKJRbj/p4B2w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.98 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D4ACD30CE5 X-Spam-Score: -2.98 X-Migadu-Scanner: scn0.migadu.com X-TUID: VB6ztEFezs5b Hello, zimoun writes: > * gnu/packages/coq.scm (proof-general)[native-inputs]: Remove 'which'. > [inputs]: Remove 'coq' and 'emacs'. > [arguments]<#:make-flags>: Adjust to find 'emacs'. > Set 'ELISP' and 'DEST_LISP'. > <#:modules, #:imported-modules>: Remove. > <#:phases>: Remove call to 'which' in Makefile. > Add copy file allowing Emacs autoloads. > Clean unnecessary code. Thanks. > + (add-after 'install 'allow-subfolders-autoloads > + (lambda* (#:key outputs #:allow-other-keys) > + (let ((out (assoc-ref outputs "out"))) > + ;; Make it visible by Emacs > + (copy-file "proof-general.el" > + (string-append out ,base-directory > + "/proof-general-autoloads.el"))))))))) So, IIUC, the above is basically a hack: you disguise the main file into an autoloads file because no autoloads file is generated from the code base? If so, this might deserve a longer comment, IMO. Otherwise, LGTM. Regards, -- Nicolas Goaziou