unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: raingloom <raingloom@riseup.net>
Cc: pukkamustard <pukkamustard@posteo.net>, 51565@debbugs.gnu.org
Subject: [bug#51565] PATCH: Update Yggdrasil to new protocol (important breaking changes)
Date: Thu, 02 Dec 2021 10:15:56 +0100	[thread overview]
Message-ID: <8735nbxt83.fsf@gnu.org> (raw)
In-Reply-To: <20211201170310.00164259@riseup.net> (raingloom@riseup.net's message of "Wed, 1 Dec 2021 17:03:10 +0100")

Hi,

raingloom <raingloom@riseup.net> skribis:

>> > -(define-public go-github-com-cheggaaa-pb
>> > +(define-public go-github-com-cheggaaa-pb-v3
>> >    (package
>> > -    (name "go-github-com-cheggaaa-pb")
>> > +    (name "go-github-com-cheggaaa-pb-v3")  
>> 
>> Why rename?  If we do need to rename, let’s add a ‘deprecated-package’
>> definition to allow users to notice and get a smooth upgrade.
>
> Without a rename guix import go gets confused and imports it again
> under that name.

Ah that makes sense; would be worth adding a comment above.

> It didn't seem like anything was using it so I went with a rename, but
> I guess someone's channel might be depending on it.  (although I doubt
> it) What would proper deprecation look like? Just inheriting from the
> new package, changing the name field, and marking it as deprecated?

Yes, you can grep for ‘deprecated-package’ in gnu/packages/*.scm.

Thanks,
Ludo’.




  reply	other threads:[~2021-12-02  9:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-02  6:59 [bug#51565] PATCH: Update Yggdrasil to new protocol (important breaking changes) raingloom
2021-11-15 14:10 ` pukkamustard
2021-11-22 21:13   ` raingloom
2021-11-28 20:47     ` raingloom
2021-12-01 15:27     ` Ludovic Courtès
2021-12-01 16:03       ` raingloom
2021-12-02  9:15         ` Ludovic Courtès [this message]
2021-12-01 16:04 ` bug#51565: " Ricardo Wurmus
2021-12-02  9:16   ` [bug#51565] " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735nbxt83.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=51565@debbugs.gnu.org \
    --cc=pukkamustard@posteo.net \
    --cc=raingloom@riseup.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).