From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id mMbWEA41qWHrPgEAgWs5BA (envelope-from ) for ; Thu, 02 Dec 2021 22:05:18 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 8HZuDA41qWEvdwAAbx9fmQ (envelope-from ) for ; Thu, 02 Dec 2021 21:05:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 088EB282AC for ; Thu, 2 Dec 2021 22:05:18 +0100 (CET) Received: from localhost ([::1]:44820 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mstGW-00016E-KZ for larch@yhetil.org; Thu, 02 Dec 2021 16:05:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48092) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mstGI-000160-BL for guix-patches@gnu.org; Thu, 02 Dec 2021 16:05:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37897) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mstGI-0008EB-3Z for guix-patches@gnu.org; Thu, 02 Dec 2021 16:05:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mstGH-0003nh-S8 for guix-patches@gnu.org; Thu, 02 Dec 2021 16:05:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52189] [PATCH] gnu: Add notcurses Resent-From: Blake Shaw Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 02 Dec 2021 21:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52189 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: 52189@debbugs.gnu.org Received: via spool by 52189-submit@debbugs.gnu.org id=B52189.163847908414584 (code B ref 52189); Thu, 02 Dec 2021 21:05:01 +0000 Received: (at 52189) by debbugs.gnu.org; 2 Dec 2021 21:04:44 +0000 Received: from localhost ([127.0.0.1]:49443 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mstG0-0003n9-DP for submit@debbugs.gnu.org; Thu, 02 Dec 2021 16:04:44 -0500 Received: from out2.migadu.com ([188.165.223.204]:55621) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mstFw-0003mw-Ce for 52189@debbugs.gnu.org; Thu, 02 Dec 2021 16:04:43 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nonconstructivism.com; s=key1; t=1638479078; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gD/i/qUcbmAv8k2FKN2TvTXRRBQdbN7u7z8tuRQARQo=; b=FYN0NNC04rtPUwTlBNMeKetRt3qkHM2IMmg9JyDd0MQO1FPkOT+gUerSUG/ABq9ui8Asss 1pVj7gAtCX7Tsa5UvxLc+ovlIrhCKq+gF/ioiyGXFKO9RsbRiSXY2kw0YWZv+JLc4yITvF j2WOwqpmRKTw2q4WRR5Xt1mQoTjn+A0= References: <6a6031ead6f9f61bc8eed976374638089efdaf3f.1638231894.git.blake@nonconstructivism.com> <87r1awxqkc.fsf@nicolasgoaziou.fr> Date: Fri, 03 Dec 2021 04:04:15 +0700 In-Reply-To: <87r1awxqkc.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Wed, 01 Dec 2021 17:01:07 +0100") Message-ID: <8735naafcg.fsf@nonconstructivism.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Blake Shaw X-ACL-Warn: , Blake Shaw via Guix-patches From: Blake Shaw via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1638479118; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=gD/i/qUcbmAv8k2FKN2TvTXRRBQdbN7u7z8tuRQARQo=; b=GeIj/auyRj54Mjs5ufs1y0iEkBAkVXPv+fAUuff6bxDs2bKoSAss4siPevGsf7rU4NHMbS MDRqZNPOMo2JrzGvzr5yIgKkhjn17/sdUHSW9CRlZD6vNbM1sZxT/2u6tzCiDpE5PSy4RL 6/+/x8TJQLw5+2PWA5je/U2i1XLuHvzKvjCWX0cjoqtvvdYnQCKzOsQRNKa9CRNEKVGiHr D3IJjd4dcrnQfmg6A3CaAlQ2oFxt14bkpKUe6U4JnXhDDArBt+HH6YtyEb+JKGCrAuKBNJ CLBgveVaBhZzdC1QC8Os5K7VLjQQZOnbi4/P5ALVD4iVHhy8eC24pBGCeaEy4w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1638479118; a=rsa-sha256; cv=none; b=M5wT5G8xGAGDRiyukMqOzETNjsy1W0/l23zBkWc3Ye5j5U9ayzWikaRVtwNxeUREsdIdmH lVl2KYXNMfUxzX0bvEkrm+7BfnKL8wgXX1Q+3d/e2mcGySfozZh07SzgFzQ6qcT+/9d3kV 9gHIixe7z69cREDht7bzqbGUm/Yo4aJq7nJCaVo7IR8tOBSDaWtD0F+NrUwAtoX55TLSM9 Zw6Uhh5M/gbYS5Y2ff65IqIu4Z8VOtPPXRTZVXhDLQ29puHsfrvcef0/VKzw5vrElphSSl Ks32lRGBAwD15V97cSkhtydU1A3j7ogZJv9ZbMsfvZhoGPIf9+UbvfiqW8G8Zg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=nonconstructivism.com header.s=key1 header.b=FYN0NNC0; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.42 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=nonconstructivism.com header.s=key1 header.b=FYN0NNC0; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 088EB282AC X-Spam-Score: -3.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: kt+pFc/aMtsI Hi Nicolas, Thanks for the review. > I don't think we should create a new file just for this package. Also, > new files need to be registered in "gnu/local.mk". > Maybe this should go into... "ncurses.scm" (!). At a later time, we may > rename ncurse.scm into tui.scm or some such. When I asked about where it should go in the IRC, specifically inquiring if it should be placed with ncurses, said that it shouldn't go with Ncurses and it should be placed in its own file [1]. Are we now sure that the opposite is the case? noted re: `gnu/local.mk` for the future= .=20 > Upstream use tags. It might be more readable. You'll need a variable for > the code name, tho. In any case, a comment is warranted explaining the > situation. > Nitpick: string should go on the same line as base32. Noted. > The build-type value above is suspicious. It is recommended to set this value in `INSTALL.md`. What about it is suspi= cious? > This is not cross-compilation friendly. Noted. I'll change it and try running it on other architectures using QEMU, I had tried without success before; hopefully that will get it building faithfully across platforms :) > Is the phase above required for tests? If so, could you add a comment > about it? The configure flags are set to build a slimmed down version of Notcurses; it shaves about 80mb off. I had hoped to make different outputs with different options, but when I asked about it in IRC I didn't get a response, and couldn't find any package that is configurable based on outputs to reference. I just checked and the phase configuration can go entirely actually, I just checked. But the build will fail without the configure flags set. But alas, I just found out the 3.0 release was yesterday, which is said to be a big improvement on many levels, so it seems like I should just go ahead and build that one now with your suggestions and introduce the package from this version. This package has been driving me crazy tbh, because it updates nearly everytime I prepare to send it up stream. but I was under the impression the 3.0 wouldn't be ready until maybe 2022.=20=20=20 [1] https://logs.guix.gnu.org/guix/2021-10-24.log#201806 Thanks for the feedback and let me know about the above questions and I'll send the new patch accordingly. Best, Blake --=20 =E2=80=9CIn girum imus nocte et consumimur igni=E2=80=9D