From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id QNGCFgKA8WEyBgAAgWs5BA (envelope-from ) for ; Wed, 26 Jan 2022 18:08:18 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id GM6JDQKA8WEdcwEAG6o9tA (envelope-from ) for ; Wed, 26 Jan 2022 18:08:18 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BAB843FA61 for ; Wed, 26 Jan 2022 18:08:17 +0100 (CET) Received: from localhost ([::1]:37606 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nClmK-0007t9-Rr for larch@yhetil.org; Wed, 26 Jan 2022 12:08:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35836) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nClbS-0004Jl-K1 for guix-patches@gnu.org; Wed, 26 Jan 2022 11:57:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60403) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nClbS-0007Gx-4t for guix-patches@gnu.org; Wed, 26 Jan 2022 11:57:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nClbS-0003FD-5I for guix-patches@gnu.org; Wed, 26 Jan 2022 11:57:02 -0500 Subject: bug#53549: [PATCH] gnu: polkit: Fix CVE-2021-4034. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Wed, 26 Jan 2022 16:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 53549 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch security To: Liliana Marie Prikler Cc: 53549-done@debbugs.gnu.org Mail-Followup-To: 53549@debbugs.gnu.org, ludo@gnu.org, ludo@gnu.org Received: via spool by 53549-done@debbugs.gnu.org id=D53549.164321620912434 (code D ref 53549); Wed, 26 Jan 2022 16:57:01 +0000 Received: (at 53549-done) by debbugs.gnu.org; 26 Jan 2022 16:56:49 +0000 Received: from localhost ([127.0.0.1]:53304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nClbE-0003EU-Od for submit@debbugs.gnu.org; Wed, 26 Jan 2022 11:56:48 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:44478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nClbB-0003EF-Qa for 53549-done@debbugs.gnu.org; Wed, 26 Jan 2022 11:56:47 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 26A30284; Wed, 26 Jan 2022 17:56:39 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id I_0MfUuLM2oH; Wed, 26 Jan 2022 17:56:38 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id F082E9E; Wed, 26 Jan 2022 17:56:37 +0100 (CET) From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20220126115624.31260-1-ludo@gnu.org> Date: Wed, 26 Jan 2022 17:56:37 +0100 In-Reply-To: (Liliana Marie Prikler's message of "Wed, 26 Jan 2022 16:14:48 +0100") Message-ID: <8735lah1ve.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / X-Rspamd-Server: hera X-Rspamd-Queue-Id: 26A30284 X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1643216898; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=LQflLrhntDo7v3Ag8MuVpJTCCVeBDfTwJEHLhTypkf8=; b=TWYhLa23tPZCTxQq9Xbv2FzeK8kftuDS5KQSirxysJyR30hmtH0wom3f2CGmhzR7Xb3ytu e/LB5LnL7k0azFBSGVdAZeAjrrXcaukqhnUSSW/+tdb0jf46TDSPUQL29pQGBWTsGR1Odh oC4QOdUl7OO6LBU0PBig9NO+Oz+vX7uIIp3BD/HVZLn34vt7fEnwwlyph+4kN9G2AQpqAV 4PWPawM6BExlVDp+hNmwXqkl+fpNNbyxcGzttSgvtM5AXpIg9o35AQPgQ7RsqWiExVoUY5 VukGiAOTt+pnboValbFdMQg41fsVLAxHgIhco1YbR/agG0/MN1OK4P7TawXpKw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1643216898; a=rsa-sha256; cv=none; b=GwSvScdLYy3xiJJwzWtGEatbhW6uYiebtwL/GCQBwhaG7BbNY4vT3Rb9lBFrmhxqUZaRgy Hpq4MVraUh2Wtlqm8QO1RPiyvEuLkCLWKnAqy8LcXsoTncGYutu7UyU0X0t3aWNOIfUtBF 7e2tPm0RtsdqCDq4J9tKG0EFbkOq9sZ/ExR/e5/rNO1qBGp3fq6VSHOwhKaGSPwdxd2KpZ Iqx1LWisMIKDVbwzBOn1+vM1cBk3+IwptMA+8D2O7UTOB1D51uVMRJXhovyRxzhVQDEq+P vmKlvBT+G6cwiR7966FAX3ltxIXAUwQFJBmWU8m0wupHprj+7ux2lJAY0B8brQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.93 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: BAB843FA61 X-Spam-Score: -4.93 X-Migadu-Scanner: scn0.migadu.com X-TUID: qWnQmwILKTIz Hi, Liliana Marie Prikler skribis: > Am Mittwoch, dem 26.01.2022 um 12:56 +0100 schrieb Ludovic Court=C3=A8s: >> * gnu/packages/patches/polkit-CVE-2021-4034.patch: New file. >> * gnu/local.mk (dist_patch_DATA): Add it. >> * gnu/packages/polkit.scm (polkit-mozjs)[replacement]: New field. >> * gnu/packages/polkit.scm (polkit-mozjs/fixed): New variable. >> --- >> =C2=A0gnu/local.mk=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2= =A0 1 + >> =C2=A0.../patches/polkit-CVE-2021-4034.patch=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 | 82 >> +++++++++++++++++++ >> =C2=A0gnu/packages/polkit.scm=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 | 13 ++- >> =C2=A03 files changed, 95 insertions(+), 1 deletion(-) >> =C2=A0create mode 100644 gnu/packages/patches/polkit-CVE-2021-4034.patch >>=20 >> Hi! >>=20 >> We could avoid grafting and instead use 'polkit/fixed' in 'setuid- >> programs', but it seems safer and less error-prone to graft. >>=20 >> Thoughts? > Given that there is also a duktape variant, a graft is necessary, no?=20 > On a related note, polit-duktape inherits polkit-mozjs in a way that > does not require adding a separate graft for it, right? Assuming both > of the above hold, LGTM. The duktape variant is defined with =E2=80=98package/inherit=E2=80=99 and t= hus it automatically gets a replacement with the patch: --8<---------------cut here---------------start------------->8--- $ ./pre-inst-env guix build polkit-duktape --no-grafts /gnu/store/z92ymaf84ij8f37cm1wrkkmgrw2slrym-polkit-duktape-0.120 $ ./pre-inst-env guix build polkit-duktape=20 /gnu/store/3g55nhkcbc0a4l7b26gxsalxq0rq1cs7-polkit-duktape-0.121 $ guix gc -R $(./pre-inst-env guix build polkit-duktape -d) |grep polkit-C= VE /gnu/store/lxms944bda56ll590dsrkkhc9n2h3xws-polkit-CVE-2021-4034.patch --8<---------------cut here---------------end--------------->8--- Pushed as 3993d33d1c0129b1ca6f0fd122fe2bbe48e4f093. Thanks for taking a look! Ludo=E2=80=99.