From: "Ludovic Courtès" <ludo@gnu.org>
To: Liliana Marie Prikler <liliana.prikler@ist.tugraz.at>
Cc: 53549-done@debbugs.gnu.org
Subject: bug#53549: [PATCH] gnu: polkit: Fix CVE-2021-4034.
Date: Wed, 26 Jan 2022 17:56:37 +0100 [thread overview]
Message-ID: <8735lah1ve.fsf_-_@gnu.org> (raw)
In-Reply-To: <a5a0a1f49aa4edcae8de8b43789f95937e6c04d8.camel@ist.tugraz.at> (Liliana Marie Prikler's message of "Wed, 26 Jan 2022 16:14:48 +0100")
Hi,
Liliana Marie Prikler <liliana.prikler@ist.tugraz.at> skribis:
> Am Mittwoch, dem 26.01.2022 um 12:56 +0100 schrieb Ludovic Courtès:
>> * gnu/packages/patches/polkit-CVE-2021-4034.patch: New file.
>> * gnu/local.mk (dist_patch_DATA): Add it.
>> * gnu/packages/polkit.scm (polkit-mozjs)[replacement]: New field.
>> * gnu/packages/polkit.scm (polkit-mozjs/fixed): New variable.
>> ---
>> gnu/local.mk | 1 +
>> .../patches/polkit-CVE-2021-4034.patch | 82
>> +++++++++++++++++++
>> gnu/packages/polkit.scm | 13 ++-
>> 3 files changed, 95 insertions(+), 1 deletion(-)
>> create mode 100644 gnu/packages/patches/polkit-CVE-2021-4034.patch
>>
>> Hi!
>>
>> We could avoid grafting and instead use 'polkit/fixed' in 'setuid-
>> programs', but it seems safer and less error-prone to graft.
>>
>> Thoughts?
> Given that there is also a duktape variant, a graft is necessary, no?
> On a related note, polit-duktape inherits polkit-mozjs in a way that
> does not require adding a separate graft for it, right? Assuming both
> of the above hold, LGTM.
The duktape variant is defined with ‘package/inherit’ and thus it
automatically gets a replacement with the patch:
--8<---------------cut here---------------start------------->8---
$ ./pre-inst-env guix build polkit-duktape --no-grafts
/gnu/store/z92ymaf84ij8f37cm1wrkkmgrw2slrym-polkit-duktape-0.120
$ ./pre-inst-env guix build polkit-duktape
/gnu/store/3g55nhkcbc0a4l7b26gxsalxq0rq1cs7-polkit-duktape-0.121
$ guix gc -R $(./pre-inst-env guix build polkit-duktape -d) |grep polkit-CVE
/gnu/store/lxms944bda56ll590dsrkkhc9n2h3xws-polkit-CVE-2021-4034.patch
--8<---------------cut here---------------end--------------->8---
Pushed as 3993d33d1c0129b1ca6f0fd122fe2bbe48e4f093.
Thanks for taking a look!
Ludo’.
prev parent reply other threads:[~2022-01-26 17:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 11:56 [bug#53549] [PATCH] gnu: polkit: Fix CVE-2021-4034 Ludovic Courtès
2022-01-26 15:14 ` Liliana Marie Prikler
2022-01-26 16:56 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735lah1ve.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=53549-done@debbugs.gnu.org \
--cc=liliana.prikler@ist.tugraz.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).