From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Cees de Groot <cg@evrl.com>
Cc: 53707-done@debbugs.gnu.org
Subject: bug#53707: [PATCH] Fix bad substitution in Elixir recipe
Date: Wed, 23 Feb 2022 22:01:38 -0500 [thread overview]
Message-ID: <8735k9m0h9.fsf@gmail.com> (raw)
In-Reply-To: <HcPAHj0lMs-lzPfM1-l9nqLh5c09NRtoqdJPmiZgTJgmFCy-u0MaTK-Qel-z9nHcxF4gdR64FqwugE9Xd4OGj4mp-CMr8hpzv77PCvlbE1U=@evrl.com> (Cees de Groot's message of "Tue, 01 Feb 2022 18:32:09 +0000")
Hi,
Cees de Groot <cg@evrl.com> writes:
>>From d8148d5bb2d17f96c1a8034b1854f2b9f890e37a Mon Sep 17 00:00:00 2001
> From: Cees de Groot <cg@evrl.com>
> Date: Tue, 1 Feb 2022 13:29:33 -0500
> Subject: [PATCH] Fix /bin/sh replacement for Elixir
>
> I have no clue where this went wrong, but substituting "sh" instead of "/bin/sh" was bound to fail. Maybe something upstream changed? In any case, this should be more correct.
>
> ---
> gnu/packages/elixir.scm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/packages/elixir.scm b/gnu/packages/elixir.scm
> index 3fb74a56a5..fae8279e5c 100644
> --- a/gnu/packages/elixir.scm
> +++ b/gnu/packages/elixir.scm
> @@ -68,7 +68,7 @@ (define-public elixir
> (substitute* '("lib/mix/lib/mix/release.ex"
> "lib/mix/lib/mix/tasks/release.init.ex")
> (("#!/bin/sh")
> - (string-append "#!" (search-input-file inputs "sh"))))
> + (string-append "#!" (search-input-file inputs "/bin/sh"))))
> (substitute* "bin/elixir"
> (("^ERTS_BIN=$")
> (string-append
> --
> 2.34.0
This has already been fixed by Ludovic in commit
d5353e24700102eb3fbf872800135b13e0268ea1.
Closing.
Maxim
prev parent reply other threads:[~2022-02-24 3:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 18:32 [bug#53707] [PATCH] Fix bad substitution in Elixir recipe Cees de Groot
2022-02-24 3:01 ` Maxim Cournoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735k9m0h9.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=53707-done@debbugs.gnu.org \
--cc=cg@evrl.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).