From: zimoun <zimon.toutoune@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Maxime Devos <maximedevos@telenet.be>, 50238@debbugs.gnu.org
Subject: [bug#50238] [PATCH] build-self: Try printing nicer error messages.
Date: Tue, 08 Mar 2022 20:22:32 +0100 [thread overview]
Message-ID: <8735js45c7.fsf_-_@gmail.com> (raw)
In-Reply-To: <87r1denq09.fsf@gnu.org> ("Ludovic Courtès"'s message of "Fri, 24 Sep 2021 13:59:18 +0200")
Hi,
On ven., 24 sept. 2021 at 13:59, Ludovic Courtès <ludo@gnu.org> wrote:
> I sympathize with the goal but unsure about the implementation.
On one hand, I agree that the import of '(guix ui)' here feels "hum, it
seems an incorrect location", but...
> To me, compute-guix-derivation should remain as simple as possible and
> it shouldn't take care of UI concerns. Having said that, I don't know
> how to address the problem above while sticking to this principle.
...on the other hand, where 'build-program' is called, i.e, 'build,
there is:
--8<---------------cut here---------------start------------->8---
(format (current-error-port) "Computing Guix derivation for '~a'... "
system)
--8<---------------cut here---------------end--------------->8---
which is UI, no? Idem for the message "You found a bug".
Well, I am unsure about the addition of '(guix ui)' and by
'with-error-handlng' in 'build-program'. However, maybe the exception
handling could happen in the 'build' part. WDYT?
Cheers,
simon
next prev parent reply other threads:[~2022-03-08 19:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-28 14:36 [bug#50238] [PATCH] build-self: Try printing nicer error messages Maxime Devos
2021-09-24 11:59 ` Ludovic Courtès
2022-03-08 19:22 ` zimoun [this message]
2022-03-09 13:18 ` Maxime Devos
2022-03-08 18:58 ` Maxime Devos
2022-03-19 9:13 ` [bug#50238] [PATCH] build-self: Try printing nicer error messages --- verifying if it doesn't break anything Maxime Devos
2022-03-22 20:46 ` Maxime Devos
2022-03-22 20:55 ` Maxime Devos
2022-03-22 20:57 ` Maxime Devos
2022-03-22 22:24 ` [bug#50238] [PATCH v2] build-self: Try printing nicer error messages Maxime Devos
2022-03-27 20:17 ` Maxime Devos
2022-05-06 12:48 ` [bug#50238] [PATCH] " Maxime Devos
2022-06-13 2:03 ` Maxime Devos
2022-07-09 20:39 ` [bug#50238] Bug in compute-guix-derivation Maxime Devos via Guix-patches
2022-07-30 11:18 ` [bug#50238] [PATCH] build-self: Try printing nicer error messages Maxime Devos
2022-08-13 19:38 ` Maxime Devos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735js45c7.fsf_-_@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=50238@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).