From: Remco van 't Veer <remco@remworks.net>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 54352@debbugs.gnu.org
Subject: [bug#54352] [PATCH v2] services: dnsmasq: Add more options.
Date: Sun, 20 Mar 2022 13:22:00 +0100 [thread overview]
Message-ID: <8735jcddav.fsf@remworks.net> (raw)
In-Reply-To: <d718ef347744dee1adef0b66dc87a083bfb92126.camel@telenet.be>
2022/03/20 12:56, Maxime Devos:
> It would be nice to verify that these are, in fact, booleans,
> using field sanitizers. See, e.g., ensure-setuid-program-list
> in (gnu system).
I agree but the same could be said about the other fields and types in
this record, and those of other services. In this case, the names of
the fields ending with "?" should be enough for somebody to realise this
is a boolean, IMHO. The ";boolean" comments I've added are just me
trying to blend in.
next prev parent reply other threads:[~2022-03-20 12:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-12 15:48 [bug#54352] [PATCH] services: dnsmasq: Add more options Remco van 't Veer
2022-03-19 10:54 ` Ludovic Courtès
2022-03-20 11:42 ` Remco van 't Veer
2022-03-20 11:44 ` [bug#54352] [PATCH v2] " Remco van 't Veer
2022-03-20 11:56 ` Maxime Devos
2022-03-20 12:22 ` Remco van 't Veer [this message]
2022-03-20 12:30 ` Maxime Devos
2022-03-20 13:04 ` Remco van 't Veer
2022-03-21 15:22 ` [bug#54352] [PATCH] " Ludovic Courtès
2022-03-21 18:36 ` Maxime Devos
2022-03-22 7:36 ` Remco van 't Veer
2022-03-22 10:02 ` Ludovic Courtès
2022-03-23 7:09 ` Remco van 't Veer
2022-03-20 12:31 ` [bug#54352] [PATCH v2] " Maxime Devos
2022-03-20 12:58 ` Remco van 't Veer
2022-03-20 12:32 ` Maxime Devos
2022-03-20 12:57 ` Remco van 't Veer
2022-03-20 13:16 ` Maxime Devos
2022-03-22 7:54 ` Remco van 't Veer
2022-03-20 12:36 ` Maxime Devos
2022-03-20 13:15 ` Remco van 't Veer
2022-03-20 13:17 ` Maxime Devos
2022-03-22 7:48 ` Remco van 't Veer
2022-03-20 13:20 ` Maxime Devos
2022-03-22 7:40 ` Remco van 't Veer
2022-03-23 7:07 ` [bug#54352] [PATCH v3] " Remco van 't Veer
2022-03-24 11:22 ` bug#54352: [PATCH] " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735jcddav.fsf@remworks.net \
--to=remco@remworks.net \
--cc=54352@debbugs.gnu.org \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).