From: Evgenii Lepikhin via Guix-patches via <guix-patches@gnu.org>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 54644@debbugs.gnu.org, Efraim Flashner <efraim@flashner.co.il>
Subject: [bug#54644] [PATCH 4/7] gnu: rust-minimal-lexical 0.2: Update to 0.2.1.
Date: Fri, 01 Apr 2022 01:30:05 +0300 [thread overview]
Message-ID: <8735ixkb6a.fsf@corp.mail.ru> (raw)
In-Reply-To: <0c2a7709fdcecba01dba80c4dddad55cb8c06a01.camel@telenet.be> (Maxime Devos's message of "Thu, 31 Mar 2022 17:40:33 +0200")
[-- Attachment #1: Type: text/plain, Size: 1881 bytes --]
Hello there,
On 2022-03-31 17:40, Maxime Devos wrote:
>> > Instead of defining a new package, WDYT renaming 'rust-minimal-
>> lexical-
>> > 0.1' to 'rust-minimal-lexical' and updating it to 0.2? If so,
>> you'll
>> > have to check if rust-nom@7 still builds.
>>
>> semver is very strongly followed in the rust community, so 0.1 isn't
>> necessarily compatible with 0.2. That's how we've ended up with the
>> numerical suffix on all the rust packages.
>
> It isn't 100% theoretically compatible. However, it might be
> _sufficiently_ compatible for all packages using rust-minimal-lexical
> in Guix. The same seems to hold often for non-Rust packages, I don't
> see a reason to make an exception for Rust. Why do we package separate
> 0.Y versions (or separate major versions, for that matter) for Rust
> packages and not for, say, Guile, Python and C packages?
nom-7.0 is not forward compatible with nom-7.1. I need 7.1 for future contributions and this is why I added it into patchset. In developer's manifest of nom-7.1 dependency on rust-minimal-lexical has been updated from 0.1 to 0.2. For both versions dependencies on exact versions on rust-minimal-lexical are pinned by crate developers and we cannot change it at will. Multiple packages depends on rust-nom-7. At least on of them, rust-rusticata-macros, requires nom 7.0 exactly. Thus, we need rust-nom-7.1 as a separate package.
g
It looks like the standard here in Guix:
$ grep -P 'define-public [^ ]+-\d+[.]\d+$' gnu/packages/crates-io.scm | wc -l
2320 Rust packages in form PACKAGENAME-X.Y
$ grep -P 'define-public [^ ]+-\d+$' gnu/packages/crates-io.scm | wc -l
536 Rust packages in form PACKAGENAME-X
$ grep -P 'define-public [^ ]+\D$' gnu/packages/crates-io.scm|wc -l
3 Rust packages in form PACKAGENAME
Thank you for review! I am newbie Guix contributor.
--
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 865 bytes --]
next prev parent reply other threads:[~2022-03-31 22:31 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 21:21 [bug#54644] [PATCH 1/7] gnu: rust-nom-locate-4: Add 4.0.0 Evgenii Lepikhin via Guix-patches via
2022-03-30 21:33 ` [bug#54644] [PATCH 2/7] gnu: rust-pretty 0.11: Update to 0.11.2 Evgenii Lepikhin via Guix-patches via
2022-03-30 21:35 ` [bug#54644] [PATCH 3/7] gnu: rust-located-yaml 0.2: Update to 0.2.1 Evgenii Lepikhin via Guix-patches via
2022-03-30 21:35 ` [bug#54644] [PATCH 4/7] gnu: rust-minimal-lexical " Evgenii Lepikhin via Guix-patches via
2022-03-31 11:59 ` Maxime Devos
2022-03-31 12:01 ` Maxime Devos
2022-03-31 14:47 ` Efraim Flashner
2022-03-31 15:40 ` Maxime Devos
2022-03-31 22:30 ` Evgenii Lepikhin via Guix-patches via [this message]
2022-04-01 6:38 ` Maxime Devos
2022-04-01 13:51 ` Evgenii Lepikhin via Guix-patches via
2022-04-01 15:32 ` Maxime Devos
2022-03-30 21:36 ` [bug#54644] [PATCH 5/7] gnu: rust-nom 7.1: Update to 7.1.1 Evgenii Lepikhin via Guix-patches via
2022-03-30 21:37 ` [bug#54644] [PATCH 6/7] gnu: rust-serde-regex 1: Update to 1.1.0 Evgenii Lepikhin via Guix-patches via
2022-03-31 11:56 ` Maxime Devos
2022-03-31 19:16 ` Maxime Devos
2022-03-31 11:58 ` Maxime Devos
2022-03-31 14:48 ` Efraim Flashner
2022-03-30 21:37 ` [bug#54644] [PATCH 7/7] gnu: Add copyright for myself Evgenii Lepikhin via Guix-patches via
2022-04-01 21:54 ` [bug#54644] [PATCH v2 1/6] gnu: rust-nom-locate-4: Add 4.0.0 Evgenii Lepikhin via Guix-patches via
2022-04-01 21:54 ` [bug#54644] [PATCH v2 2/6] gnu: rust-pretty 0.11: Update to 0.11.2 Evgenii Lepikhin via Guix-patches via
2022-04-01 21:54 ` [bug#54644] [PATCH v2 3/6] gnu: rust-located-yaml: Add 0.2.1 Evgenii Lepikhin via Guix-patches via
2022-04-01 21:54 ` [bug#54644] [PATCH v2 4/6] gnu: rust-nom 7: Update to 7.1.1 Evgenii Lepikhin via Guix-patches via
2022-04-01 21:54 ` [bug#54644] [PATCH v2 5/6] gnu: rust-serde-regex: Add 1.1.0 Evgenii Lepikhin via Guix-patches via
2022-04-01 21:54 ` [bug#54644] [PATCH v2 6/6] Add copyright for myself Evgenii Lepikhin via Guix-patches via
2022-05-16 13:49 ` [bug#54644] [PATCH v2 1/6] gnu: rust-nom-locate-4: Add 4.0.0 Evgenii Lepikhin via Guix-patches via
2022-05-30 8:18 ` bug#54644: " Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735ixkb6a.fsf@corp.mail.ru \
--to=guix-patches@gnu.org \
--cc=54644@debbugs.gnu.org \
--cc=e.lepikhin@corp.mail.ru \
--cc=efraim@flashner.co.il \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).