From: Guillaume Le Vaillant <glv@posteo.net>
To: Maxime Devos <maximedevos@telenet.be>
Cc: "Paul A. Patience" <paul@apatience.com>, 54876@debbugs.gnu.org
Subject: [bug#54876] [PATCH] gnu: sbcl-py4cl: Fix path to python3.
Date: Tue, 12 Apr 2022 13:15:59 +0000 [thread overview]
Message-ID: <8735iiwi3m.fsf@kitej> (raw)
In-Reply-To: <1a38e6e61473683ff134dd477042b061ff605ac0.camel@telenet.be>
[-- Attachment #1: Type: text/plain, Size: 1256 bytes --]
Maxime Devos <maximedevos@telenet.be> skribis:
> Paul A. Patience schreef op di 12-04-2022 om 02:55 [+0000]:
> + (substitute* "src/callpython.lisp"
> + (("\\*python-command\\* \"python\"")
> + (string-append "*python-command* "
> + "\"" (which "python3") "\"")))))
>
> This is most likely incorrect when cross-compiling. Do
>
> (lambda* (#:key inputs #:allow-other-keys)
> [...]
> (string-append [...] (search-input-file inputs "bin/python3") [...]) [...])
>
> instead, such that it looks in 'inputs' instead of 'native-inputs'.
The two are equivalent because so far asdf-build-system doesn't support
cross builds using "--target=TRIPLET". But using 'search-input-file'
looks better.
> Also, now that 'python3' is patched in, is the following still relevant:
>
> (propagated-inputs
> ;; This package doesn't do anything without python available
> (list python
>
> (I mean, does it still need to be propagated?)
Indeed, having python3 in 'inputs' should be enough now.
Pushed in 59377f88ed1e31d38b34279f393949bf17e505ad.
Thanks.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]
next prev parent reply other threads:[~2022-04-12 13:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 2:55 [bug#54876] [PATCH] gnu: sbcl-py4cl: Fix path to python3 Paul A. Patience
2022-04-12 12:07 ` bug#54876: " Guillaume Le Vaillant
2022-04-12 12:46 ` [bug#54876] " Maxime Devos
2022-04-12 13:15 ` Guillaume Le Vaillant [this message]
2022-04-12 13:36 ` Paul A. Patience
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735iiwi3m.fsf@kitej \
--to=glv@posteo.net \
--cc=54876@debbugs.gnu.org \
--cc=maximedevos@telenet.be \
--cc=paul@apatience.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).