From: "Ludovic Courtès" <ludo@gnu.org>
To: Alexey Abramov <levenson@mmer.org>
Cc: 55034@debbugs.gnu.org
Subject: [bug#55034] [PATCH 0/1] Let openssh trust /gnu/store
Date: Wed, 20 Apr 2022 12:02:12 +0200 [thread overview]
Message-ID: <8735i8oyxn.fsf_-_@gnu.org> (raw)
In-Reply-To: <20220420084913.4113-1-levenson@mmer.org> (Alexey Abramov's message of "Wed, 20 Apr 2022 10:49:13 +0200")
Alexey Abramov <levenson@mmer.org> skribis:
> + safe_path(const char *name, struct stat *stp, const char *pw_dir,
> + uid_t uid, char *err, size_t errlen)
> + {
> ++ static const char gnu_store[] = "/gnu/store";
> + char buf[PATH_MAX], homedir[PATH_MAX];
> + char *cp;
> + int comparehome = 0;
> +@@ -2178,6 +2179,10 @@ safe_path(const char *name, struct stat *stp, const char *pw_dir,
> + }
> + strlcpy(buf, cp, sizeof(buf));
> +
> ++ /* If are past the Guix /gnu/store then we can stop */
> ++ if (strcmp(gnu_store, buf) == 0)
> ++ break;
We should not hard-code “/gnu/store” because it can be something else.
I think you can do like what ‘gcc-dl-cache.patch’ does: replace the
literal "/gnu/store" by @STORE_DIRECTORY@, and substitute it in a phase.
Also note that the strcmp above is incorrect: it would accept
/gnu/storesomethinglese. You probably need to add a trailing slash to
be sure.
Thanks,
Ludo’.
next prev parent reply other threads:[~2022-04-20 10:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 8:47 [bug#55034] [PATCH 0/1] Let openssh trust /gnu/store Alexey Abramov via Guix-patches via
2022-04-20 8:49 ` [bug#55034] [PATCH 1/1] gnu: openssh: Trust /gnu/store directory Alexey Abramov via Guix-patches via
2022-04-20 10:02 ` Ludovic Courtès [this message]
2022-04-22 7:02 ` [bug#55034] [PATCH 0/1] Let openssh trust /gnu/store Alexey Abramov via Guix-patches via
2022-04-20 9:56 ` Ludovic Courtès
2022-04-22 6:44 ` Alexey Abramov via Guix-patches via
2022-04-27 21:54 ` Ludovic Courtès
2022-04-20 10:17 ` Tobias Geerinckx-Rice via Guix-patches via
2022-04-20 10:20 ` Tobias Geerinckx-Rice via Guix-patches via
2022-04-22 7:33 ` Alexey Abramov via Guix-patches via
2022-04-26 7:25 ` [bug#55034] [PATCH v2] gnu: openssh: Trust Guix store directory Alexey Abramov via Guix-patches via
2022-04-28 22:07 ` bug#55034: [PATCH 0/1] Let openssh trust /gnu/store Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735i8oyxn.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=55034@debbugs.gnu.org \
--cc=levenson@mmer.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).