unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <othacehe@gnu.org>
To: "J. Sims" <jtsims@protonmail.com>
Cc: 55510@debbugs.gnu.org
Subject: [bug#55510] [PATCH] gnu: qpwgraph: Add qpwgraph.
Date: Sun, 05 Jun 2022 21:37:24 +0200	[thread overview]
Message-ID: <8735ginbpn.fsf@gnu.org> (raw)
In-Reply-To: <jZ2MdgKVH08B8uOpaJAoaVBKD8zdxKSC6gEH79L-V6gWETzZfigMnEK5mzwu0yVnVp2z_-MuzON57qD-4aQv04IKOcgMe6vy6AWDM95jcdo=@protonmail.com> (J. Sims's message of "Wed, 18 May 2022 19:56:51 +0000")


Hello,

Thanks for this patch.

> +    (version "0.2.6")

Looks like the 0.3.1 is out there.

> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://gitlab.freedesktop.org/rncbc/qpwgraph")
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "1gn4zy1b4hggk9andh7cbwkrd7l4djmnipbyyyv9srcsnvqv3wkg"))))
> +    (build-system cmake-build-system)
> +    (arguments
> +     `(#:tests? #f))

Why are the tests disabled?

> +     "qpwgraph is a graph manager dedicated to PipeWire, using the Qt C++ framework.
> +It provides a visual interface to audio and video connections managed by PipeWire.")

Those two lines are too long, please wrap them.

Thanks,

Mathieu




  reply	other threads:[~2022-06-05 19:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-18 19:56 [bug#55510] [PATCH] gnu: qpwgraph: Add qpwgraph J. Sims via Guix-patches via
2022-06-05 19:37 ` Mathieu Othacehe [this message]
2022-07-03 21:29 ` J. Sims via Guix-patches via
2022-07-06  8:17   ` bug#55510: " Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735ginbpn.fsf@gnu.org \
    --to=othacehe@gnu.org \
    --cc=55510@debbugs.gnu.org \
    --cc=jtsims@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).