From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id iLPeHI6jpmJd3QAAbAwnHQ (envelope-from ) for ; Mon, 13 Jun 2022 04:40:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 8CXXHI6jpmK1nAAA9RJhRA (envelope-from ) for ; Mon, 13 Jun 2022 04:40:14 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6878A337BF for ; Mon, 13 Jun 2022 04:40:13 +0200 (CEST) Received: from localhost ([::1]:50890 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o0Zzw-0002GO-H7 for larch@yhetil.org; Sun, 12 Jun 2022 22:40:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40182) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0Zzo-0002E6-HM for guix-patches@gnu.org; Sun, 12 Jun 2022 22:40:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34701) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o0Zzo-00031v-2a for guix-patches@gnu.org; Sun, 12 Jun 2022 22:40:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o0Zzn-0001En-QY for guix-patches@gnu.org; Sun, 12 Jun 2022 22:40:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54529] Checking In Resent-From: Christine Lemmer-Webber Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 13 Jun 2022 02:40:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54529 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Rodriguez Cc: 54529@debbugs.gnu.org X-Debbugs-Original-Cc: 54529@debbugs.gnu.org, guix-patches@gnu.org Received: via spool by 54529-submit@debbugs.gnu.org id=B54529.16550880024747 (code B ref 54529); Mon, 13 Jun 2022 02:40:03 +0000 Received: (at 54529) by debbugs.gnu.org; 13 Jun 2022 02:40:02 +0000 Received: from localhost ([127.0.0.1]:56830 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0Zzl-0001EF-A1 for submit@debbugs.gnu.org; Sun, 12 Jun 2022 22:40:01 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:33201) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0Zzh-0001Dr-Oc for 54529@debbugs.gnu.org; Sun, 12 Jun 2022 22:39:59 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id C39303200972; Sun, 12 Jun 2022 22:39:51 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sun, 12 Jun 2022 22:39:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dustycloud.org; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1655087991; x=1655174391; bh=IU umqGfG/4iUBsuZKuOW/Ox6E4unnnvHO3Mig2kRLlg=; b=MwjzzWzREL7KG1JQe5 rOAA80+oz14Y76VwDMp0z7q2oBg6I5jsTm/xF4CbD2ElCBW2Pi01feEj4QDLjkuW 6pub33bh+pDo7HdSiS4mb8PshxoDbIG9E8ph8m3v+RB055qxW95PDzblyjTen3Bm zj4+IxZVQUZ6dMN5EsOnxq4Skj37YGx1FJ7sPC1ZlZqGzuXBZa46b6Mmi9KFjACf y3fh0LwAxpG4eJxRRSF1XYHFkQUqHW1RG4jrn3GVD5GiEna9UcNvDGyCO01GVBPr 8U5tZhP/cth0PJQCikRnNk8ceAbpPsraIjz6ipy5WkPyocLicp4uzoUsDXQLA5uC VOpw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1655087991; x=1655174391; bh=IUumqGfG/4iUBsuZKuOW/Ox6E4un nnvHO3Mig2kRLlg=; b=AQZKLz/K+IWVsw+9FagsPmMWBU6SGt9FJqF0MklZUr26 75q6KHrEQZ0nQi3PktvhavskaU2ww3n2OSv+j/PpKO2nIwcj5QtOYgTBmYIgZwdS swHKkGm4exwxjdME7yldwhYTdpEDUl12ZV+SYUTaGCh5JA9DMvAU1yQ1IZbQEGpV aymM5P3FlMhCHXkkTepdj5q5Fs1MOhtGS/38FUYmL75Lw8FdiXThwgrgMDeMrNGv qH/MS9JtEmcLUSmwkgL/D2aVTwxsLRCp+gBhkV3g9DGu038TsJudkrguhzHrXOO0 hfx8hQwnZVLF6Wun/mNVHBxH6NcXt8FJVAkKKpKLIw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudduiedgheejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpehffgfhvfevufffjgfkgggtsehttd ertddtredtnecuhfhrohhmpeevhhhrihhsthhinhgvucfnvghmmhgvrhdqhggvsggsvghr uceotgifvggssggvrhesughushhthigtlhhouhgurdhorhhgqeenucggtffrrghtthgvrh hnpeeuffeftdffteffvdfghfelgfeutdefuedtvefgudeuleegveduteeuvdeghfeikeen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegtfigvsg gsvghrseguuhhsthihtghlohhuugdrohhrgh X-ME-Proxy: Feedback-ID: i006446df:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 12 Jun 2022 22:39:50 -0400 (EDT) References: <20220322224614.5605-1-yewscion@gmail.com> <87k0bi4eac.fsf@dustycloud.org> <87mtejf5hu.fsf@dustycloud.org> User-agent: mu4e 1.6.10; emacs 27.2 From: Christine Lemmer-Webber Date: Sun, 12 Jun 2022 22:38:52 -0400 In-reply-to: Message-ID: <8735g9e16x.fsf@dustycloud.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1655088014; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=IUumqGfG/4iUBsuZKuOW/Ox6E4unnnvHO3Mig2kRLlg=; b=qO4BQgroXeh78GhkQRof32CoToSxJSxfWJyoaE7yY3NYappQPpAghelnAnjVWSTK5d+xx/ NnHMsSixZ7diwB3R2j1xWWXovc9wkkdKEdgEOW1IiTdi3xXKj/iTdlyWsuAZ2CsmdINCAU selaMO8qOQYHLgnedKzu/lTFFwaviUHGbMY9aJNN6/afU3WeNUmRxcsFFS3+KuVPZn0JFk Q4NavMGKhVnGe4Gok6+t8JIG825DIOoJ1ZazbS125CxwiIQro2Rem+CoRfuROL8M7zLODl baPMnyiCvEuEpqeKd993mT6eaY4pLHta4FLialJ/IoN8c6Jy64wHl+uz0gHZEQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1655088014; a=rsa-sha256; cv=none; b=uGmbl4K6FBEnHg/O1n8/M5yonTcKGT8io7YXZlwr6x35c7DcUp4f6eMlageoFWCVAF0ldI UyU8q76tqPmZZAZL6i48C8nqrxa3Bi1Q+aYUT2WZZCbvtcJzdC+Jv6bs62g938vYvSd2wn Zx3zUz6PXsGGPWNbtWwtHJN4cp3tGipscIkyARcrvp3m1GmCZiu9IQrJRoZqd9QYhqeT7X /v9ZsgNwc/+uSIDjt1/BYfbqlb2j8kB4DsfH+dZN3vAorp+g9iIDGA0fnvLiV7nkw37FQg 0cB7xHbcT4LPC0uottL/wxDNSKIgunhzq9V6hOKfgPiEXONDdKcCbeh+9nx/tw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=dustycloud.org header.s=fm2 header.b=MwjzzWzR; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b="AQZKLz/K"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 0.11 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=dustycloud.org header.s=fm2 header.b=MwjzzWzR; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b="AQZKLz/K"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 6878A337BF X-Spam-Score: 0.11 X-Migadu-Scanner: scn0.migadu.com X-TUID: 4tnwDruPCQcS Christopher Rodriguez writes: > [[PGP Signed Part:Undecided]] > > Christine Lemmer-Webber writes: > >> Hello! Checking in on this again. > > Hi Christine! > >> If you give an updated version of the patch, it can be merged I think. >> With the commented out part, I'm uncertain whether or not it was >> commented out because it's no longer needed or because it was but you >> were debugging, based on what you've said so that's the main concern I >> have. > > I will rebase the patch on a new pull of guix from git, clean it up, and > send it here within the next hour or so. That way, I'll be sure that it > still works with all of the changes since then and now. Awesome! >> Could you also use git format-patch for the next version you send? >> That'll make it easy to apply! > > Between my last comment and now I've become used to the `git send-email` > style workflow. Is that what You are asking for? If not, let me know and > I will send a patch in the preferred format ASAP. Yep, that's what i mean :) >> Thanks! Sorry for the delays on this review cycle! It's busy here. > > No worries! Frankly, looking at the number and depth of the commits that > GNU Guix gets on a daily basis, I'm very impressed with the speed with > which our maintainers work! Thank You all for Your efforts; they are > very appreciated! > >> - Christine I'm not a maintainer, and not nearly often enough a reviewer (or contributor), but I agree :)