From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 6L4pL0PNq2IKpgAAbAwnHQ (envelope-from ) for ; Fri, 17 Jun 2022 02:39:31 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id sLYeL0PNq2ImcQAA9RJhRA (envelope-from ) for ; Fri, 17 Jun 2022 02:39:31 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 600533AC85 for ; Fri, 17 Jun 2022 02:39:30 +0200 (CEST) Received: from localhost ([::1]:47930 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o201H-00075j-AB for larch@yhetil.org; Thu, 16 Jun 2022 20:39:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51424) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o200s-00075J-AC for guix-patches@gnu.org; Thu, 16 Jun 2022 20:39:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49467) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o200r-00058f-RG for guix-patches@gnu.org; Thu, 16 Jun 2022 20:39:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o200r-0003Fs-Le for guix-patches@gnu.org; Thu, 16 Jun 2022 20:39:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55845] [PATCH 0/1] Improve pager selection logic when less is not installed Resent-From: Taiju HIGASHI Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 17 Jun 2022 00:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55845 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 55845@debbugs.gnu.org, me@tobias.gr, Maxime Devos Received: via spool by 55845-submit@debbugs.gnu.org id=B55845.165542631212477 (code B ref 55845); Fri, 17 Jun 2022 00:39:01 +0000 Received: (at 55845) by debbugs.gnu.org; 17 Jun 2022 00:38:32 +0000 Received: from localhost ([127.0.0.1]:43364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o200J-0003F5-J2 for submit@debbugs.gnu.org; Thu, 16 Jun 2022 20:38:32 -0400 Received: from mail-pl1-f174.google.com ([209.85.214.174]:39554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o200H-0003Et-VT for 55845@debbugs.gnu.org; Thu, 16 Jun 2022 20:38:26 -0400 Received: by mail-pl1-f174.google.com with SMTP id a17so603850pls.6 for <55845@debbugs.gnu.org>; Thu, 16 Jun 2022 17:38:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=taiju-info.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=nTTa0HItTyFdhtnN9A1q51E1WTer6WmatWC7mffyROA=; b=DfcJLk02/Z6fKR5JKEDbrjtYmya60Bo9gh2P41uG9cMmzlSzpNKakGLovLh1xoHwG4 4bX0Z3i/GIdP+n9TlUGm+obc939BWc6NRE+mYOoBfJOz99F3rF53X5azX9U7XF5x4vu9 yuKieJFPGIBTdS/FVQS/DCTFkzxFQF0weI6BoCM3rws1W6PVVxYZav3UaFAxLbMSNwZ4 cxKdD+3Smk/a/O7KrgUoVrALB4lxIuFZmUUuYluCaW5YLHXJinVKjf/dCoWn/D+KSy7r avp7kzKULA7WEeUe5K83kqD5jxgHX+sqY0tkABWIufJStgM3ORT3asg2fyNFR3yVoKgg xMDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=nTTa0HItTyFdhtnN9A1q51E1WTer6WmatWC7mffyROA=; b=WcfdOC5aPRS1ht+MA4ejHiIP1H8xYzbXas0mOgJcz0/VzzYu+YCK/ZLNj95K6nZKxg ad3ouooy6BY5ETcIQHdFGBFVzWQWYq4dTtuKevkzNR8KTcQPj6Jv1UD+2dY6opFjf4CS fpnilttpfJphPc56/nWIk8Kcra+uvkokelkZcuWeQ5hcUU4gbmaxoBc5pl95cJ0U65TN 1+QBFynsZAxi4A2dE/NVRgixjjqPMbPbjS7ZxM7T/xlbFhWC7sT8Yo1MFYq6T+hX9pn2 Gyv20SNrxjPB+GkFzbIVq0M1Gs/Xb0O1wS8KbxNPw5IaXwhtZnxE2YFE8ATg9U7SihQl n8WA== X-Gm-Message-State: AJIora8wQagFCAwuJ/bO+mhXlgdB9MjrbrTnAI6Nd2VhwKncoBALkgDT SZIlqAXVp0KFJeZqWiCJmS/8Fw== X-Google-Smtp-Source: AGRyM1vW6X+PpdrUkqdqPmlvrpH7syUIN/usoI7uPJazV5xqFaTpXhAhVTpa0sBbGg0Mdc9FxiJurg== X-Received: by 2002:a17:902:bd83:b0:167:8dd5:6a5a with SMTP id q3-20020a170902bd8300b001678dd56a5amr7247367pls.114.1655426299705; Thu, 16 Jun 2022 17:38:19 -0700 (PDT) Received: from Taix ([240b:253:ec40:2400:b7d1:436e:2d61:e925]) by smtp.gmail.com with ESMTPSA id e23-20020aa78c57000000b0051c15bb876esm2391046pfd.174.2022.06.16.17.38.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jun 2022 17:38:19 -0700 (PDT) From: Taiju HIGASHI References: <20220608102124.14865-1-higashi@taiju.info> <20220608102257.15042-1-higashi@taiju.info> <87leu72sbo.fsf@taiju.info> <55fe6cdbed891707aca419ff4eedd7c37ef3eb03.camel@telenet.be> <87fskexiyc.fsf@taiju.info> <874k0uxhif.fsf@taiju.info> <5ccb68a4dc80a02baaf6d19fd782145b6b62e7b5.camel@telenet.be> <87a6alwdvn.fsf@taiju.info> <87r13wvrlz.fsf@taiju.info> <8250aad90dcf563aba4103127df95084a25fbd5d.camel@telenet.be> <87bkuzsap7.fsf@taiju.info> <87a6acjncd.fsf_-_@gnu.org> Date: Fri, 17 Jun 2022 09:38:16 +0900 In-Reply-To: <87a6acjncd.fsf_-_@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Thu, 16 Jun 2022 23:43:46 +0200") Message-ID: <8735g4nmyv.fsf@taiju.info> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-2022-jp X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1655426370; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=nTTa0HItTyFdhtnN9A1q51E1WTer6WmatWC7mffyROA=; b=F/57p18CLT3oRH1dqe1O2b33dBT5nNc3Da6aYGmioDQY9Tr/G0Iu7hM/abxVDwtouccQ8v CNq0gqkzfn5sGmzcGXds887t2nuaT2vwaskt9VtPiiUDXXzFlkCNwVAS0VFr62Ho0j4T6w uzDPDlxmAJGAlh5Ae8hDYozuc1IVx3I5o5ugB3b8tsMKB/i3kDb3UHIkA2pIhdk7uUsemZ c/D5fvo/4bi1lMuc4LlMLtrutjmVsoOqzn6jMCNxSxsEHJ3Lb4Mq2s05h+c2IFg7UwiCVk rLtZFP9Zlv756mX/L2+ZqB6jc6oFDmeFYYWHyjpsSixdoiTUz3yuuYlW74ffbg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1655426370; a=rsa-sha256; cv=none; b=kpslAt8NgI3zjtyglV1fgvXSsvau9yRFGe7lAUJVqCo8EXdsheiXlRgwV7f11D88bOj569 76it96hd7yT40NHTc9g6xTr8MfBVQByVhs+d1B123MwxEs4hOO1jkucmh0a12R36SV0wAd HAnJTO5XqT0mio5Hvwxm2NWkoowEBcmU6fjd97MS/gWeU3zeh2FSeb8yFFRhu7ftnG+Jn0 lTLnfMEyhyJvKhLtYVjN6+NszdbAEfTnP0eZtL06ipKNHs1k+lLVAV3ooqI+cPXzeITO8R P2SdJlTe+SSSxRXQ3vK802y0SD8Izlan/jfKQU+zbzvzlLW2HkNaGL+VlOF+EQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=taiju-info.20210112.gappssmtp.com header.s=20210112 header.b=DfcJLk02; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 1.51 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=taiju-info.20210112.gappssmtp.com header.s=20210112 header.b=DfcJLk02; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 600533AC85 X-Spam-Score: 1.51 X-Migadu-Scanner: scn0.migadu.com X-TUID: bS9igrMH8Sj+ Hi Ludovic, > Applied with the cosmetic changes below, mostly aiming to visually > simplify the code and make it consistent with the rest. Thank you for the correction and application! > It’s great that you went to great lengths to implement tests for this, > as Maxime had suggested. To me, the complexity of a test must be > justified by its “bug-finding performance”; in this particular case, I > think we’re borderline: the tests are a little bit complex and unlikely > to find new bugs. > > Thanks for all the work and for your feedback on your experience > programming with Guile! I only discovered the problem, I was able to implement it mostly thanks to Maxime and Tobias! The code review experience was so good that I even posted the following :) https://fosstodon.org/web/@taiju/108458633893022791 https://fosstodon.org/web/@taiju/108458643302758263 I'd like to know for future contributions. I like functional programming and I love compose, (ice-9 curried-definitions), and SRFI 26 in my programs, but should I use them less in the code I put in Guix? Thanks, -- Taiju