From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id gL5tDTzWtGLkJwAAbAwnHQ (envelope-from ) for ; Thu, 23 Jun 2022 23:08:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id yDguDTzWtGKvgwAAauVa8A (envelope-from ) for ; Thu, 23 Jun 2022 23:08:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BF2DDA115 for ; Thu, 23 Jun 2022 23:08:11 +0200 (CEST) Received: from localhost ([::1]:43194 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o4U3e-0001V3-I0 for larch@yhetil.org; Thu, 23 Jun 2022 17:08:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49038) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4U3W-0001TW-DX for guix-patches@gnu.org; Thu, 23 Jun 2022 17:08:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46195) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o4U3W-00020A-5r for guix-patches@gnu.org; Thu, 23 Jun 2022 17:08:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o4U3V-000791-VZ for guix-patches@gnu.org; Thu, 23 Jun 2022 17:08:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55960] [PATCH 5/9] gnu: Add node-ieee754. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 23 Jun 2022 21:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55960 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 55960@debbugs.gnu.org Cc: Nicolas Graves X-Debbugs-Original-To: Nicolas Graves via Guix-patches via , 55960@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.165601844727407 (code B ref -1); Thu, 23 Jun 2022 21:08:01 +0000 Received: (at submit) by debbugs.gnu.org; 23 Jun 2022 21:07:27 +0000 Received: from localhost ([127.0.0.1]:40088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4U2w-00077z-Te for submit@debbugs.gnu.org; Thu, 23 Jun 2022 17:07:27 -0400 Received: from lists.gnu.org ([209.51.188.17]:50636) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4U2v-00077r-8a for submit@debbugs.gnu.org; Thu, 23 Jun 2022 17:07:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48930) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4U2v-0001MI-4H for guix-patches@gnu.org; Thu, 23 Jun 2022 17:07:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49320) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4U2t-0001rY-G2; Thu, 23 Jun 2022 17:07:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=ZSl7AxOT5s6zq56LDWw3yPXBv/Kn86dc2uqmHvtJkTs=; b=HM/zHO4Jq2GKSdklQL+9 xcjZ/fxIKg9TfiO0Tc2/NWYiLrQ7a8NA7EMLqjASva89ieYFd2c54FwVoPjzMelDoQudMZGgkVvAB iXznIX2zYOPPmTh4ImMVOdibLrv8j6LU9esoe+zM68Cj1Jc5tzsnlWJFPg6fK4ZQDJ0ecaOyXxOmx obNeQchSI/JiFw24efZsdC8zG8Z8bVXa2iKX8krLG1t9Ez269Zp+BGpkSQtSYCOY3O1b0Vrwg20ZP SGiYAjPoiaPpQKYABQlYpk2cJnS+H1iFb9j0TpIy1yEXcGbxfXbUtfcxgppHTnrA8No+zJOGig33r ZXfa1o1qcCMC5w==; Received: from host-37-191-236-102.lynet.no ([37.191.236.102]:46178 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4U2t-0005nX-0e; Thu, 23 Jun 2022 17:07:23 -0400 From: Marius Bakke In-Reply-To: <20220614094954.15197-5-ngraves@ngraves.fr> References: <20220614094954.15197-1-ngraves@ngraves.fr> <20220614094954.15197-5-ngraves@ngraves.fr> Date: Thu, 23 Jun 2022 23:07:20 +0200 Message-ID: <8735fvrsvr.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1656018491; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=ZSl7AxOT5s6zq56LDWw3yPXBv/Kn86dc2uqmHvtJkTs=; b=DN3QdFf6Rz10jj9qwkBPZ+poeHIs/lf3d3G2dPvO+VJtxBZ8vZzgu09RKBWVcAICpzEGQY 4AKmkCAnPsziVTFIs274M0R3/IDMEPEx1Tz2lG/k/wMqLNlBT8RAJq2/RGq6dfyQY+gBtP 35L62y8mVcUNU4oLUn3ZyMhIEKSZgIohcYVK3O0xYGRap+QFxeFdDiwZVnOOMkV551/e4O e+9eDBKkHMjWLU3MVOiI7eGgUKj8mnszIoReI//KFUfQFQFtzoU32Sz95tEEq0MRucxuGb 78WX1Tc194tragLGRTnJR4oqk6JSFLb83YKXpj3LRffXRJO/flxmdo2OIhVA5w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1656018491; a=rsa-sha256; cv=none; b=lRVzNHtw0+MQfLmuuFvCYcfT/zjIM/amb0eBPYsg8TTtHkgtcrL4ozMtwS56a+d7yfA47P x2H4xkJ0Ftt3UY0WB+bS1yC0zBgLOfGkPQjR7Rdd6Nqw5fs7Plqjh55lRXAKt4212n3RZe 82y9OrphoEgN+JEqJjtudVVyuNuLnXL/6SuU2FRArPuxBUMdrrAenQ2ipjq16XanExYWz6 BoBtiWBTvcS+8K0/ELDL8iibXeGkthkEWKgo63zwhAxWQqAWt8/c1SnlREoKGBBA8m8h7v DtJQeKo/LQCMbO0/Hl2QNn1BECHCEzXF/YzNg/JH6rEKBAEAm94gaI0f2/8mcA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="HM/zHO4J"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -7.47 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="HM/zHO4J"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: BF2DDA115 X-Spam-Score: -7.47 X-Migadu-Scanner: scn0.migadu.com X-TUID: V+DtuaO8mjD+ --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Nicolas Graves via Guix-patches via skriver: > * gnu/packages/node-xyz.scm (node-ieee754): New variable. > --- > gnu/packages/node-xyz.scm | 31 +++++++++++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > > diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm > index 8f3288f219..3d945871cd 100644 > --- a/gnu/packages/node-xyz.scm > +++ b/gnu/packages/node-xyz.scm > @@ -458,6 +458,37 @@ (define-public node-once > if desired.") > (license license:isc))) >=20=20 > +(define-public node-ieee754 > + (package > + (name "node-ieee754") > + (version "1.2.1") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/feross/ieee754") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "19rlg59lavnwsvbblhvrqwinz2wzqlxhddqpwrc3cyqkscjgza7i")))) > + (build-system node-build-system) > + (arguments > + '(#:phases > + (modify-phases %standard-phases > + (delete 'check) > + (replace 'configure > + (lambda* (#:key inputs #:allow-other-keys) > + (invoke (string-append (assoc-ref inputs "node") "/bin/npm") > + "--offline" "--ignore-scripts" "install" "--product= ion") > + #t))))) I realize all of these were copy-pasted so I won't repeat any more. ;-) > + (home-page "https://github.com/feross/ieee754") > + (synopsis "Read/write IEEE754 floating point numbers from/to a Buffe= r or > +array-like object") > + (description "This package allows to read/write IEEE754 floating poi= nt > +numbers from/to a Buffer or array-like object in Javascript.") Can you try to either shorten the synopsis or expand on the description to avoid duplication? Writing good descriptions is often the most difficult part of writing a package definition... The upstream documentation is not very helpful in this case. :-/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCYrTWCA8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHeKsgEAkhtRtT5gT9TzanP2/UvVmhWbpA47d5uGpxGC AK9nPJkA/3uFXub/pSsI08vAUmjKA/EG7x2kAMssTjXJKmuo0mEC =XZvy -----END PGP SIGNATURE----- --=-=-=--