From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id ULpdEByb6mKMuQAAbAwnHQ (envelope-from ) for ; Wed, 03 Aug 2022 17:58:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id eEJiEByb6mJhPgEA9RJhRA (envelope-from ) for ; Wed, 03 Aug 2022 17:58:20 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EF3E82E509 for ; Wed, 3 Aug 2022 17:58:19 +0200 (CEST) Received: from localhost ([::1]:52906 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oJGlH-0002c0-6j for larch@yhetil.org; Wed, 03 Aug 2022 11:58:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34054) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJGl3-0002Tz-BF for guix-patches@gnu.org; Wed, 03 Aug 2022 11:58:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60057) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oJGl0-00041x-1U for guix-patches@gnu.org; Wed, 03 Aug 2022 11:58:05 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oJGkz-0006Qt-QH for guix-patches@gnu.org; Wed, 03 Aug 2022 11:58:01 -0400 Subject: bug#56867: [PATCH] download: Do not wrap TLS port on GnuTLS >= 3.7.7. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Wed, 03 Aug 2022 15:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 56867 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 56867-done@debbugs.gnu.org Cc: guile-devel@gnu.org Mail-Followup-To: 56867@debbugs.gnu.org, ludo@gnu.org, ludo@gnu.org Received: via spool by 56867-done@debbugs.gnu.org id=D56867.165954227824710 (code D ref 56867); Wed, 03 Aug 2022 15:58:01 +0000 Received: (at 56867-done) by debbugs.gnu.org; 3 Aug 2022 15:57:58 +0000 Received: from localhost ([127.0.0.1]:49805 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJGkv-0006QT-Jm for submit@debbugs.gnu.org; Wed, 03 Aug 2022 11:57:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJGks-0006QG-0S for 56867-done@debbugs.gnu.org; Wed, 03 Aug 2022 11:57:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48388) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJGkm-0003zA-Py; Wed, 03 Aug 2022 11:57:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=AmCAckqpn7x6am8j3opihJE0KLOmiMKLJ5Y7+WCaL70=; b=R7jvl9G8FgLclKI9rpph LciU8lHB4F9MoufVXPFijN88OrSn4feMo7DfgNtKm4i5+n0nrniYE5ECQVJHTssCyKGyK86ZL17K2 PANz1f5gfBJVACAh81Qlt0SNu3RZ9bCM5boZvXpOFEP0x2e0X+gQfeZKXhm+sfKbKkOWVAYr4Juuq 9ziNWQ/+V14GejWjMwuYLt2o+0VfKE7fOshnkeQQPbaMMKOOCyReKvXVnjcLxaxrtxJbdzPUMUZyX sV6fQYrRqf2JPNNFYGVP/vNFJDIhd4q2KIYFJ5Z1U5X/P5GWJ4X8RQyeibZL3OHVtIHnq0IOc6uoL eyCMIDhnCf8VNg==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:58690 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJGkm-0004Al-DD; Wed, 03 Aug 2022 11:57:48 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20220801090749.11655-1-ludo@gnu.org> Date: Wed, 03 Aug 2022 17:57:44 +0200 In-Reply-To: <20220801090749.11655-1-ludo@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Mon, 1 Aug 2022 11:07:49 +0200") Message-ID: <8735eds4jr.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1659542300; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=AmCAckqpn7x6am8j3opihJE0KLOmiMKLJ5Y7+WCaL70=; b=PQJTYpOT+Ke9Q+J+DQmX6SLqsOSWmwFfBgewC4Y27ndUwH7lt0y1ps4k8YKLTh3HVcgXri k+TjYXXubBd0h/Hy72KB61bvmdK/oPqrDQR8b0RJCrrn6sPs+Co5fAQ/RcF0DHfl9mu1hV mMIeVL1JAG9S218neKEct/dbdK7Cc/2mDIVSfmJ3+rytSrGaDqUXwvMIrE3F976dog9pra xtjWEnBl5BjLaPvlh93lFEMtzSv5Cz50sAleirs7jfBadJMG+frR7amuMSbgsmidOEWd9g OPF4ON9lOj8J5svTfQPh8B9BQvhMtg5HUXD4KrYLNobEoJnuR/iao78IpaMt5w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1659542300; a=rsa-sha256; cv=none; b=sBCvG8YEd6AnHBGMsZGks2Z5uJK+2dCr2wfNMTgcbz1RQtIGZZ4qHJ+vvvDNiepCglq3f1 p8c6GBCSOkt7D54hEx+buGI4p+uUggZCgWGU7L8OISt7u5lyWM6gJf5lLeov1xHGzRaEwX 6qYeWwcQek4Xadat0WRgLppCJ6JJN/l8QIz/3CS9cicIbljY/cLhhObaGYleUhb/BhKfnO o5+QAPi/vl8nGq9mna0TCYDDmw4Etm2z0/yQZRvkHBDullX3iCySRRqp1CFFlmCy+xJ6mj CSvjAhEpzM3G/2UfnFiSkGm67qw7xsVNYVHX0eBh9LZ4bEx8MxWt9m7d+vMgww== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=R7jvl9G8; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.81 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=R7jvl9G8; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: EF3E82E509 X-Spam-Score: -3.81 X-Migadu-Scanner: scn1.migadu.com X-TUID: S3HcuJI5dCW9 Ludovic Court=C3=A8s skribis: > The custom input/output port wrapping the TLS session record port would > introduce overhead, and it would also prevent its uses in a non-blocking > context--e.g., with Fibers. The port close mechanism added in GnuTLS > 3.7.7 allows us to get rid of that wrapper. > > * guix/build/download.scm (wrap-record-port-for-gnutls<3.7.7): New > procedure, with code formerly in 'tls-wrap'. > (tls-wrap): Check for 'set-session-record-port-close!' and use it when > available; otherwise call 'wrap-record-port-for-gnutls<3.7.7'. > --- > guix/build/download.scm | 102 +++++++++++++++++++++------------------- > 1 file changed, 54 insertions(+), 48 deletions(-) Pushed as Guix commit dd573ceea73295c7a872088ecd91e5f0fd74bf2b. Ludo=E2=80=99.